Migrated tests from Phpunit to Pest

Author: LaravelFreelancerNL

.github/workflows/run-tests.yml

@@ -13,7 +13,7 @@ jobs:
       matrix:
         os: [ubuntu-latest]
         arangodb: ["3.10", 3.11, 3.12]
-        php: [8.1, 8.2, 8.3]
+        php: [8.2, 8.3]
         stability: [prefer-stable]
 
     name: P${{ matrix.php }} - A${{ matrix.arangodb }} - ${{ matrix.stability }}

composer.json

@@ -46,10 +46,13 @@
     "scripts": {
         "analyse": "vendor/bin/phpstan analyse",
         "test": "vendor/bin/pest",
-        "test:coverage": "vendor/bin/phpunit --coverage-clover clover.xml --whitelist src",
+        "test:coverage": "vendor/bin/pest --coverage-clover clover.xml",
         "style": "vendor/bin/pint"
     },
     "config": {
-        "sort-packages": true
+        "sort-packages": true,
+        "allow-plugins": {
+            "pestphp/pest-plugin": true
+        }
     }
 }

phpunit.xml

@@ -16,6 +16,6 @@
         </include>
     </coverage>
     <php>
-        <env name="ARANGODB_VERSION" value="3.8"/>
+        <env name="ARANGODB_VERSION" value="3.12"/>
     </php>
 </phpunit>

tests/AdminManagerTest.php

@@ -5,6 +5,7 @@
 use ArangoClient\Admin\AdminManager;
 
 uses(Tests\TestCase::class);
+
 beforeEach(function () {
     $this->adminManager = new AdminManager($this->arangoClient);
 });
@@ -28,5 +29,6 @@
 
 test('get running transactions', function () {
     $transactions = $this->adminManager->getRunningTransactions();
+
     expect($transactions)->toBeEmpty();
 });

tests/ArangoClientTest.php

@@ -234,14 +234,3 @@
 
     $this->schemaManager->deleteCollection($collection);
 });
-
-// Helpers
-function checkHttp2Support()
-{
-    // First assert that CURL supports http2!
-    if (!curl_version()['features'] || CURL_VERSION_HTTP2 === 0) {
-        test()->markTestSkipped('The installed version of CURL does not support the HTTP2 protocol.');
-    }
-    // HTTP/2 is only supported by ArangoDB 3.7 and up.
-    test()->skipTestOnArangoVersions('3.7');
-}

tests/ExceptionsTest.php

@@ -1,9 +1,9 @@
 <?php
 
-uses(Tests\TestCase::class);
-
 declare(strict_types=1);
 
+uses(Tests\TestCase::class);
+
 test('test409 conflict exception', function () {
     $database = 'test_arangodb_php_existing_database';
     if (!$this->schemaManager->hasDatabase($database)) {

tests/MonitorManagerTest.php

@@ -72,6 +72,5 @@
 arangodb_aql_local_query_memory_limit_reached_total{role="SINGLE"} 0 2211753600';
 
     $result = $prometheus->parseText($rawMetrics);
-    expect($result)->toBeObject();
     expect($result->arangodb_aql_local_query_memory_limit_reached_total->timestamp)->toEqual(2211753600);
 });

tests/Pest.php

@@ -39,3 +39,14 @@
 */
 
 /** @link https://pestphp.com/docs/custom-helpers */
+
+// Helpers
+function checkHttp2Support()
+{
+    // First assert that CURL supports http2!
+    if (!curl_version()['features'] || CURL_VERSION_HTTP2 === 0) {
+        test()->markTestSkipped('The installed version of CURL does not support the HTTP2 protocol.');
+    }
+    // HTTP/2 is only supported by ArangoDB 3.7 and up.
+    test()->skipTestOnArangoVersions('3.7');
+}

tests/SchemaManagerAnalyzersTest.php

@@ -1,25 +1,21 @@
 <?php
 
+declare(strict_types=1);
+
 uses(Tests\TestCase::class);
 
-declare(strict_types=1);
 beforeEach(function () {
-    \Tests\TestCase::setUp();
-
     if (!$this->schemaManager->hasAnalyzer($this->analyzer['name'])) {
         $this->schemaManager->createAnalyzer($this->analyzer);
     }
 });
 
 afterEach(function () {
-    \Tests\TestCase::tearDown();
-
     if ($this->schemaManager->hasAnalyzer($this->analyzer['name'])) {
         $this->schemaManager->deleteAnalyzer($this->analyzer['name']);
     }
 });
 
-
 test('get analyzers', function () {
     $analyzers = $this->schemaManager->getAnalyzers();
 
@@ -79,11 +75,11 @@
         'name' => 'coolnewanalyzer',
         'type' => 'identity',
     ];
-    $created = $this->schemaManager->createAnalyzer($analyzer);
+    $this->schemaManager->createAnalyzer($analyzer);
 
     $fullName = 'arangodb_php_client__test::' . $analyzer['name'];
 
-    $deleted = $this->schemaManager->deleteAnalyzer($fullName);
+    $this->schemaManager->deleteAnalyzer($fullName);
 
     $hasAnalyzer = $this->schemaManager->hasAnalyzer($fullName);
     expect($hasAnalyzer)->toBeFalse();

tests/SchemaManagerCollectionsTest.php

@@ -1,19 +1,10 @@
 <?php
 
-uses(Tests\TestCase::class);
-
 declare(strict_types=1);
 
-test('get collections before version38', function () {
-    $this->skipTestOnArangoVersions('3.8', '>=');
-    $result = $this->schemaManager->getCollections();
-
-    expect(10)->toBeLessThanOrEqual(count($result));
-    expect($result[0])->toBeObject();
-});
+uses(Tests\TestCase::class);
 
 test('get collections', function () {
-    $this->skipTestOnArangoVersions('3.8', '<');
     $result = $this->schemaManager->getCollections();
 
     expect(8)->toBeLessThanOrEqual(count($result));
@@ -32,8 +23,7 @@
     $result = $this->schemaManager->getCollection($collections[0]->name);
 
     expect($result)->toBeObject();
-    $this->assertObjectHasProperty('name', $result);
-    $this->assertObjectHasProperty('isSystem', $result);
+    expect((array) $result)->toHaveKeys(['globallyUniqueId', 'isSystem', 'status', 'type', 'name', 'id']);
 });
 
 test('has collection', function () {
@@ -131,7 +121,9 @@
     if (!$this->schemaManager->hasCollection($collection)) {
         $this->schemaManager->createCollection($collection);
     }
+
     expect($this->schemaManager->getCollectionWithDocumentCount($collection)->count)->toBe(0);
+
     $query = 'FOR i IN 1..10
       INSERT {
             _key: CONCAT("test", i),
@@ -146,7 +138,11 @@
     $this->schemaManager->truncateCollection($collection);
 
     expect($this->schemaManager->getCollectionWithDocumentCount($collection)->count)->toBe(0);
-    $this->schemaManager->deleteCollection($collection);
+
+    if ($this->schemaManager->hasCollection($collection)) {
+        $this->schemaManager->deleteCollection($collection);
+    }
+
 });
 
 test('create and delete collection', function () {