From ef6fe6a26141bd738ab2f5da86fb0353fc872bb6 Mon Sep 17 00:00:00 2001 From: bhimrazy Date: Fri, 5 Sep 2025 12:44:09 +0545 Subject: [PATCH 1/3] Use `uv` for package installations in Makefile docs cmd to ensure compatibility --- Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 35062b71a4932..d84e4801acb4e 100644 --- a/Makefile +++ b/Makefile @@ -60,17 +60,17 @@ test: clean docs: docs-pytorch sphinx-theme: - pip install -q awscli + uv pip install -q awscli mkdir -p dist/ aws s3 sync --no-sign-request s3://sphinx-packages/ dist/ - pip install lai-sphinx-theme -f dist/ + uv pip install lai-sphinx-theme -f dist/ docs-fabric: clean sphinx-theme - pip install -e .[all] --quiet -r requirements/fabric/docs.txt + uv pip install -e '.[all]' --quiet -r requirements/fabric/docs.txt cd docs/source-fabric && $(MAKE) html --jobs $(nproc) docs-pytorch: clean sphinx-theme - pip install -e .[all] --quiet -r requirements/pytorch/docs.txt + uv pip install -e '.[all]' --quiet -r requirements/pytorch/docs.txt cd docs/source-pytorch && $(MAKE) html --jobs $(nproc) update: From 996e23bae8a522cf9f1ecac7e29eeb795c61b29c Mon Sep 17 00:00:00 2001 From: Bhimraj Yadav Date: Fri, 5 Sep 2025 13:01:37 +0545 Subject: [PATCH 2/3] apply suggestion Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index d84e4801acb4e..89159fc4d3200 100644 --- a/Makefile +++ b/Makefile @@ -59,7 +59,7 @@ test: clean docs: docs-pytorch -sphinx-theme: +sphinx-theme: setup uv pip install -q awscli mkdir -p dist/ aws s3 sync --no-sign-request s3://sphinx-packages/ dist/ From 24095d2848881ee7434fb3b6281105c725db6ee6 Mon Sep 17 00:00:00 2001 From: bhimrazy Date: Fri, 5 Sep 2025 13:04:48 +0545 Subject: [PATCH 3/3] Refactor test target to include setup step and remove redundant pip install commands --- Makefile | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 89159fc4d3200..f99985cb9175c 100644 --- a/Makefile +++ b/Makefile @@ -45,12 +45,8 @@ clean: rm -rf src/lightning_fabric/*/ rm -rf src/pytorch_lightning/*/ -test: clean +test: clean setup # Review the CONTRIBUTING documentation for other ways to test. - pip install -e . \ - -r requirements/pytorch/base.txt \ - -r requirements/fabric/base.txt \ - -r requirements/pytorch/test.txt \ # run tests with coverage python -m coverage run --source src/lightning/pytorch -m pytest src/lightning/pytorch tests/tests_pytorch -v