feat: remove onExit method

BREAKING CHANGE: remove onExit method, move logic to helpers launcher

Author: MatthewPattell

__tests__/services/abstract-microservice-test.ts

@@ -138,30 +138,6 @@ describe('services/abstract-microservice', () => {
       .lengthOf(1);
   });
 
-  it('should correct add onExit handler', () => {
-    const onExitHandler = sinon.spy(() => undefined);
-
-    ms.onExit(onExitHandler);
-
-    // @ts-ignore
-    process.emit('SIGINT', 1);
-
-    expect(onExitHandler).calledOnceWith(1);
-  });
-
-  it('should correct catch onExit handler error', () => {
-    const onExitHandler = sinon.spy(() => {
-      throw new Error('Hello');
-    });
-
-    ms.onExit(onExitHandler);
-
-    // @ts-ignore
-    process.emit('SIGINT', 1);
-
-    expect(onExitHandler).to.throw();
-  });
-
   it('should correct return connection string (SRV)', async () => {
     const srvHost = 'http://srv.local';
 

src/constants/index.ts

@@ -7,15 +7,6 @@ export const LOG_INFO_COLOR = '\x1b[32m%s\x1b[0m'; // green
 
 export const LOG_ERROR_COLOR = '\x1b[31m%s\x1b[0m'; // red
 
-export const PROCESS_EXIT_EVENT_TYPES = [
-  // 'exit',
-  'SIGINT',
-  'SIGUSR1',
-  'SIGUSR2',
-  'uncaughtException',
-  'SIGTERM',
-];
-
 export enum EXCEPTION_CODE {
   ENDPOINT_EXCEPTION = -33000,
   PARSE_ERROR = -32700,

src/interfaces/services/i-abstract-microservice.ts

@@ -34,8 +34,6 @@ interface IInnerRequestParams {
   isThrowError?: boolean;
 }
 
-type ProcessExitHandler = (eventOrExitCodeOrError: Error | number) => void | Promise<void>;
-
 type MiddlewareData<TParams = Record<string, any>, TPayload = Record<string, any>> = {
   task: MicroserviceRequest<TParams, TPayload>;
   result?: IMicroserviceResponse<TParams>['result'];
@@ -127,7 +125,6 @@ export {
   IAbstractMicroserviceOptions,
   IAbstractMicroserviceParams,
   IInnerRequestParams,
-  ProcessExitHandler,
   IMiddlewares,
   MiddlewareData,
   MiddlewareType,

src/services/abstract-microservice.ts

@@ -3,7 +3,7 @@ import http from 'http';
 import axios from 'axios';
 import _ from 'lodash';
 import { v4 as uuidv4 } from 'uuid';
-import { EXCEPTION_CODE, PROCESS_EXIT_EVENT_TYPES } from '@constants/index';
+import { EXCEPTION_CODE } from '@constants/index';
 import BaseException from '@core/base-exception';
 import MicroserviceRequest from '@core/microservice-request';
 import MicroserviceResponse from '@core/microservice-response';
@@ -31,7 +31,6 @@ import type {
   MiddlewareClientRequest,
   MiddlewareData,
   MiddlewareHandler,
-  ProcessExitHandler,
 } from '@interfaces/services/i-abstract-microservice';
 import { MiddlewareType } from '@interfaces/services/i-abstract-microservice';
 import type { TJsonRPC } from '@interfaces/services/i-gateway';
@@ -227,29 +226,6 @@ abstract class AbstractMicroservice {
     return this;
   }
 
-  /**
-   * Add process exit handler
-   * E.g. for close DB connection etc.
-   */
-  public onExit(handler: ProcessExitHandler): void {
-    PROCESS_EXIT_EVENT_TYPES.forEach((eventType) => {
-      process.once(eventType, (eventOrExitCodeOrError: Error | number) => {
-        void (async () => {
-          try {
-            await handler(eventOrExitCodeOrError);
-          } catch (e) {
-            this.logDriver(
-              () => `Process killed with error: ${e.message as string}`,
-              LogType.ERROR,
-            );
-          }
-
-          process.exit(Number(eventOrExitCodeOrError) || 1);
-        })();
-      });
-    });
-  }
-
   /**
    * Validate JSON RPC request
    * @private