fix: incorrect inject field message for exact class extra field #3212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the diagnostic message for injecting an extra field into an exact-class table so that it references the field name rather than the class name.
- Update the message payload in
inject-field.luato use the actual field identifier - Add a changelog entry under Unreleased to document the fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| script/core/diagnostics/inject-field.lua | Use field instead of src when building the diagnostic message |
| changelog.md | Add a FIX entry for the incorrect inject-field message |
Comments suppressed due to low confidence (1)
script/core/diagnostics/inject-field.lua:137
- Consider adding or updating a unit test for the exact-class extra-field diagnostic to verify that the message now correctly mentions the field name instead of the class name.
field = guide.getKeyName(field),
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this display bug while discussing in an issue: #3211 (comment)
before
=> the msg incorrectly uses class name
`A` for `A`after
=> the correct msg should be using the field name
`A` for `b`