fix rubocops around to_sym, kind_of, gsub

Author: kbrock

lib/floe/workflow/choice_rule/data.rb

@@ -111,17 +111,16 @@ def parse_compare_key
             if (match_values = OPERATION.match(key))
               @compare_key = key
               @type, operator, @path = match_values.captures
-              @operation = "op_#{operator.downcase}?".to_sym
+              @operation = :"op_#{operator.downcase}?"
               @compare_predicate = parse_predicate(type)
               break
-            end
             # e.g. (Is)(String)
-            if (match_value = TYPE_CHECK.match(key))
+            elsif (match_value = TYPE_CHECK.match(key))
               @compare_key = key
               _operator, type = match_value.captures
               # type: nil means no runtime type checking.
               @type = @path = nil
-              @operation = "is_#{type.downcase}?".to_sym
+              @operation = :"is_#{type.downcase}?"
               @compare_predicate = parse_predicate("Boolean")
               break
             end
@@ -181,7 +180,7 @@ def fetch_path(field_name, field_path, context, input)
         # if we have runtime checking, check against that type
         #   otherwise assume checking a TYPE_CHECK predicate and check against Boolean
         def correct_type?(value, data_type)
-          send("is_#{data_type.downcase}?".to_sym, value)
+          send(:"is_#{data_type.downcase}?", value)
         end
       end
     end

lib/floe/workflow/context.rb

@@ -148,7 +148,7 @@ def to_h
       end
 
       def ==(other)
-        other.is_a?(self.class) && other.instance_variable_get("@context") == @context
+        other.kind_of?(self.class) && other.instance_variable_get(:@context) == @context
       end
       alias eql? ==
 

spec/workflow/context_spec.rb

@@ -201,8 +201,8 @@
   describe "#inspect" do
     it "has the same value with or without credentials" do
       # removing spaces because Hash#inspect in ruby 3.4 adds spaces that are not present before
-      expect(ctx.inspect.gsub(" ", "")).to eq("#<Floe::Workflow::Context: {\"Execution\" => {\"Input\" => {\"x\" => \"y\"}}, \"State\" => {}, \"StateHistory\" => [], \"StateMachine\" => {}, \"Task\" => {}}>".gsub(" ", ""))
-      expect(ctx_creds.inspect.gsub(" ", "")).to eq("#<Floe::Workflow::Context: {\"Execution\" => {\"Input\" => {\"x\" => \"y\"}}, \"State\" => {}, \"StateHistory\" => [], \"StateMachine\" => {}, \"Task\" => {}}>".gsub(" ", ""))
+      expect(ctx.inspect.delete(" ")).to eq("#<Floe::Workflow::Context: {\"Execution\" => {\"Input\" => {\"x\" => \"y\"}}, \"State\" => {}, \"StateHistory\" => [], \"StateMachine\" => {}, \"Task\" => {}}>".delete(" "))
+      expect(ctx_creds.inspect.delete(" ")).to eq("#<Floe::Workflow::Context: {\"Execution\" => {\"Input\" => {\"x\" => \"y\"}}, \"State\" => {}, \"StateHistory\" => [], \"StateMachine\" => {}, \"Task\" => {}}>".delete(" "))
     end
 
     it "doesn't expose credentials" do
@@ -238,7 +238,7 @@
       end
     end
 
-        describe "#eql?" do
+    describe "#eql?" do
       it "compares with values" do
         ctx1 = described_class.new(:input => input.to_json)
         ctx2 = described_class.new(:input => input.to_json)