Merge pull request #821 from Fryguy/drop_log_collection2

Drop miq_schedules.file_depot_id

Author: jrafanie

db/migrate/20251105160057_drop_miq_schedule_file_depot_records.rb

@@ -0,0 +1,11 @@
+class DropMiqScheduleFileDepotRecords < ActiveRecord::Migration[7.2]
+  class MiqSchedule < ActiveRecord::Base
+    include ActiveRecord::IdRegions
+  end
+
+  def up
+    say_with_time("Dropping schedules attached to file_depot records") do
+      MiqSchedule.in_my_region.where.not(:file_depot_id => nil).delete_all
+    end
+  end
+end

db/migrate/20251105160058_drop_miq_schedule_file_depot.rb

@@ -0,0 +1,5 @@
+class DropMiqScheduleFileDepot < ActiveRecord::Migration[7.2]
+  def change
+    remove_column :miq_schedules, :file_depot_id, :bigint
+  end
+end

spec/migrations/20251104153211_drop_log_collection_configuration_spec.rb

@@ -35,13 +35,14 @@ class MiqUserRole < ActiveRecord::Base; end
     end
 
     it "deletes settings" do
-      keep = settings_change_stub.create!(:key => "/log/level", :value => "debug")
+      to_keep = settings_change_stub.create!(:key => "/log/level", :value => "debug")
       to_delete = settings_change_stub.create!(:key => "/log/collection/ping_depot", :value => "false")
 
       migrate
 
       expect(settings_change_stub.count).to eq(1)
-      expect(settings_change_stub.first).to eq(keep)
+      expect(settings_change_stub.first).to eq(to_keep)
+      expect { to_delete.reload }.to raise_error(ActiveRecord::RecordNotFound)
     end
   end
 end

spec/migrations/20251105160057_drop_miq_schedule_file_depot_records_spec.rb

@@ -0,0 +1,26 @@
+require_migration
+
+class DropMiqScheduleFileDepotRecords < ActiveRecord::Migration[7.2]
+  class FileDepot < ActiveRecord::Base
+    self.inheritance_column = :_type_disabled
+  end
+end
+
+describe DropMiqScheduleFileDepotRecords do
+  let(:file_depot_stub) { migration_stub(:FileDepot) }
+  let(:miq_schedule_stub) { migration_stub(:MiqSchedule) }
+
+  migration_context :up do
+    it "deletes schedules associated to file depots" do
+      file_depot = file_depot_stub.create!(:name => "my_file_depot")
+      to_delete = miq_schedule_stub.create!(:name => "my_file_depot schedule", :file_depot_id => file_depot.id)
+      to_keep = miq_schedule_stub.create!(:name => "other schedule", :file_depot_id => nil)
+
+      migrate
+
+      expect(miq_schedule_stub.count).to eq(1)
+      expect(miq_schedule_stub.first).to eq(to_keep)
+      expect { to_delete.reload }.to raise_error(ActiveRecord::RecordNotFound)
+    end
+  end
+end