Support rails 8.0

[jrafanie]

Followup to #23201

https://guides.rubyonrails.org/8_0_release_notes.html

Notable:

• propshaft replaces sprockets
• db:migrate loads from schema by default for fresh databases (may need the old behavior if undesirable)

7.2 EOL is August 9, 2026
8.0 EOL is November 7, 2026
8.1 EOL is October 10, 2027

https://rubyonrails.org/maintenance
https://endoflife.date/rails

TODO:

• [WIP] Rails-8 manageiq-ui-classic#9753 (actioncable and loosen depdendency)
• manageiq-schema
• manageiq-api-client and release
• manageiq-messaging and release
• manageiq-postgres_ha_admin and release
• manageiq-smartstate and release
• activerecord-virtual_attributes and release
• inventory_refresh and release
• activerecord-id_regions and release
• core (pull in above changes, support rails 8 new way to do schema migrations or use db:migrate:reset)

[Fryguy]

db:migrate loads from schema by default for fresh databases (may need the old behavior if undesirable)

I would actually love this. In the past we couldn't do it because we have Views and Triggers, which weren't dumped into the db/schema.rb, but I know NickLaMuro did a lot to normalize that into the db/schema.rb. Not sure if he finished though. Might be worth doing a schema diff and seeing what's left.

[jrafanie]

db:migrate loads from schema by default for fresh databases (may need the old behavior if undesirable)

I would actually love this. In the past we couldn't do it because we have Views and Triggers, which weren't dumped into the db/schema.rb, but I know NickLaMuro did a lot to normalize that into the db/schema.rb. Not sure if he finished though. Might be worth doing a schema diff and seeing what's left.

Just for fun, I wanted to run the tests on the core repo and I used the new db:migrate:reset to reset my db and migrate up. It's similar to our evm:db:reset with one minor change. With the change below and the loosening of gem dependencies, it's 💚 on manageiq locally.

index 0e28971..9a158be 100644
--- a/db/migrate/20171030131403_collapsed_initial_migration.rb
+++ b/db/migrate/20171030131403_collapsed_initial_migration.rb
@@ -10,8 +10,11 @@ class CollapsedInitialMigration < ActiveRecord::Migration[5.0]
     # If a user has not upgraded to at least ManageIQ Gaprindashvili, then they
     #   will have entries in their schema_migrations table, but will not have
     #   migration 20171030131403. This migration will run and disallow that case.
+
+    # in rails 8, db:migrate:reset was added which looks a lot like our evm:db:reset
+    # RAILS_ENV=test bin/rails db:migrate:reset.  For some reason, there's a single row in schema_migrations with a value of 0
     if table_exists?("schema_migrations") &&
-       connection.select_value("SELECT COUNT(*) FROM schema_migrations") != 0
+       connection.select_value("SELECT COUNT(*) FROM schema_migrations").to_i > 1
       raise "This database cannot be migrated. You must first upgrade this " \
             "database using the ManageIQ Gaprindashvili release."
     end

With this gemfile change:

index e72f5de3c8..0b0f2a9038 100644
--- a/Gemfile
+++ b/Gemfile
@@ -67,8 +67,8 @@ gem "psych",                            ">=3.1",             :require => false #
 gem "query_relation",                   "~>0.2.0",           :require => false
 gem "rack",                             ">=2.2.20",          :require => false # https://github.com/advisories/GHSA-6xw4-3v39-52mm https://github.com/advisories/GHSA-6xw4-3v39-52mm https://github.com/advisories/GHSA-6xw4-3v39-52mm https://github.com/advisories/GHSA-6xw4-3v39-52mm https://github.com/advisories/GHSA-6xw4-3v39-52mm https://github.com/advisories/GHSA-6xw4-3v39-52mm
 gem "rack-attack",                      "~>6.8.0",           :require => false
-gem "rails",                            "~>7.2.3"
-gem "rails-i18n",                       "~>7.x"
+gem "rails",                            "~>8.0.4"
+gem "rails-i18n",                       "~>8.0.2"
 gem "rake",                             ">=12.3.3",          :require => false
 gem "rest-client",                      "~>2.1.0",           :require => false
 gem "ruby_parser",                                           :require => false # Required for i18n string extraction, and DescentdantLoader (via prism)

And these gem overrides that would need to be PR'd, merged, released, and bumped in manageiq:

override_gem 'manageiq-ui-classic', :path => "/Users/joerafaniello/Code/manageiq-ui-classic"
override_gem "manageiq-schema", :path => "/Users/joerafaniello/Code/manageiq-schema"
override_gem "manageiq-api-client", :path => "/Users/joerafaniello/Code/manageiq-api-client"
override_gem "manageiq-messaging", :path => "/Users/joerafaniello/Code/manageiq-messaging"
override_gem 'manageiq-postgres_ha_admin', :path => "/Users/joerafaniello/Code/manageiq-postgres_ha_admin"
override_gem "manageiq-smartstate", :path => "/Users/joerafaniello/Code/manageiq-smartstate"
override_gem "activerecord-virtual_attributes", :path => "/Users/joerafaniello/Code/activerecord-virtual_attributes"
override_gem "inventory_refresh", :path => "/Users/joerafaniello/Code/inventory_refresh"
gem "activerecord-id_regions", :path => "/Users/joerafaniello/Code/activerecord-id_regions"

[Fryguy]

or some reason, there's a single row in schema_migrations with a value of 0

Is this also in a vanilla rails empty db app?

EDIT: I tried a vanilla 8.0.4 rails locally and don't see the row in the database.

[jrafanie]

EDIT:
The issue below is resolved by updating the actioncable package in package.json in WIP PR: ManageIQ/manageiq-ui-classic#9753

Ok, looks like there's a possible actioncable thing to fix with rails 8, after login: