Unconditionally enable reduce reduction #33603
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggevay
approved these changes
Sep 18, 2025
Contributor
ggevay
left a comment
ggevay
left a comment
There was a problem hiding this comment.
LGTM (but maybe wait for @frankmcsherry's approval)
frankmcsherry
approved these changes
Sep 26, 2025
Contributor
frankmcsherry
left a comment
frankmcsherry
left a comment
There was a problem hiding this comment.
We discussed and it seems good, but we also discussed a slightly slower roll-out where we put a soft assert here first, so that we can watch for a release or two and see if the code is as dead as we believe it to be, for production use cases. As @antiguru mentions, we are unable to be certain of the unreachability through types, in that if we can still be presented with a heterogeneous reduce if for any reason the transform fails to remove it.
antiguru
force-pushed
the
remove_collation
branch
from
40fe757 to
72ed4cb
Compare
Removes the feature flag and the reduce collation implementation that is now unreachable. Signed-off-by: Moritz Hoffmann <[email protected]>
antiguru
force-pushed
the
remove_collation
branch
from
72ed4cb to
9e38dbf
Compare
Member
Author
|
Added the warning in #33726. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the feature flag and the reduce collation implementation that is now unreachable.