Skip to content

Extract PermissionLogController initialization from MetamaskController #29557

@Cal-L

Description

@Cal-L

Problem

It is impossible for the PermissionLogController initialization code in extension to be codeowned by other teams, as MetamaskController is shared among multiple teams.

To draw more sensible boundaries and increase developer velocity, we need to extract the initialization code following the established modular initialization initiative.

Acceptance Criteria

  • A directory in app/scripts/controller-init exists to hold controller initialization code shared between multiple teams (shared is a fine name).
  • The PermissionLogController initialization code is extracted to app/scripts/controller-init/shared/permission-log-controller-init.ts. This file exports a function, PermissionLogControllerInit, and returns an object with controller and api properties. (See transaction-controller-init and delegation-controller-init for examples.)
  • PermissionLogControllerInit is added to controllerInitFunctions.
  • PermissionLog controller functionality works the same as before.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions