-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Closed
Labels
INVALID-ISSUE-TEMPLATEIssue's body doesn't match any issue template.Issue's body doesn't match any issue template.release-13.5.0Issue or pull request that will be included in release 13.5.0Issue or pull request that will be included in release 13.5.0team-wallet-api-platform-deprecatedDEPRECATED: please use "team-wallet-integrations" insteadDEPRECATED: please use "team-wallet-integrations" insteadteam-wallet-framework
Description
Problem
It is impossible for the PermissionLogController initialization code in extension to be codeowned by other teams, as MetamaskController is shared among multiple teams.
To draw more sensible boundaries and increase developer velocity, we need to extract the initialization code following the established modular initialization initiative.
Acceptance Criteria
- A directory in
app/scripts/controller-initexists to hold controller initialization code shared between multiple teams (sharedis a fine name). - The PermissionLogController initialization code is extracted to
app/scripts/controller-init/shared/permission-log-controller-init.ts. This file exports a function,PermissionLogControllerInit, and returns an object withcontrollerandapiproperties. (Seetransaction-controller-initanddelegation-controller-initfor examples.) PermissionLogControllerInitis added tocontrollerInitFunctions.- PermissionLog controller functionality works the same as before.
Metadata
Metadata
Assignees
Labels
INVALID-ISSUE-TEMPLATEIssue's body doesn't match any issue template.Issue's body doesn't match any issue template.release-13.5.0Issue or pull request that will be included in release 13.5.0Issue or pull request that will be included in release 13.5.0team-wallet-api-platform-deprecatedDEPRECATED: please use "team-wallet-integrations" insteadDEPRECATED: please use "team-wallet-integrations" insteadteam-wallet-framework