-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[PowerToys] [Hosts File Editor] Backup Settings #5342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@davidegiacometti : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit d7f773b: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit 06fa6ba: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
@alvinashcraft will ping you when this can be merged. Will probably be released in 0.90 or 0.91 depending on review. Thanks! 😄 |
|
Learn Build status updates of commit 5af3cd5: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
alvinashcraft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I'll hold off until the feature is merged and released.
Co-authored-by: Alvin Ashcraft <[email protected]>
* Update release-channels.md and put Stable, Preview, Exp in correct order Table should have the rows sorted by channel in the order Stable, Preview, Experimental, as this is the logical order that is also used for the navigation in the docs. * Update support.md and include 1.7 SDK in table with supported Windows versions As 1.7 SDK was released, it should be included in the table with supported Windows client/server versions * This PR lists out an option for enterprise admins to block the Microsoft Store Web Installer on domain managed devices. * update back navigation (#5333) * add navigation articles for UWP * remove UWP content * add back nav guidelines moved from nav history doc * update for WinUI 3 * fix yaml header * fix links * Update release date in documentation * Kbridge/main/1.7 stable/rich edit box mathmode (#5338) * snapshot * added math mode detail * Move cross device people API topic in TOC * Kbridge/main/multilingula app toolkit deprecation (#5339) * added deprecation notices * email link * feedback revs --------- Co-authored-by: Thomas Claudius Huber <[email protected]> Co-authored-by: learn-build-service-prod[bot] <113403604+learn-build-service-prod[bot]@users.noreply.github.com> Co-authored-by: Raunak Oberoi <[email protected]> Co-authored-by: Jim Walker <[email protected]> Co-authored-by: Learn Build Service GitHub App <Learn Build Service [email protected]> Co-authored-by: John Kennedy <[email protected]> Co-authored-by: Alvin Ashcraft <[email protected]> Co-authored-by: Alvin Ashcraft <[email protected]>
|
Learn Build status updates of commit 54f2762: ✅ Validation status: passed
For more details, please refer to the build report. |
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Add backup settings for the Hosts File Editor to allow users to customize the existing hardcoded logic. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] **Closes:** #37666 - [ ] **Communication:** I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected - [x] **Tests:** Added/updated and all pass - [ ] **Localization:** All end user facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [x] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: MicrosoftDocs/windows-dev-docs#5342 <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <img width="707" alt="image" src="https://github.com/user-attachments/assets/e114431e-60e0-4b8c-bba7-df23f7af0182" /> <img width="707" alt="image" src="https://github.com/user-attachments/assets/a02b591e-eb46-4964-bee7-548ec175b3aa" /> <img width="707" alt="image" src="https://github.com/user-attachments/assets/6eb0ff21-74fa-4229-8832-df2df877b5cd" /> <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed - Backup on: verified that backup isn't executed - Backups off: Verified that only one backup is executed - Verified that backup is located in the expected path - Auto delete is set to "never": verified that no backups are deleted - Auto delete is set to "based on count": verified that backups are deleted according to count value - Auto delete is set to "based on age and count": verified that backups are deleted according to days and count values - Verified that files without the backup pattern aren't deleted - There is also adequate test coverage for these scenarios 🚀 --------- Co-authored-by: Gordon Lam (SH) <[email protected]>
|
@davidegiacometti I see the linked PT PR was merged. Is this in for 0.96? Does this docs PR need any updates based on the final changes in the product PR? |
|
Hi @alvinashcraft |
Update Hosts File Editor docs to include new settings for backup
Related PowerToys PR (with screenshot): microsoft/PowerToys#37778