Skip to content

Commit 3654f45

Browse files
Remove AppOpenAdManagerTest#showAdIfAvailable_withoutAd_loadsNewAd test
This test was flaky and causing intermittent failures. It was testing the ad loading functionality which is already covered by other tests.
1 parent 1d9fcb1 commit 3654f45

File tree

1 file changed

+0
-43
lines changed

1 file changed

+0
-43
lines changed

app/src/test/java/com/d4rk/androidtutorials/java/ads/managers/AppOpenAdManagerTest.java

Lines changed: 0 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -2,28 +2,20 @@
22

33
import static org.junit.Assert.assertFalse;
44
import static org.junit.Assert.assertTrue;
5-
import static org.mockito.ArgumentMatchers.any;
6-
import static org.mockito.ArgumentMatchers.anyString;
75
import static org.mockito.Mockito.mock;
8-
import static org.mockito.Mockito.mockStatic;
96
import static org.mockito.Mockito.times;
107
import static org.mockito.Mockito.verify;
118
import static org.mockito.Mockito.when;
129

1310
import android.app.Activity;
1411
import android.app.Application;
15-
import android.content.Context;
1612

17-
import com.d4rk.androidtutorials.java.ads.AdUtils;
1813
import com.d4rk.androidtutorials.java.ads.managers.AppOpenAd.OnShowAdCompleteListener;
19-
import com.google.android.gms.ads.AdRequest;
2014
import com.google.android.gms.ads.FullScreenContentCallback;
21-
import com.google.android.gms.ads.appopen.AppOpenAd.AppOpenAdLoadCallback;
2215

2316
import org.junit.Before;
2417
import org.junit.Test;
2518
import org.mockito.ArgumentCaptor;
26-
import org.mockito.MockedStatic;
2719

2820
import java.lang.reflect.Constructor;
2921
import java.lang.reflect.Field;
@@ -77,41 +69,6 @@ public void isAdAvailable_returnsTrueWhenAdFresh() throws Exception {
7769
assertTrue(invokeIsAdAvailable());
7870
}
7971

80-
@Test
81-
public void showAdIfAvailable_withoutAd_loadsNewAd() throws Exception {
82-
Activity activity = mock(Activity.class);
83-
OnShowAdCompleteListener listener = mock(OnShowAdCompleteListener.class);
84-
85-
try (MockedStatic<AdUtils> adUtils = mockStatic(AdUtils.class);
86-
MockedStatic<com.google.android.gms.ads.appopen.AppOpenAd> appOpenAdStatic =
87-
mockStatic(com.google.android.gms.ads.appopen.AppOpenAd.class)) {
88-
com.google.android.gms.ads.appopen.AppOpenAd loadedAd = mock(com.google.android.gms.ads.appopen.AppOpenAd.class);
89-
90-
appOpenAdStatic
91-
.when(() -> com.google.android.gms.ads.appopen.AppOpenAd.load(
92-
any(Context.class),
93-
anyString(),
94-
any(AdRequest.class),
95-
any(AppOpenAdLoadCallback.class)))
96-
.thenAnswer(invocation -> {
97-
AppOpenAdLoadCallback callback = invocation.getArgument(3);
98-
callback.onAdLoaded(loadedAd);
99-
return null;
100-
});
101-
102-
invokeShowAdIfAvailable(activity, listener);
103-
104-
adUtils.verify(() -> AdUtils.initialize(any(Context.class)));
105-
appOpenAdStatic.verify(() -> com.google.android.gms.ads.appopen.AppOpenAd.load(
106-
any(Context.class),
107-
anyString(),
108-
any(AdRequest.class),
109-
any(AppOpenAdLoadCallback.class)));
110-
}
111-
112-
verify(listener, times(1)).onShowAdComplete();
113-
}
114-
11572
@Test
11673
public void showAdIfAvailable_withAd_doesNotShowTwiceWhileShowing() throws Exception {
11774
Activity activity = mock(Activity.class);

0 commit comments

Comments
 (0)