Skip to content

Conversation

@jamierocks
Copy link
Contributor

This is a port of my pr to FML back in January MinecraftForge/FML#592

This is a port of my pr to FML back in January MinecraftForge/FML#592
@liach
Copy link
Contributor

liach commented Nov 17, 2015

No. By default the name is just mod id.

@jamierocks
Copy link
Contributor Author

IMO I think that Forge should force modders to provide a human-readable name for their mods.

@liach
Copy link
Contributor

liach commented Nov 17, 2015

Human-readable mod ids are enough. If you still insist to force name for mods, please fix all debug mods here.

@matthewprenger
Copy link
Contributor

I support this, but it will have to be targeted at @ 1.8.8 because backwards compatibility.

@jamierocks
Copy link
Contributor Author

I will update this pr, tommorow (don't have access to pc until then)

@LexManos
Copy link
Member

Why? Also this doesn't force them to do anything 'human readable'.
ModID should be sufficient, why is it not?

@cpw
Copy link
Contributor

cpw commented Nov 18, 2015

Nope. Adding a default here just means people won't populate it.

@cpw cpw closed this Nov 18, 2015
@matthewprenger
Copy link
Contributor

Uhh what? He removed the default, which would force people _to_ populate it...

@cpw
Copy link
Contributor

cpw commented Nov 18, 2015

Yes, got that backwards, making it even worse. It breaks compatibility for trivia.

@jamierocks
Copy link
Contributor Author

When has Forge ever cared about backwards compatibility?

@williewillus
Copy link
Contributor

Uh, always?

@cpw
Copy link
Contributor

cpw commented Nov 18, 2015

When possible yes I do care. This change breaks compatibility for zero net benefit. If there was a good cause to do it I would. Names have had sensible defaults in code since I wrote @mod 3 years ago. There is zero reason to change that that I can see.

@liach
Copy link
Contributor

liach commented Nov 18, 2015

@jamierocks If you do not care about backwards compatibility, mods that use forge will hurt a lot. In the other way, a mod that is compiled against 10.13.0 could never work on 10.13.4 if you do not care about it. In my opinion, your change would be big enough to bump version from 11 to 12.

@DanielleHuisman
Copy link

Why do you even need this patch?
It chances literally nothing and would certainly not be enough for a major version bump.

@Spartan322
Copy link

This breaks a lot of mods and provides absolutely nothing in return, and mod names aren't guaranteed to be human-readable. (and does not qualify as a legitimate reason for compat breaks anyway)

@jamierocks jamierocks deleted the patch-1 branch November 18, 2015 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants