-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Force mods, to require a name #2194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a port of my pr to FML back in January MinecraftForge/FML#592
|
No. By default the name is just mod id. |
|
IMO I think that Forge should force modders to provide a human-readable name for their mods. |
|
Human-readable mod ids are enough. If you still insist to force name for mods, please fix all debug mods here. |
|
I support this, but it will have to be targeted at @ 1.8.8 because backwards compatibility. |
|
I will update this pr, tommorow (don't have access to pc until then) |
|
Why? Also this doesn't force them to do anything 'human readable'. |
|
Nope. Adding a default here just means people won't populate it. |
|
Uhh what? He removed the default, which would force people _to_ populate it... |
|
Yes, got that backwards, making it even worse. It breaks compatibility for trivia. |
|
When has Forge ever cared about backwards compatibility? |
|
Uh, always? |
|
When possible yes I do care. This change breaks compatibility for zero net benefit. If there was a good cause to do it I would. Names have had sensible defaults in code since I wrote @mod 3 years ago. There is zero reason to change that that I can see. |
|
@jamierocks If you do not care about backwards compatibility, mods that use forge will hurt a lot. In the other way, a mod that is compiled against 10.13.0 could never work on 10.13.4 if you do not care about it. In my opinion, your change would be big enough to bump version from 11 to 12. |
|
Why do you even need this patch? |
|
This breaks a lot of mods and provides absolutely nothing in return, and mod names aren't guaranteed to be human-readable. (and does not qualify as a legitimate reason for compat breaks anyway) |
This is a port of my pr to FML back in January MinecraftForge/FML#592