Sprint types fixed (#140)

* sprint types fixed

* small project types improvements

Author: MrRefactoring

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Jira.js changelog
 
+### 2.4.1
+
+- A lot of small improvements in types for agile and for project API
+
 ### 2.4.0
 
 - Some properties to some endpoints added :D

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "jira.js",
-  "version": "2.4.0",
+  "version": "2.4.1",
   "description": "jira.js is a powerful Node.JS/Browser module that allows you to interact with the Jira API very easily",
   "main": "out/index.js",
   "types": "out/index.d.ts",
@@ -29,9 +29,9 @@
     "lint:base": "eslint --ext .ts",
     "lint:fix": "npm run lint:tests -- --fix && npm run lint:src:agile -- --fix && npm run lint:src:clients -- --fix && npm run lint:src:services -- --fix && npm run lint:src:version2 -- --fix && npm run lint:src:version3 -- --fix && npm run lint:src:files -- --fix",
     "doc": "typedoc --name Jira.js --out docs ./src",
-    "test": "npm run test:unit && npm run test:system",
+    "test": "npm run test:unit && npm run test:e2e",
     "test:unit": "jest tests/unit",
-    "test:system": "jest tests/system --setupFiles=./tests/setup.ts --runInBand",
+    "test:e2e": "jest tests/integration --setupFiles=./tests/setup.ts --runInBand",
     "test:verbose": "npm run test -- --verbose",
     "test:coverage": "npm run test:unit:coverage && npm run test:system:coverage",
     "test:unit:coverage": "npm run test:unit -- --coverage",
@@ -44,23 +44,23 @@
   "devDependencies": {
     "@types/express": "^4.17.12",
     "@types/jest": "^26.0.23",
-    "@types/node": "^15.12.2",
+    "@types/node": "^15.12.5",
     "@types/oauth": "^0.9.1",
     "@types/sinon": "^10.0.2",
-    "@typescript-eslint/eslint-plugin": "^4.26.1",
-    "@typescript-eslint/parser": "^4.26.1",
+    "@typescript-eslint/eslint-plugin": "^4.28.1",
+    "@typescript-eslint/parser": "^4.28.1",
     "dotenv": "^10.0.0",
-    "eslint": "^7.28.0",
+    "eslint": "^7.29.0",
     "eslint-config-airbnb-typescript": "^12.3.1",
     "eslint-import-resolver-typescript": "^2.4.0",
     "eslint-plugin-import": "^2.23.4",
     "jest": "^26.6.3",
-    "prettier": "^2.3.1",
+    "prettier": "^2.3.2",
     "prettier-plugin-jsdoc": "^0.3.23",
     "sinon": "^11.1.1",
     "ts-jest": "^26.5.6",
-    "typedoc": "^0.20.36",
-    "typescript": "^4.3.2"
+    "typedoc": "^0.21.2",
+    "typescript": "^4.3.4"
   },
   "dependencies": {
     "atlassian-jwt": "^2.0.1",

package.json

@@ -13,7 +13,7 @@ export class Backlog {
    * be moved at once.
    */
   async moveIssuesToBacklog<T = void>(
-    parameters: Parameters.MoveIssuesToBacklog | undefined,
+    parameters: Parameters.MoveIssuesToBacklog,
     callback: Callback<T>
   ): Promise<void>;
   /**
@@ -22,9 +22,9 @@ export class Backlog {
    * This operation is equivalent to remove future and active sprints from a given set of issues. At most 50 issues may
    * be moved at once.
    */
-  async moveIssuesToBacklog<T = void>(parameters?: Parameters.MoveIssuesToBacklog, callback?: never): Promise<T>;
+  async moveIssuesToBacklog<T = void>(parameters: Parameters.MoveIssuesToBacklog, callback?: never): Promise<T>;
   async moveIssuesToBacklog<T = void>(
-    parameters?: Parameters.MoveIssuesToBacklog,
+    parameters: Parameters.MoveIssuesToBacklog,
     callback?: Callback<T>,
   ): Promise<void | T> {
     const config: RequestConfig = {

src/agile/backlog.ts

@@ -70,7 +70,7 @@ export class Board {
    *  </ul>
    */
   async createBoard<T = Models.CreateBoard>(
-    parameters: Parameters.CreateBoard | undefined,
+    parameters: Parameters.CreateBoard,
     callback: Callback<T>
   ): Promise<void>;
   /**
@@ -101,9 +101,9 @@ export class Board {
    *  </li>
    *  </ul>
    */
-  async createBoard<T = Models.CreateBoard>(parameters?: Parameters.CreateBoard, callback?: never): Promise<T>;
+  async createBoard<T = Models.CreateBoard>(parameters: Parameters.CreateBoard, callback?: never): Promise<T>;
   async createBoard<T = Models.CreateBoard>(
-    parameters?: Parameters.CreateBoard,
+    parameters: Parameters.CreateBoard,
     callback?: Callback<T>,
   ): Promise<void | T> {
     const config: RequestConfig = {
@@ -752,16 +752,16 @@ export class Board {
   }
 
   /** Returns all sprints from a board, for a given board ID. This only includes sprints that the user has permission to view. */
-  async getAllSprints<T = Paginated<Models.SprintBean[]>>(
+  async getAllSprints<T = Paginated<Models.Sprint>>(
     parameters: Parameters.GetAllSprints,
     callback: Callback<T>
   ): Promise<void>;
   /** Returns all sprints from a board, for a given board ID. This only includes sprints that the user has permission to view. */
-  async getAllSprints<T = Paginated<Models.SprintBean[]>>(
+  async getAllSprints<T = Paginated<Models.Sprint>>(
     parameters: Parameters.GetAllSprints,
     callback?: never
   ): Promise<T>;
-  async getAllSprints<T = Paginated<Models.SprintBean[]>>(
+  async getAllSprints<T = Paginated<Models.Sprint>>(
     parameters: Parameters.GetAllSprints,
     callback?: Callback<T>,
   ): Promise<void | T> {

src/agile/board.ts

@@ -1,5 +1,5 @@
 export interface CreateBoard {
-  id?: number;
+  id: number;
   self?: string;
   name?: string;
   type?: string;

src/agile/models/createBoard.ts

@@ -3,8 +3,8 @@ export interface GetAllBoards {
   startAt?: number;
   total?: number;
   isLast?: boolean;
-  values?: {
-    id?: number;
+  values: {
+    id: number;
     self?: string;
     name?: string;
     type?: string;

src/agile/models/getAllBoards.ts

@@ -66,7 +66,7 @@ export * from './reportBean';
 export * from './reportsResponseBean';
 export * from './searchResultsBean';
 export * from './simpleLinkBean';
-export * from './sprintBean';
+export * from './sprint';
 export * from './sprintCreateBean';
 export * from './sprintSwapBean';
 export * from './statusCategoryJsonBean';

src/agile/models/index.ts

@@ -4,13 +4,13 @@ export interface SearchResultsBean {
   /** Expand options that include additional search result details in the response. */
   expand?: string;
   /** The index of the first item returned on the page. */
-  startAt?: number;
+  startAt: number;
   /** The maximum number of results that could be on the page. */
-  maxResults?: number;
+  maxResults: number;
   /** The number of results on the page. */
-  total?: number;
+  total: number;
   /** The list of issues found by the search. */
-  issues?: IssueBean[];
+  issues: IssueBean[];
   /** Any warnings related to the JQL query. */
   warningMessages?: string[];
   /** The ID and name of each field in the search results. */

src/agile/models/searchResultsBean.ts

@@ -0,0 +1,21 @@
+export type SprintBean = Sprint;
+
+export interface Sprint {
+  id: number;
+  self?: string;
+  state: string | Sprint.State;
+  name: string;
+  startDate?: string;
+  endDate?: string;
+  completeDate?: string;
+  originBoardId?: number;
+  goal?: string;
+}
+
+export namespace Sprint {
+  export enum State {
+    Future = 'future',
+    Active = 'active',
+    Closed = 'closed',
+  }
+}