Validation of TRAPI 1.6.0 does not seem to work for PathFinder results

[edeutsch]

When validating TRAPI 1.6.0 PathFinder results, the validator appears to generate a schema validation error when it should not. Example repro:

https://arax.ncats.io/devED/?r=a3da1e04-4c7a-4db2-ac20-57f00e75807d

this UUID generates a schema-level error.

{
  "critical": {
    "critical.trapi.validation": {
      "v1.6.0-beta": [
        {
          "component": "QueryGraph",
          "json_path": "$",
          "reason": "'edges' is a required property"
        }
      ]
    }
  },

Message has a "query_graph" property:

        query_graph:
          description: >-
            QueryGraph object that contains a serialization of a query in the
            form of a graph
          oneOf:
            - $ref: '#/components/schemas/QueryGraph'
            - $ref: '#/components/schemas/PathfinderQueryGraph'
          nullable: true

that be either a traditional QueryGraph OR a PathfinderQueryGraph

While QueryGraph does require "edges", PathfinderQueryGraph does not have edges and requires "paths"
https://github.com/NCATSTranslator/ReasonerAPI/blob/8fed075cc5b0cec9e88a202e9fc16a14e34f158f/TranslatorReasonerAPI.yaml#L920

So the claim is that the above listed UUID is schema-valid TRAPI and should not be failing validation.
Why does it fail validation?
Can it be fixed?

[edeutsch]

Note that this is a bit of a tricky part of the schema with a BaseQueryGraph that forms a base class that both QueryGraph and PathfinderQueryGraph inherit from, and only either QueryGraph or PathfinderQueryGraph should be instantiated, but it is a bit challenging to know which it will be.

The JSON itself does not state which of the two classes it is. One needs to peer inside the object, and if it has "edges" then it is a QueryGraph. If it has "paths" then it should be PathfinderQueryGraph.

I would think that a standard JSON schema validator should be able to handle this with no problems.

[edeutsch]

(note also that in the TRAPI payload at the above UUID, the "schema_version" property is set to "1.5.0", but this is a bug that has subsequently been fixed. It should be 1.6.0 and validation should be at 1.6.0.)

[RichardBruskiewich]

Ok @edeutsch I'll take a look in awhile

[edeutsch]

Hi @RichardBruskiewich would it be feasible to create a release for this fix?