Fix linter

Signed-off-by: Sheng Lin <[email protected]>

Author: shengnuo

internal/controller/nemo_datastore_controller_test.go

@@ -93,7 +93,7 @@ var _ = Describe("NemoDatastore Controller", func() {
 		Expect(networkingv1.AddToScheme(scheme)).To(Succeed())
 		Expect(monitoringv1.AddToScheme(scheme)).To(Succeed())
 		Expect(appsv1.AddToScheme(scheme)).To(Succeed())
-		Expect(gatewayv1.AddToScheme(scheme)).To(Succeed())
+		Expect(gatewayv1.Install(scheme)).To(Succeed())
 
 		manifestsDir, err := filepath.Abs("../../manifests")
 		Expect(err).ToNot(HaveOccurred())

internal/controller/nemo_evaluator_controller_test.go

@@ -69,7 +69,7 @@ var _ = Describe("NemoEvaluator Controller", func() {
 		Expect(corev1.AddToScheme(scheme)).To(Succeed())
 		Expect(monitoringv1.AddToScheme(scheme)).To(Succeed())
 		Expect(batchv1.AddToScheme(scheme)).To(Succeed())
-		Expect(gatewayv1.AddToScheme(scheme)).To(Succeed())
+		Expect(gatewayv1.Install(scheme)).To(Succeed())
 
 		client = fake.NewClientBuilder().WithScheme(scheme).
 			WithStatusSubresource(&appsv1alpha1.NemoEvaluator{}).

internal/controller/nemocustomizer_controller_test.go

@@ -86,7 +86,7 @@ var _ = Describe("NemoCustomizer Controller", func() {
 		Expect(corev1.AddToScheme(scheme)).To(Succeed())
 		Expect(monitoringv1.AddToScheme(scheme)).To(Succeed())
 		Expect(batchv1.AddToScheme(scheme)).To(Succeed())
-		Expect(gatewayv1.AddToScheme(scheme)).To(Succeed())
+		Expect(gatewayv1.Install(scheme)).To(Succeed())
 
 		client = fake.NewClientBuilder().WithScheme(scheme).
 			WithStatusSubresource(&appsv1alpha1.NemoCustomizer{}).

internal/controller/nimservice_controller_test.go

@@ -55,7 +55,7 @@ var _ = Describe("NIMService Controller", func() {
 		Expect(batchv1.AddToScheme(scheme)).To(Succeed())
 		Expect(corev1.AddToScheme(scheme)).To(Succeed())
 		Expect(resourcev1beta2.AddToScheme(scheme)).To(Succeed())
-		Expect(gatewayv1.AddToScheme(scheme)).To(Succeed())
+		Expect(gatewayv1.Install(scheme)).To(Succeed())
 
 		testClient = fake.NewClientBuilder().WithScheme(scheme).
 			WithStatusSubresource(&appsv1alpha1.NIMService{}).

internal/controller/platform/kserve/nimservice_test.go

@@ -148,7 +148,7 @@ var _ = Describe("NIMServiceReconciler for a KServe platform", func() {
 		Expect(corev1.AddToScheme(scheme)).To(Succeed())
 		Expect(monitoringv1.AddToScheme(scheme)).To(Succeed())
 		Expect(kservev1beta1.AddToScheme(scheme)).To(Succeed())
-		Expect(gatewayv1.AddToScheme(scheme)).To(Succeed())
+		Expect(gatewayv1.Install(scheme)).To(Succeed())
 
 		client = fake.NewClientBuilder().WithScheme(scheme).
 			WithStatusSubresource(&appsv1alpha1.NIMService{}).

internal/controller/platform/standalone/nimservice_test.go

@@ -148,7 +148,7 @@ var _ = Describe("NIMServiceReconciler for a standalone platform", func() {
 		Expect(monitoringv1.AddToScheme(scheme)).To(Succeed())
 		Expect(lwsv1.AddToScheme(scheme)).To(Succeed())
 		Expect(resourcev1beta2.AddToScheme(scheme)).To(Succeed())
-		Expect(gatewayv1.AddToScheme(scheme)).To(Succeed())
+		Expect(gatewayv1.Install(scheme)).To(Succeed())
 
 		client = fake.NewClientBuilder().WithScheme(scheme).
 			WithStatusSubresource(&appsv1alpha1.NIMService{}).

internal/webhook/apps/v1alpha1/nimservice_webhook_validation_helper.go

@@ -103,13 +103,17 @@ func validateNIMServiceSpec(spec *appsv1alpha1.NIMServiceSpec, fldPath *field.Pa
 	warningList = append(warningList, w...)
 	errList = append(errList, err...)
 
+	w, err = validateExposeConfiguration(&spec.Expose, fldPath.Child("expose"))
+	warningList = append(warningList, w...)
+	errList = append(errList, err...)
+
 	return warningList, errList
 }
 
 func validateExposeConfiguration(expose *appsv1alpha1.Expose, fldPath *field.Path) (admission.Warnings, field.ErrorList) {
 	warningList := admission.Warnings{}
 	errList := field.ErrorList{}
-	if expose.Ingress.Enabled != nil && *expose.Ingress.Enabled {
+	if expose.Ingress.Enabled != nil && *expose.Ingress.Enabled { //nolint:staticcheck
 		warningList = append(warningList, ".spec.expose.ingress is deprecated, use .spec.router instead.")
 	}
 	return warningList, errList