Add target attribute

exdal · exdal · commit 8ea777c133fb · 2025-04-18T12:39:31.000+03:00
diff --git a/include/NZSL/Ast/Compare.inl b/include/NZSL/Ast/Compare.inl
@@ -834,6 +834,12 @@ namespace nzsl::Ast
 
 	bool Compare(const ScopedStatement& lhs, const ScopedStatement& rhs, const ComparisonParams& params)
 	{
+		if (!Compare(lhs.targetType, rhs.targetType, params))
+			return false;
+
+		if (!Compare(lhs.targetVersion, rhs.targetVersion, params))
+			return false;
+
 		if (!Compare(lhs.statement, rhs.statement, params))
 			return false;
 
diff --git a/include/NZSL/Ast/Enums.hpp b/include/NZSL/Ast/Enums.hpp
@@ -47,6 +47,7 @@ namespace nzsl::Ast
 		Tag                = 16, //< Tag (external block and external var only) - has argument string
 		Unroll             = 11, //< Unroll (for/for each only) - has argument mode
 		Workgroup          = 18, //< Work group size (function only) - has arguments X, Y, Z
+		Target             = 20, //< 
 	};
 
 	enum class BinaryType
@@ -268,6 +269,13 @@ namespace nzsl::Ast
 		Minus      = 1, //< -v
 		Plus       = 2, //< +v
 	};
+
+	enum class TargetType
+	{
+		GLSL = 0,
+		GLES = 1,
+		SPIRV = 3,
+	};
 }
 
 #endif // NZSL_AST_ENUMS_HPP
diff --git a/include/NZSL/Ast/Nodes.hpp b/include/NZSL/Ast/Nodes.hpp
@@ -526,6 +526,8 @@ namespace nzsl::Ast
 		NodeType GetType() const override;
 		void Visit(StatementVisitor& visitor) override;
 
+		ExpressionValue<TargetType> targetType;
+		ExpressionValue<std::uint32_t> targetVersion;
 		StatementPtr statement;
 	};
 
diff --git a/include/NZSL/Lang/ErrorList.hpp b/include/NZSL/Lang/ErrorList.hpp
@@ -39,6 +39,7 @@ NZSL_SHADERLANG_PARSER_ERROR(AttributeInvalidParameter, "invalid parameter {} fo
 NZSL_SHADERLANG_PARSER_ERROR(AttributeMultipleUnique, "attribute {} can only be present once", Ast::AttributeType)
 NZSL_SHADERLANG_PARSER_ERROR(AttributeParameterIdentifier, "attribute {} parameter can only be an identifier", Ast::AttributeType)
 NZSL_SHADERLANG_PARSER_ERROR(AttributeUnexpectedParameterCount, "attribute {} expects {} arguments, got {}", Ast::AttributeType, std::size_t, std::size_t)
+NZSL_SHADERLANG_PARSER_ERROR(AttributeInvalidTargetVersion, "invalid target version {} for target {}", std::int32_t, std::string)
 NZSL_SHADERLANG_PARSER_ERROR(ExpectedToken, "expected token {}, got {}", TokenType, TokenType)
 NZSL_SHADERLANG_PARSER_ERROR(DuplicateIdentifier, "duplicate identifier")
 NZSL_SHADERLANG_PARSER_ERROR(DuplicateModule, "duplicate module")
diff --git a/include/NZSL/LangWriter.hpp b/include/NZSL/LangWriter.hpp
@@ -58,6 +58,7 @@ namespace nzsl
 			struct TagAttribute;
 			struct UnrollAttribute;
 			struct WorkgroupAttribute;
+			struct TargetAttribute;
 
 			void Append(const Ast::AliasType& type);
 			void Append(const Ast::ArrayType& type);
@@ -104,6 +105,7 @@ namespace nzsl
 			void AppendAttribute(TagAttribute attribute);
 			void AppendAttribute(UnrollAttribute attribute);
 			void AppendAttribute(WorkgroupAttribute attribute);
+			void AppendAttribute(TargetAttribute attribute);
 			void AppendComment(std::string_view section);
 			void AppendCommentSection(std::string_view section);
 			void AppendHeader();
diff --git a/include/NZSL/Parser.hpp b/include/NZSL/Parser.hpp
@@ -31,6 +31,7 @@ namespace nzsl
 			static std::string_view ToString(Ast::LoopUnroll loopUnroll);
 			static std::string_view ToString(Ast::MemoryLayout memoryLayout);
 			static std::string_view ToString(Ast::ModuleFeature moduleFeature);
+			static std::string_view ToString(Ast::TargetType targetType);
 			static std::string_view ToString(ShaderStageType shaderStage);
 
 		private:
@@ -74,7 +75,7 @@ namespace nzsl
 			Ast::StatementPtr ParseReturnStatement();
 			Ast::StatementPtr ParseRootStatement(std::vector<Attribute> attributes = {});
 			Ast::StatementPtr ParseSingleStatement();
-			Ast::StatementPtr ParseStatement();
+			Ast::StatementPtr ParseStatement(std::vector<Attribute> attributes = {});
 			std::vector<Ast::StatementPtr> ParseStatementList(SourceLocation* sourceLocation);
 			Ast::StatementPtr ParseStructDeclaration(std::vector<Attribute> attributes = {});
 			Ast::StatementPtr ParseVariableDeclaration();
diff --git a/src/NZSL/Ast/AstSerializer.cpp b/src/NZSL/Ast/AstSerializer.cpp
@@ -504,6 +504,8 @@ namespace nzsl::Ast
 
 	void SerializerBase::Serialize(ScopedStatement& node)
 	{
+		ExprValue(node.targetType);
+		ExprValue(node.targetVersion);
 		Node(node.statement);
 	}
 
diff --git a/src/NZSL/Ast/Cloner.cpp b/src/NZSL/Ast/Cloner.cpp
@@ -332,6 +332,8 @@ namespace nzsl::Ast
 	StatementPtr Cloner::Clone(ScopedStatement& node)
 	{
 		auto clone = std::make_unique<ScopedStatement>();
+		clone->targetType = Clone(node.targetType);
+		clone->targetVersion = Clone(node.targetVersion);
 		clone->statement = CloneStatement(node.statement);
 
 		clone->sourceLocation = node.sourceLocation;
diff --git a/src/NZSL/GlslWriter.cpp b/src/NZSL/GlslWriter.cpp
@@ -2703,6 +2703,20 @@ namespace nzsl
 
 	void GlslWriter::Visit(Ast::ScopedStatement& node)
 	{
+		if (node.targetType.IsResultingValue())
+		{
+			unsigned int glVersion = m_environment.glMajorVersion * 100 + m_environment.glMinorVersion * 10;
+			auto targetType = node.targetType.GetResultingValue();
+			std::uint32_t targetVersion = 0;
+			if (node.targetVersion.IsResultingValue())
+				targetVersion = node.targetVersion.GetResultingValue();
+
+			const auto isGLSL = !m_environment.glES && targetType == Ast::TargetType::GLSL;
+			const auto isGLES = m_environment.glES && targetType == Ast::TargetType::GLES;
+			if (!((isGLSL || isGLES) && targetVersion <= glVersion))
+				return;
+		}
+
 		EnterScope();
 		node.statement->Visit(*this);
 		LeaveScope(true);
diff --git a/src/NZSL/Lang/Errors.cpp b/src/NZSL/Lang/Errors.cpp
@@ -84,6 +84,19 @@ struct fmt::formatter<nzsl::TokenType> : formatter<string_view>
 	}
 };
 
+template<>
+struct fmt::formatter<nzsl::Ast::TargetType> : formatter<string_view>
+{
+	template<typename FormatContext>
+	auto format(const nzsl::Ast::TargetType& p, FormatContext& ctx) const -> decltype(ctx.out())
+	{
+		auto it = nzsl::LangData::s_targets.find(p);
+		assert(it != nzsl::LangData::s_targets.end());
+
+		return formatter<string_view>::format(it->second.identifier, ctx);
+	}
+};
+
 namespace nzsl
 {
 	std::string_view ToString(ErrorCategory errorCategory)
diff --git a/src/NZSL/Lang/LangData.hpp b/src/NZSL/Lang/LangData.hpp
@@ -43,7 +43,8 @@ namespace nzsl::LangData
 		{ Ast::AttributeType::Set,                { "set" } },
 		{ Ast::AttributeType::Tag,                { "tag" } },
 		{ Ast::AttributeType::Unroll,             { "unroll" } },
-		{ Ast::AttributeType::Workgroup,          { "workgroup" } }
+		{ Ast::AttributeType::Workgroup,          { "workgroup" } },
+		{ Ast::AttributeType::Target,             { "target" } }
 	});
 
 	struct BuiltinData
@@ -259,6 +260,17 @@ namespace nzsl::LangData
 		{ Ast::LoopUnroll::Hint,   { "hint" } },
 		{ Ast::LoopUnroll::Never,  { "never" } }
 	});
+
+	struct TargetData
+	{
+		std::string_view identifier;
+	};
+
+	constexpr auto s_targets = frozen::make_unordered_map<Ast::TargetType, TargetData>({
+		{ Ast::TargetType::GLSL, { "glsl" } },
+		{ Ast::TargetType::GLES, { "gles" } },
+		{ Ast::TargetType::SPIRV, { "spirv" } },
+	});
 }
 
 #endif // NZSL_LANG_LANGDATA_HPP
diff --git a/src/NZSL/LangWriter.cpp b/src/NZSL/LangWriter.cpp
@@ -173,6 +173,14 @@ namespace nzsl
 		bool HasValue() const { return workgroup.HasValue(); }
 	};
 
+	struct LangWriter::TargetAttribute
+	{
+		const Ast::ExpressionValue<Ast::TargetType>& target;
+		const Ast::ExpressionValue<std::uint32_t>& version;
+
+		bool HasValue() const { return target.HasValue(); }
+	};
+
 	struct LangWriter::State
 	{
 		struct Identifier
@@ -780,6 +788,32 @@ namespace nzsl
 		Append(")");
 	}
 
+	void LangWriter::AppendAttribute(TargetAttribute attribute)
+	{
+		if (!attribute.HasValue())
+			return;
+
+		Append("target(");
+
+		if (attribute.target.IsResultingValue())
+			Append(Parser::ToString(attribute.target.GetResultingValue()));
+		else
+			attribute.target.GetExpression()->Visit(*this);
+
+		if (attribute.version.HasValue())
+		{
+			if (attribute.version.IsResultingValue())
+			{
+				Append(", ");
+				Append(attribute.version.GetResultingValue());
+			}
+			else
+				attribute.version.GetExpression()->Visit(*this);
+		}
+
+		Append(")");
+	}
+
 	void LangWriter::AppendComment(std::string_view section)
 	{
 		std::size_t lineFeed = section.find('\n');
@@ -1690,6 +1724,9 @@ namespace nzsl
 
 	void LangWriter::Visit(Ast::ScopedStatement& node)
 	{
+		AppendAttributes(true,
+			TargetAttribute{ node.targetType, node.targetVersion });
+
 		EnterScope();
 		node.statement->Visit(*this);
 		LeaveScope();
diff --git a/src/NZSL/Parser.cpp b/src/NZSL/Parser.cpp
@@ -82,6 +82,7 @@ namespace nzsl
 		constexpr auto s_layoutMapping        = BuildIdentifierMapping(LangData::s_memoryLayouts);
 		constexpr auto s_moduleFeatureMapping = BuildIdentifierMapping(LangData::s_moduleFeatures);
 		constexpr auto s_unrollModeMapping    = BuildIdentifierMapping(LangData::s_unrollModes);
+		constexpr auto s_targetMapping        = BuildIdentifierMapping(LangData::s_targets);
 	}
 
 	Ast::ModulePtr Parser::Parse(const std::vector<Token>& tokens)
@@ -177,6 +178,14 @@ namespace nzsl
 		return it->second.identifier;
 	}
 
+	std::string_view Parser::ToString(Ast::TargetType targetType)
+	{
+		auto it = LangData::s_targets.find(targetType);
+		assert(it != LangData::s_targets.end());
+
+		return it->second.identifier;
+	}
+
 	std::string_view Parser::ToString(ShaderStageType shaderStage)
 	{
 		auto it = LangData::s_entryPoints.find(shaderStage);
@@ -1294,6 +1303,13 @@ namespace nzsl
 					attributes.clear();
 					break;
 
+				case TokenType::OpenCurlyBracket:
+					if (attributes.empty())
+						throw ParserUnexpectedTokenError{ token.location, token.type };
+
+					statement = ParseStatement(std::move(attributes));
+					attributes.clear();
+					break;
 				default:
 					throw ParserUnexpectedTokenError{ token.location, token.type };
 			}
@@ -1303,14 +1319,70 @@ namespace nzsl
 		return statement;
 	}
 
-	Ast::StatementPtr Parser::ParseStatement()
+	Ast::StatementPtr Parser::ParseStatement(std::vector<Attribute> attributes)
 	{
 		if (Peek().type == TokenType::OpenCurlyBracket)
 		{
 			auto multiStatement = ShaderBuilder::MultiStatement();
 			multiStatement->statements = ParseStatementList(&multiStatement->sourceLocation);
 
-			return ShaderBuilder::Scoped(std::move(multiStatement));
+			auto scopedStatement = ShaderBuilder::Scoped(std::move(multiStatement));
+			for (auto&& attribute : attributes)
+			{
+				switch (attribute.type)
+				{
+					case Ast::AttributeType::Target:
+					{
+						if (scopedStatement->targetType.HasValue())
+							throw ParserAttributeMultipleUniqueError{ attribute.sourceLocation, attribute.type };
+
+						if (attribute.args.empty())
+							throw ParserAttributeUnexpectedParameterCountError{ attribute.sourceLocation, attribute.type, 1, attribute.args.size() };
+
+						const auto& targetTypeArg = attribute.args[0];
+
+						if (attribute.args[0]->GetType() != Ast::NodeType::IdentifierExpression)
+							throw ParserAttributeParameterIdentifierError{ targetTypeArg->sourceLocation, attribute.type };
+
+						bool hasExplicitTargetVersion = attribute.args.size() == 2;
+
+						auto targetTypeStr = static_cast<Ast::IdentifierExpression&>(*targetTypeArg).identifier;
+						auto it = s_targetMapping.find(targetTypeStr);
+						if (it == s_targetMapping.end())
+							throw ParserAttributeInvalidParameterError{ targetTypeArg->sourceLocation, targetTypeStr, attribute.type };
+
+						scopedStatement->targetType = it->second;
+
+						if (hasExplicitTargetVersion)
+						{
+							const auto& targetVersionArg = attribute.args[1];
+
+							if (targetVersionArg->GetType() != Ast::NodeType::ConstantValueExpression)
+								throw ParserAttributeParameterIdentifierError{ targetVersionArg->sourceLocation, attribute.type };
+
+							auto targetVersionValue = static_cast<Ast::ConstantValueExpression&>(*targetVersionArg).value;
+							if (std::holds_alternative<std::int32_t>(targetVersionValue))
+							{
+								auto targetVersion = std::get<std::int32_t>(targetVersionValue);
+								if (targetVersion < 0)
+									throw ParserAttributeInvalidTargetVersionError{ targetVersionArg->sourceLocation, targetVersion, targetTypeStr };
+
+								scopedStatement->targetVersion = Nz::SafeCast<std::uint32_t>(targetVersion);
+							}
+							else if (std::holds_alternative<std::uint32_t>(targetVersionValue))
+								scopedStatement->targetVersion = std::get<std::uint32_t>(targetVersionValue);
+							else
+								throw ParserAttributeInvalidTargetVersionError{ targetVersionArg->sourceLocation, 0, targetTypeStr };
+						}
+
+						break;
+					}
+					default:
+						throw ParserUnexpectedAttributeError{ attribute.sourceLocation, attribute.type, "scoped statement" };
+				}
+			}
+
+			return scopedStatement;
 		}
 		else
 			return ParseSingleStatement();
diff --git a/src/NZSL/SpirV/SpirvAstVisitor.cpp b/src/NZSL/SpirV/SpirvAstVisitor.cpp
@@ -1031,6 +1031,19 @@ namespace nzsl
 
 	void SpirvAstVisitor::Visit(Ast::ScopedStatement& node)
 	{
+		if (node.targetType.IsResultingValue())
+		{
+			unsigned int spirvVersion = m_writer.m_environment.spvMajorVersion * 100 + m_writer.m_environment.spvMinorVersion * 10;
+			auto targetType = node.targetType.GetResultingValue();
+			std::uint32_t targetVersion = 0;
+			if (node.targetVersion.IsResultingValue())
+				targetVersion = node.targetVersion.GetResultingValue();
+
+			const auto isSPIRV = targetType == Ast::TargetType::SPIRV;
+			if (!(isSPIRV && targetVersion <= spirvVersion))
+				return;
+		}
+
 		node.statement->Visit(*this);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -504,6 +504,8 @@ namespace nzsl::Ast`
`504`	`504`
`505`	`505`	`void SerializerBase::Serialize(ScopedStatement& node)`
`506`	`506`	`{`
	`507`	`+ ExprValue(node.targetType);`
	`508`	`+ ExprValue(node.targetVersion);`
`507`	`509`	`Node(node.statement);`
`508`	`510`	`}`
`509`	`511`
Original file line number	Diff line number	Diff line change
`@@ -332,6 +332,8 @@ namespace nzsl::Ast`
`332`	`332`	`StatementPtr Cloner::Clone(ScopedStatement& node)`
`333`	`333`	`{`
`334`	`334`	`auto clone = std::make_unique<ScopedStatement>();`
	`335`	`+ clone->targetType = Clone(node.targetType);`
	`336`	`+ clone->targetVersion = Clone(node.targetVersion);`
`335`	`337`	`clone->statement = CloneStatement(node.statement);`
`336`	`338`
`337`	`339`	`clone->sourceLocation = node.sourceLocation;`