override serialization instead of model_dump and increase test coverage to resolve PromptData serialization bug

Author: NeonDaniel

neon_data_models/models/api/klat/socketio.py

@@ -27,7 +27,7 @@
 from typing import Optional, Dict, List, Literal, Union
 
 from neon_data_models.models.api.llm import LLMPersona
-from pydantic import Field, model_validator
+from pydantic import Field, model_validator, model_serializer
 
 from neon_data_models.enum import CcaiPromptStates
 from neon_data_models.models.base import BaseModel
@@ -133,9 +133,14 @@ class _PromptData(BaseModel):
             default=[],
             description="List of subminds that participated in this prompt")
 
-        def model_dump(self, *args, **kwargs):
-            kwargs.setdefault('by_alias', True)
-            return BaseModel.model_dump(self, *args, **kwargs)
+        @model_serializer
+        def alias_serialize(self):
+            return {"_id": self.id,
+                    "is_completed": self.is_completed,
+                    "proposed_responses": self.proposed_responses,
+                    "submind_opinions": self.submind_opinions,
+                    "votes": self.votes,
+                    "participating_subminds": self.participating_subminds}
 
     data: Union[_PromptData, List[_PromptData]] = Field(description="Prompt data")
     receiver: str = Field(description="Nickname of user requesting prompt data")

tests/models/api/test_klat.py

@@ -35,3 +35,9 @@ def test_prompt_data(self):
         self.assertIsInstance(test_object, PromptData._PromptData)
         self.assertEqual(test_object,
                          PromptData._PromptData(**test_object.model_dump()))
+
+        valid_prompt_data = PromptData(data=test_object,
+                                       receiver="mock_username",
+                                       cid="mock_conversation")
+        self.assertEqual(valid_prompt_data,
+                         PromptData(**valid_prompt_data.model_dump()))