DelEntry() fix in WildcardMatch module. #983
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #983 +/- ##
=======================================
Coverage 55.53% 55.53%
=======================================
Files 9 9
Lines 1165 1165
=======================================
Hits 647 647
Misses 518 518 Continue to review full report at Codecov.
|
This small patch fixes DelEntry routine that is invoked by CommandDelete() function. Hashtable's Remove function returns false on failure. The conditional expression that captures this event is incorrect (if condition in line 306 fails). This patch uses boolean variables to fix this issue. Signed-off-by: Muhammad Asim Jamshed <[email protected]> Signed-off-by: Saikrishna Edupuganti <[email protected]>
a-jamshed
force-pushed
the
topics/fix_wildcard_remove_tuple_op
branch
from
894c47d to
04975b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small patch fixes DelEntry routine that is invoked by
CommandDelete() function. Hashtable's Remove function returns
false on failure. The conditional expression that captures this
event is incorrect (if condition in line 306 fails). This patch
uses boolean variables to fix this issue.
Signed-off-by: Muhammad Asim Jamshed [email protected]