Skip to content

Commit 766236c

Browse files
committed
Don't write secrets to GITHUB_ENV
Update sonar-m-p Reference publish-unit-test-result-action via commit id
1 parent 37d104c commit 766236c

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

.github/workflows/maven.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,10 @@ jobs:
7070
if [ "${{ matrix.isMainBuildEnv }}" = "true" ]; then
7171
echo "MVN_ADDITIONAL_OPTS=-Dsonar.projectKey=Netcentric_aem-content-package-namespace-validators -Dsonar.organization=netcentric -Dsonar.host.url=https://sonarcloud.io -Pjacoco-report" >> $GITHUB_ENV
7272
if [ "${{github.ref}}" = "refs/heads/main" ] && [ "${{github.event_name}}" = "push" ]; then
73-
echo "MAVEN_USERNAME=${{ secrets.SONATYPE_CENTRAL_TOKEN_USER }}" >> $GITHUB_ENV
74-
echo "MAVEN_PASSWORD=${{ secrets.SONATYPE_CENTRAL_TOKEN_PASSWORD }}" >> $GITHUB_ENV
7573
echo "MVN_GOAL=clean deploy org.sonarsource.scanner.maven:sonar-maven-plugin:sonar" >> $GITHUB_ENV
76-
echo "STEP_NAME_SUFFIX=(Deploys to OSSRH)" >> $GITHUB_ENV
74+
echo "STEP_NAME_SUFFIX=(Deploys to Central Portal)" >> $GITHUB_ENV
7775
else
78-
echo "MVN_GOAL=clean verify org.sonarsource.scanner.maven:sonar-maven-plugin:5.0.0.4389:sonar" >> $GITHUB_ENV
76+
echo "MVN_GOAL=clean verify org.sonarsource.scanner.maven:sonar-maven-plugin:5.2.0.4988:sonar" >> $GITHUB_ENV
7977
fi
8078
else
8179
echo "MVN_ADDITIONAL_OPTS=" >> $GITHUB_ENV
@@ -89,6 +87,8 @@ jobs:
8987
env:
9088
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
9189
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
90+
MAVEN_USERNAME: ${{ secrets.SONATYPE_CENTRAL_TOKEN_USER }}
91+
MAVEN_PASSWORD: ${{ secrets.SONATYPE_CENTRAL_TOKEN_PASSWORD }}
9292
run: ./mvnw -e -B -V ${{ env.MVN_GOAL }} ${{ env.MVN_ADDITIONAL_OPTS }}
9393

9494
- name: Upload Test Results
@@ -125,6 +125,6 @@ jobs:
125125
path: artifacts
126126

127127
- name: Publish Test Results
128-
uses: EnricoMi/publish-unit-test-result-action@v2
128+
uses: EnricoMi/publish-unit-test-result-action@3a74b2957438d0b6e2e61d67b05318aa25c9e6c6
129129
with:
130130
files: "artifacts/**/*.xml"

0 commit comments

Comments
 (0)