Skip to content

Commit 93ae95b

Browse files
committed
Remove duplicate comments on DerivationBuilderImpl overriden methods
Having the exact same doc comments isn't very useful/maintainable.
1 parent 69914e4 commit 93ae95b

File tree

1 file changed

+0
-31
lines changed

1 file changed

+0
-31
lines changed

src/libstore/unix/build/derivation-builder.cc

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -256,30 +256,10 @@ class DerivationBuilderImpl : public DerivationBuilder, DerivationBuilderParams
256256

257257
public:
258258

259-
/**
260-
* Set up build environment / sandbox, acquiring resources (e.g.
261-
* locks as needed). After this is run, the builder should be
262-
* started.
263-
*
264-
* @returns true if successful, false if we could not acquire a build
265-
* user. In that case, the caller must wait and then try again.
266-
*/
267259
bool prepareBuild() override;
268260

269-
/**
270-
* Start building a derivation.
271-
*/
272261
void startBuilder() override;
273262

274-
/**
275-
* Tear down build environment after the builder exits (either on
276-
* its own or if it is killed).
277-
*
278-
* @returns The first case indicates failure during output
279-
* processing. A status code and exception are returned, providing
280-
* more information. The second case indicates success, and
281-
* realisations for each output of the derivation are returned.
282-
*/
283263
std::variant<std::pair<BuildResult::Status, Error>, SingleDrvOutputs> unprepareBuild() override;
284264

285265
private:
@@ -311,10 +291,6 @@ class DerivationBuilderImpl : public DerivationBuilder, DerivationBuilderParams
311291

312292
public:
313293

314-
/**
315-
* Stop the in-process nix daemon thread.
316-
* @see startDaemon
317-
*/
318294
void stopDaemon() override;
319295

320296
private:
@@ -346,15 +322,8 @@ class DerivationBuilderImpl : public DerivationBuilder, DerivationBuilderParams
346322

347323
public:
348324

349-
/**
350-
* Delete the temporary directory, if we have one.
351-
*/
352325
void deleteTmpDir(bool force) override;
353326

354-
/**
355-
* Kill any processes running under the build user UID or in the
356-
* cgroup of the build.
357-
*/
358327
void killSandbox(bool getStats) override;
359328

360329
private:

0 commit comments

Comments
 (0)