Skip to content

Introduce MissingPaths struct for queryMissing() / printMissing() #13420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 7, 2025
Merged

Introduce MissingPaths struct for queryMissing() / printMissing() #13420

merged 3 commits into from
Jul 7, 2025
+78 −100

Conversation

edolstra
Copy link
Member

@edolstra edolstra commented Jul 4, 2025

Motivation

This cleans up the code a bit.

Context

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

edolstra added 3 commits July 4, 2025 16:34
@edolstra
queryMissing(): Return a struct
af05ce0 
...instead of having a bunch of pass-by-reference arguments.
@edolstra
printMissing(): Take a MissingPaths argument
5d308cc
@edolstra
nix-build: Drop unnecessary call to queryMissing()
f039f68 
This is already done by Worker::run().
@edolstra edolstra requested a review from Ericson2314 as a code owner July 4, 2025 14:43
@github-actions github-actions bot added the store Issues and pull requests concerning the Nix store label Jul 4, 2025
@edolstra edolstra mentioned this pull request Jul 4, 2025
Merged
roberth
roberth reviewed Jul 7, 2025
View reviewed changes
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already looks like a nice improvement.
In addition, I believe "missing" to be somewhat of a misnomer. Something like RealisationPlan seems more descriptive, or perhaps RealisationOutline if "plan" sounds too detailed.

@edolstra
Copy link
Member Author

edolstra commented Jul 7, 2025

MissingPaths is not ideal but it matches the function names (queryMissing() / printMissing()). Maybe in a future PR we could rename those (e.g. queryRealisationPlan() or whatever).

@roberth roberth merged commit c512fd1 into master Jul 7, 2025
25 checks passed
@roberth roberth deleted the query-missing branch July 7, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberth roberth roberth approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

Assignees
No one assigned
Labels
store Issues and pull requests concerning the Nix store
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edolstra @roberth