Skip to content

Commit 25f2543

Browse files
committed
Revise remark and rebase
1 parent 3ad522b commit 25f2543

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

nbs/core.ipynb

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -552,7 +552,11 @@
552552
" if prediction_intervals is not None:\n",
553553
" self.prediction_intervals = prediction_intervals\n",
554554
"\n",
555-
" # copy of model to prevent issue such as https://github.com/Nixtla/neuralforecast/issues/1232\n",
555+
" # copy of model to prevent error during hyperparmeter tuning with Ray\n",
556+
" # ValueError: You passed a `param_space` parameter to `Tuner(...)` with unresolved parameters,\n",
557+
" # but the search algorithm was already instantiated with a search space. \n",
558+
" # Make sure that `config` does not contain any more parameter definitions \n",
559+
" # - include them in the search algorithm's search space if necessary.\n",
556560
" model_copy = deepcopy(self)\n",
557561
" self._cs_df = model_copy._conformity_scores(\n",
558562
" df=df,\n",

neuralforecast/core.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,11 @@ def fit(
494494
if prediction_intervals is not None:
495495
self.prediction_intervals = prediction_intervals
496496

497-
# copy of model to prevent issue such as https://github.com/Nixtla/neuralforecast/issues/1232
497+
# copy of model to prevent error during hyperparmeter tuning with Ray
498+
# ValueError: You passed a `param_space` parameter to `Tuner(...)` with unresolved parameters,
499+
# but the search algorithm was already instantiated with a search space.
500+
# Make sure that `config` does not contain any more parameter definitions
501+
# - include them in the search algorithm's search space if necessary.
498502
model_copy = deepcopy(self)
499503
self._cs_df = model_copy._conformity_scores(
500504
df=df,

0 commit comments

Comments
 (0)