Skip to content

Commit af8c4b2

Browse files
author
Stephanie Reeder
committed
fix saving append issues
1 parent c5c7bd5 commit af8c4b2

File tree

5 files changed

+8
-19
lines changed

5 files changed

+8
-19
lines changed

odmtools/controller/logicEditTools.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ def save_appending(self, var = None, method =None, qcl = None, overwrite = False
274274
if self._record:
275275

276276
self._script(
277-
"edit_service.save_appending(%s, %s, %s, %s)\n" % (self.saveFactory(var, method, qcl)+ [overwrite]),
277+
"edit_service.save_appending(%s, %s, %s, " % self.saveFactory(var, method, qcl)+str(overwrite )+")\n",
278278
'black')
279279
#self._script("edit_service.save(%s, %s, %s, saveAs=%s)\n" % (var, method, qcl, isSave), 'black')
280280
Publisher.sendMessage("scroll")

odmtools/controller/pageIntro.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ def __init__(self, parent, title):
2929
#style=wx.TAB_TRAVERSAL)
3030
self.sizer.Add(self.pnlIntroduction, 85, wx.ALL, 5)
3131

32-
33-
3432
self.pnlIntroduction.rbSave.Bind(wx.EVT_RADIOBUTTON, self.OnBtnSaveRadiobutton)
3533
self.pnlIntroduction.rbSaveAs.Bind(wx.EVT_RADIOBUTTON, self.OnBtnSaveAsRadiobutton)
3634
self.pnlIntroduction.rbSaveExisting.Bind(wx.EVT_RADIOBUTTON, self.OnBtnSaveExistingRadiobuton)
@@ -43,24 +41,19 @@ def SetPrev(self, prev):
4341

4442
def GetNext(self):
4543
return self.next
44+
4645
def GetPrev(self):
4746
return self.prev
4847

49-
5048
# Handlers for pnlIntro events.
5149
def OnBtnSaveRadiobutton(self, event):
52-
53-
print "in saveRadioButton"
5450
Publisher.sendMessage("wizChangeSave", event = event)
5551
#event.Skip()
5652

5753
def OnBtnSaveAsRadiobutton(self, event):
58-
print "in saveAsRadioButton"
5954
Publisher.sendMessage("wizChangeSave", event = event) #event.Skip()
6055

6156
def OnBtnSaveExistingRadiobuton(self, event):
6257
Publisher.sendMessage("wizChangeSave", event = event)
63-
print "in saveExistingRadioButton"
6458
#event.Skip()
65-
66-
59+

odmtools/gui/wizSave.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -328,13 +328,11 @@ def on_wizard_finished(self, event):
328328
elif rbSaveAsExisting:
329329
keyword = "overwrite"
330330

331-
if self.pgExisting.pnlExisting.rbAppend:
331+
if self.pgExisting.pnlExisting.rbAppend.GetValue():
332332
keyword = "append to"
333333

334-
message = "You are about to "+keyword+" an existing series,\nthis action cannot be undone.\nWould you like to continue?\n"
335-
cont = wx.MessageBox(message,
336-
'Are you sure?',
337-
wx.YES_NO | wx.ICON_QUESTION)
334+
message = "You are about to " + keyword + " an existing series,\nthis action cannot be undone.\nWould you like to continue?\n"
335+
cont = wx.MessageBox(message, 'Are you sure?', wx.YES_NO | wx.ICON_QUESTION)
338336
if cont == 2:
339337
closeSuccessful = True
340338
else:

odmtools/odmservices/edit_service.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -510,7 +510,7 @@ def updateSeries(self, var=None, method=None, qcl=None, is_new_series=False, ove
510510
series.end_date_time = datetime.datetime.strptime(str(np.max(dvs["LocalDateTime"])), form)
511511
series.end_date_time_utc = datetime.datetime.strptime(str(np.max(dvs["DateTimeUTC"])), form)
512512
#TODO figure out how to calculate the new value count
513-
series.value_count = series.value_count+len(dvs)
513+
series.value_count = series.value_count+len(dvs)#set test series value count to 19
514514

515515
# if overwrite:
516516
# if dbend >dfstart:
@@ -536,7 +536,7 @@ def updateSeries(self, var=None, method=None, qcl=None, is_new_series=False, ove
536536
self.memDB.series_service.delete_values_by_series(series, startdate=dfstart)
537537
else:
538538
#remove values from df
539-
dvs = dvs[dvs["LocalDateTime"] >= dbend]
539+
dvs = dvs[dvs["LocalDateTime"] > dbend]
540540

541541

542542

odmtools/odmservices/series_service.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -512,7 +512,6 @@ def save_new_series(self, series, dvs):
512512
self._edit_session.rollback()
513513
raise e
514514

515-
516515
logger.debug("A new series was added to the database, series id: "+str(series.id))
517516
return True
518517

@@ -524,7 +523,6 @@ def save_values(self, values):
524523
"""
525524
values.to_sql(name="datavalues", if_exists='append', con=self._session_factory.engine, index=False)
526525

527-
528526
def create_new_series(self, data_values, site_id, variable_id, method_id, source_id, qcl_id):
529527
"""
530528

0 commit comments

Comments
 (0)