Merge pull request #240 from OS2Forms/develop

Release 5.0.0

Author: stankut

.github/opgavebeskrivelse.md

@@ -0,0 +1,42 @@
+---
+name: Opgavebeskrivelse
+description: Standard skabelon for definition af opgaver
+title: ''
+labels: ''
+assignees: ''
+---
+
+# Kort titel, der repræsenterer opgaven, påkrævet
+
+**Opgavebeskrivelse**: {venligst henvis til eventuelle danske ord, der bruges til at definere aktiviteten i omfanget.}
+
+**Møde eller møderække**: {en eventuel henvisning til mødet, hvor opgaven blev aftalt, inklusive dato og tidspunkt.}
+
+**Opdragsgiver**: {henvis til beslutningsorganet, der er enige om opgaven.}
+
+## Overordnet opgavebeskrivelse
+
+{Beskriv konteksten og problemstillingen, fx i fri form med to til tre sætninger eller i form af en illustrativ historie.}
+
+## Kontekst og problem at løse
+
+{Beskriv konteksten og problemstillingen, fx i fri form med to til tre sætninger eller i form af en illustrativ historie.}
+
+## Vigtige milepæle
+
+* {titel på milepæl 1}
+* {titel på milepæl 2}
+
+## Aktiviteter eller underopgaver (sub-issues)
+
+* [ ] {titel på opgave 1}
+* [ ] {titel på opgave 2}
+* [ ] {titel på opgave 3}
+
+## Accept kriterier
+
+{Beskriv med enkle ord, hvornår opgaven betragtes som fuldført, og angiv eventuelle formelle godkendelseskrav.}
+
+## Risici & konsekvenser, hvis opgaven ikke udføres
+
+{Beskriv med enkle ord, hvilke risici og konsekvenser det har, hvis opgaven ikke udføres.}

CHANGELOG.md

@@ -11,6 +11,34 @@ before starting to add changes. Use example [placed in the end of the page](#exa
 
 ## [Unreleased]
 
+## [5.0.0] 2025-11-18
+
+- [PR-192](https://github.com/OS2Forms/os2forms/pull/192)
+  Fix bug in MitidChildrenSelectAjaxBehaviour.php
+- [PR-228](https://github.com/OS2Forms/os2forms/pull/228)
+  Added Drupal Core patch ensuring conditionals based upon computed twig
+  works as intended.
+- [PR-215](https://github.com/OS2Forms/os2forms/pull/215)
+  Added condition to maestro notification submission handler
+- [PR-101](https://github.com/OS2Forms/os2forms/pull/101)
+  - Added support for `os2web_key` in Digital post
+    - Switched from saving settings in key value store to config, i.e
+      the module needs to be reconfigured.
+  - Added support for `os2web_key` in Fasit handler.
+    - Switched from saving settings in key value store to config, i.e
+      the module needs to be reconfigured.
+- [PR-179](https://github.com/OS2Forms/os2forms/pull/179)
+  Remove unused and abandoned package `webmozart/path-util`.
+- [PR-167](https://github.com/OS2Forms/os2forms/pull/167)
+  Adding os2forms_digital_signature module
+- [PR-223](https://github.com/OS2Forms/os2forms/pull/223)
+  Moved GitHub feature template to GitHub folder
+- [PR-184](https://github.com/OS2Forms/os2forms/pull/184)
+  - Patches `coc_forms_auto_export` to ensure settings can be saved upon initial
+    attempt, cf. [Unable to save initial settings due to unfocusable form control](https://www.drupal.org/project/coc_forms_auto_export/issues/3531004)
+- [PR-222](https://github.com/OS2Forms/os2forms/pull/222)
+  Correctly sets sender label on Maestro digital post notifications.
+- [OS-199] Remove modules that are not used and not covered by central maintenance from OS2forms
 - Avoid double-saving submissions when handling name and address protection.
 - [PR-191](https://github.com/OS2Forms/os2forms/pull/191)
   Re-throws exception to ensure failed status during Maestro notification job.

composer.json

@@ -12,11 +12,9 @@
         "drupal/admin_toolbar": "^3.0",
         "drupal/advancedqueue": "^1.0",
         "drupal/cache_control_override": "^1.1 || ^2.0",
-        "drupal/clientside_validation": "^4.0",
         "drupal/coc_forms_auto_export": "^3.0@alpha",
         "drupal/config_entity_revisions": "2.0.x-dev",
         "drupal/diff": "^1.0",
-        "drupal/embed": "^1.4",
         "drupal/entity_print": "^2.1",
         "drupal/eu_cookie_compliance": "^1.8",
         "drupal/events_logging": "^2.0@beta",
@@ -58,13 +56,13 @@
         "itk-dev/serviceplatformen": "^1.7.1",
         "mglaman/composer-drupal-lenient": "^1.0",
         "os2web/os2web_audit": "^1.0",
-        "os2web/os2web_datalookup": "^2.0",
+        "os2web/os2web_datalookup": "^3.0",
+        "os2web/os2web_key": "^1.0",
         "os2web/os2web_nemlogin": "^1.0",
         "os2web/os2web_simplesaml": "dev-master",
         "php-http/guzzle7-adapter": "^1.0",
         "phpoffice/phpword": "^0.18.2",
         "symfony/options-resolver": "^5.4 || ^6.0",
-        "webmozart/path-util": "^2.3",
         "wsdltophp/packagebase": "^5.0",
         "zaporylie/composer-drupal-optimizations": "^1.2"
     },
@@ -115,7 +113,11 @@
         "enable-patching": true,
         "patches": {
             "drupal/coc_forms_auto_export": {
-                "3256951: - Unable to receive attachments in emails sent": "https://git.drupalcode.org/project/coc_forms_auto_export/-/merge_requests/11.diff"
+                "3256951: - Unable to receive attachments in emails sent": "https://git.drupalcode.org/project/coc_forms_auto_export/-/merge_requests/11.diff",
+                "3531004: Unable to save initial settings due to unfocusable form control": "https://www.drupal.org/files/issues/2025-06-19/text_area_with_text_edit_always_fails_reqired_set_via_states.patch"
+            },
+            "drupal/core": {
+                "Allow conditionals based on computed twig (https://www.drupal.org/project/webform/issues/3481569)": "https://www.drupal.org/files/issues/2024-11-05/revert-core-states.patch"
             },
             "drupal/entity_print": {
                 "2733781 - Add Export to Word Support": "https://www.drupal.org/files/issues/2019-11-22/2733781-47.patch"

modules/os2forms_attachment/os2forms_attachment.services.yml

@@ -1,4 +1,4 @@
 services:
   os2forms_attachment.print_builder:
     class: Drupal\os2forms_attachment\Os2formsAttachmentPrintBuilder
-    arguments: ['@entity_print.renderer_factory', '@event_dispatcher', '@string_translation']
+    arguments: ['@entity_print.renderer_factory', '@event_dispatcher', '@string_translation', '@file_system']

modules/os2forms_attachment/src/Element/AttachmentElement.php

@@ -20,6 +20,7 @@ public function getInfo() {
     return parent::getInfo() + [
       '#view_mode' => 'html',
       '#export_type' => 'pdf',
+      '#digital_signature' => FALSE,
       '#template' => '',
     ];
   }
@@ -28,6 +29,8 @@ public function getInfo() {
    * {@inheritdoc}
    */
   public static function getFileContent(array $element, WebformSubmissionInterface $webform_submission) {
+    $submissionUuid = $webform_submission->uuid();
+
     // Override webform settings.
     static::overrideWebformSettings($element, $webform_submission);
 
@@ -51,18 +54,43 @@ public static function getFileContent(array $element, WebformSubmissionInterface
     \Drupal::request()->request->set('_webform_submissions_view_mode', $view_mode);
 
     if ($element['#export_type'] === 'pdf') {
-      // Get scheme.
-      $scheme = 'temporary';
-
-      // Get filename.
-      $file_name = 'webform-entity-print-attachment--' . $webform_submission->getWebform()->id() . '-' . $webform_submission->id() . '.pdf';
-
-      // Save printable document.
-      $print_engine = $print_engine_manager->createSelectedInstance($element['#export_type']);
-      $temporary_file_path = $print_builder->savePrintable([$webform_submission], $print_engine, $scheme, $file_name);
-      if ($temporary_file_path) {
-        $contents = file_get_contents($temporary_file_path);
-        \Drupal::service('file_system')->delete($temporary_file_path);
+      $file_path = NULL;
+
+      // If attachment with digital signatur, check if we already have one.
+      if (isset($element['#digital_signature']) && $element['#digital_signature']) {
+        // Get scheme.
+        $scheme = 'private';
+
+        // Get filename.
+        $file_name = 'webform/' . $webform_submission->getWebform()->id() . '/digital_signature/' . $submissionUuid . '.pdf';
+        $file_path = "$scheme://$file_name";
+      }
+
+      if (!$file_path || !file_exists($file_path)) {
+        // Get scheme.
+        $scheme = 'temporary';
+        // Get filename.
+        $file_name = 'webform-entity-print-attachment--' . $webform_submission->getWebform()->id() . '-' . $webform_submission->id() . '.pdf';
+
+        // Save printable document.
+        $print_engine = $print_engine_manager->createSelectedInstance($element['#export_type']);
+
+        // Adding digital signature.
+        if (isset($element['#digital_signature']) && $element['#digital_signature']) {
+          $file_path = $print_builder->savePrintableDigitalSignature([$webform_submission], $print_engine, $scheme, $file_name);
+        }
+        else {
+          $file_path = $print_builder->savePrintable([$webform_submission], $print_engine, $scheme, $file_name);
+        }
+      }
+
+      if ($file_path) {
+        $contents = file_get_contents($file_path);
+
+        // Deleting temporary file.
+        if ($scheme == 'temporary') {
+          \Drupal::service('file_system')->delete($file_path);
+        }
       }
       else {
         // Log error.

modules/os2forms_attachment/src/Os2formsAttachmentPrintBuilder.php

@@ -3,14 +3,28 @@
 namespace Drupal\os2forms_attachment;
 
 use Drupal\Core\Entity\EntityInterface;
+use Drupal\Core\File\FileExists;
+use Drupal\Core\File\FileSystemInterface;
+use Drupal\Core\StringTranslation\TranslationInterface;
+use Drupal\entity_print\Event\PreSendPrintEvent;
+use Drupal\entity_print\Event\PrintEvents;
 use Drupal\entity_print\Plugin\PrintEngineInterface;
 use Drupal\entity_print\PrintBuilder;
+use Drupal\entity_print\Renderer\RendererFactoryInterface;
+use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 
 /**
  * The OS2Forms attachment print builder service.
  */
 class Os2formsAttachmentPrintBuilder extends PrintBuilder {
 
+  /**
+   * {@inheritdoc}
+   */
+  public function __construct(RendererFactoryInterface $renderer_factory, EventDispatcherInterface $event_dispatcher, TranslationInterface $string_translation, protected readonly FileSystemInterface $file_system) {
+    parent::__construct($renderer_factory, $event_dispatcher, $string_translation);
+  }
+
   /**
    * {@inheritdoc}
    */
@@ -27,10 +41,56 @@ public function printHtml(EntityInterface $entity, $use_default_css = TRUE, $opt
     return $renderer->generateHtml([$entity], $render, $use_default_css, $optimize_css);
   }
 
+  /**
+   * Modified version of the original savePrintable() function.
+   *
+   * The only difference is modified call to prepareRenderer with digitalPost
+   * flag TRUE.
+   *
+   * @see PrintBuilder::savePrintable()
+   *
+   * @return string
+   *   FALSE or the URI to the file. E.g. public://my-file.pdf.
+   */
+  public function savePrintableDigitalSignature(array $entities, PrintEngineInterface $print_engine, $scheme = 'public', $filename = FALSE, $use_default_css = TRUE) {
+    $renderer = $this->prepareRenderer($entities, $print_engine, $use_default_css, TRUE);
+
+    // Allow other modules to alter the generated Print object.
+    $this->dispatcher->dispatch(new PreSendPrintEvent($print_engine, $entities), PrintEvents::PRE_SEND);
+
+    // If we didn't have a URI passed in the generate one.
+    if (!$filename) {
+      $filename = $renderer->getFilename($entities) . '.' . $print_engine->getExportType()->getFileExtension();
+    }
+
+    $uri = "$scheme://$filename";
+
+    // Save the file.
+    return $this->file_system->saveData($print_engine->getBlob(), $uri, FileExists::Replace);
+  }
+
   /**
    * {@inheritdoc}
    */
-  protected function prepareRenderer(array $entities, PrintEngineInterface $print_engine, $use_default_css) {
+
+  /**
+   * Override prepareRenderer() the print engine with the passed entities.
+   *
+   * @param array $entities
+   *   An array of entities.
+   * @param \Drupal\entity_print\Plugin\PrintEngineInterface $print_engine
+   *   The print engine.
+   * @param bool $use_default_css
+   *   TRUE if we want the default CSS included.
+   * @param bool $digitalSignature
+   *   If the digital signature message needs to be added.
+   *
+   * @return \Drupal\entity_print\Renderer\RendererInterface
+   *   A print renderer.
+   *
+   * @see PrintBuilder::prepareRenderer
+   */
+  protected function prepareRenderer(array $entities, PrintEngineInterface $print_engine, $use_default_css, $digitalSignature = FALSE) {
     if (empty($entities)) {
       throw new \InvalidArgumentException('You must pass at least 1 entity');
     }
@@ -50,6 +110,9 @@ protected function prepareRenderer(array $entities, PrintEngineInterface $print_
     // structure. That margin is automatically added in PDF and PDF only.
     $generatedHtml = (string) $renderer->generateHtml($entities, $render, $use_default_css, TRUE);
     $generatedHtml .= "<style>fieldset legend {margin-left: -12px;}</style>";
+    if ($digitalSignature) {
+      $generatedHtml .= $this->t('You can validate the signature on this PDF file via validering.nemlog-in.dk.');
+    }
 
     $print_engine->addPage($generatedHtml);
 

modules/os2forms_attachment/src/Plugin/WebformElement/AttachmentElement.php

@@ -27,6 +27,7 @@ protected function defineDefaultProperties() {
       'view_mode' => 'html',
       'template' => '',
       'export_type' => '',
+      'digital_signature' => '',
       'exclude_empty' => '',
       'exclude_empty_checkbox' => '',
       'excluded_elements' => '',
@@ -88,6 +89,11 @@ public function form(array $form, FormStateInterface $form_state) {
         'html' => $this->t('HTML'),
       ],
     ];
+    $form['attachment']['digital_signature'] = [
+      '#type' => 'checkbox',
+      '#title' => $this->t('Digital signature'),
+    ];
+
     // Set #access so that help is always visible.
     WebformElementHelper::setPropertyRecursive($form['attachment']['help'], '#access', TRUE);
 

modules/os2forms_dawa/src/Plugin/os2web/DataLookup/DatafordelerDataLookup.php

@@ -3,8 +3,10 @@
 namespace Drupal\os2forms_dawa\Plugin\os2web\DataLookup;
 
 use Drupal\Component\Utility\NestedArray;
+use Drupal\Core\File\FileSystem;
 use Drupal\Core\Form\FormStateInterface;
 use Drupal\Core\Plugin\ContainerFactoryPluginInterface;
+use Drupal\key\KeyRepositoryInterface;
 use Drupal\os2forms_dawa\Entity\DatafordelerMatrikula;
 use Drupal\os2web_audit\Service\Logger;
 use Drupal\os2web_datalookup\Plugin\os2web\DataLookup\DataLookupBase;
@@ -30,20 +32,31 @@ public function __construct(
     $plugin_definition,
     protected ClientInterface $httpClient,
     Logger $auditLogger,
+    KeyRepositoryInterface $keyRepository,
+    FileSystem $fileSystem,
   ) {
-    parent::__construct($configuration, $plugin_id, $plugin_definition, $auditLogger);
+    parent::__construct($configuration, $plugin_id, $plugin_definition, $auditLogger, $keyRepository, $fileSystem);
   }
 
   /**
    * {@inheritdoc}
    */
   public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) {
+    /** @var \Drupal\os2web_audit\Service\Logger $auditLogger */
+    $auditLogger = $container->get('os2web_audit.logger');
+    /** @var \Drupal\key\KeyRepositoryInterface $keyRepository */
+    $keyRepository = $container->get('key.repository');
+    /** @var \Drupal\Core\File\FileSystem $fileSystem */
+    $fileSystem = $container->get('file_system');
+
     return new static(
       $configuration,
       $plugin_id,
       $plugin_definition,
       $container->get('http_client'),
-      $container->get('os2web_audit.logger'),
+      $auditLogger,
+      $keyRepository,
+      $fileSystem,
     );
   }
 

modules/os2forms_digital_post/README.md

@@ -31,6 +31,11 @@ examples](modules/os2forms_digital_post_examples/README.md).
 Go to `/admin/os2forms_digital_post/settings` to set up global settings for
 digital post.
 
+### Key
+
+We use [os2web_key](https://github.com/OS2web/os2web_key) to provide the certificate for sending digital post, and the
+key must be of type "[Certificate](https://github.com/os2web/os2web_key?tab=readme-ov-file#certificate)".
+
 ### Queue
 
 The actual sending of digital post is handled by jobs in an [Advanced

modules/os2forms_digital_post/os2forms_digital_post.info.yml

@@ -7,6 +7,7 @@ dependencies:
   - 'beskedfordeler:beskedfordeler'
   - 'drupal:advancedqueue'
   - 'os2web_datalookup:os2web_datalookup'
+  - 'os2web_key:os2web_key'
   - 'webform:webform'
   - 'webform:webform_submission_log'
   - 'os2web:os2web_audit'