Finished iOS bridge for Outcomes

Author: rgomezp

index.js

@@ -475,11 +475,6 @@ export default class OneSignal {
     static sendOutcome(name, callback=()=>{}) {
         if (!checkIfInitialized()) return;
 
-        if (Platform.OS === "ios") {
-            console.warn("OneSignal.sendOutcome is not yet supported on iOS");
-            return;
-        }
-
         invariant(
             typeof callback === 'function',
             'Must provide a valid callback'
@@ -491,11 +486,6 @@ export default class OneSignal {
     static sendUniqueOutcome(name, callback=()=>{}) {
         if (!checkIfInitialized()) return;
 
-        if (Platform.OS === "ios") {
-            console.warn("OneSignal.sendUniqueOutcome is not yet supported on iOS");
-            return;
-        }
-
         invariant(
             typeof callback === 'function',
             'Must provide a valid callback'
@@ -507,11 +497,6 @@ export default class OneSignal {
     static sendOutcomeWithValue(name, value, callback=()=>{}) {
         if (!checkIfInitialized()) return;
 
-        if (Platform.OS === "ios") {
-            console.warn("OneSignal.sendOutcomeWithValue is not yet supported on iOS");
-            return;
-        }
-
         invariant(
             typeof callback === 'function',
             'Must provide a valid callback'

ios/RCTOneSignal/RCTOneSignalEventEmitter.m

@@ -377,8 +377,8 @@ + (void)sendEventWithName:(NSString *)name withBody:(NSDictionary *)body {
     [OneSignal removeTriggerForKey:key];
 }
 
-RCT_REMAP_METHOD(getTriggerValueForKey, 
-                key:(NSString *)key 
+RCT_REMAP_METHOD(getTriggerValueForKey,
+                key:(NSString *)key
                 getTriggerValueForKeyResolver:(RCTPromiseResolveBlock)resolve
                 rejecter:(RCTPromiseRejectBlock)reject) {
 
@@ -404,27 +404,27 @@ + (void)sendEventWithName:(NSString *)name withBody:(NSDictionary *)body {
          @"clickUrl" : action.clickUrl.absoluteString ?: [NSNull null],
          @"firstClick" : @(action.firstClick),
          @"closesMessage" : @(action.closesMessage)
-        }; 
+        };
         [RCTOneSignalEventEmitter sendEventWithName:@"OneSignal-inAppMessageClicked" withBody:result];
     }];
 }
 
 /*
  * Outcomes
  */
-RCT_EXPORT_METHOD(sendOutcome:(NSString *)name withCallback:(RCTResponseSenderBlock)callback) {
+RCT_EXPORT_METHOD(sendOutcome:(NSString *)name :(RCTResponseSenderBlock)callback) {
     [OneSignal sendOutcome:name onSuccess:^(OSOutcomeEvent *outcome){
         callback(@[[outcome jsonRepresentation]]);
     }];
 }
 
-RCT_EXPORT_METHOD(sendUniqueOutcome:(NSString *)name withCallback:(RCTResponseSenderBlock)callback) {
+RCT_EXPORT_METHOD(sendUniqueOutcome:(NSString *)name :(RCTResponseSenderBlock)callback) {
     [OneSignal sendUniqueOutcome:name onSuccess:^(OSOutcomeEvent *outcome){
         callback(@[[outcome jsonRepresentation]]);
     }];
 }
 
-RCT_EXPORT_METHOD(sendOutcomeWithValue:(NSString *)name withValue:(float)value withCallback:(RCTResponseSenderBlock)callback) {
+RCT_EXPORT_METHOD(sendOutcomeWithValue:(NSString *)name :(NSNumber * _Nonnull)value :(RCTResponseSenderBlock)callback) {
     [OneSignal sendOutcomeWithValue:name value:value onSuccess:^(OSOutcomeEvent *outcome){
         callback(@[[outcome jsonRepresentation]]);
     }];