Fix module path in JDK 24 and older #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the JLink test only works for JDK 25 and above
- Added integration test for classpath usage - Test using value extractor in main - Remove service provider entries in module-info to avoid optional dependency issue in JDK 24 and older
src/it/jakarta-jar-classpath/pom.xml
Outdated
| <version>3.6.2</version> | ||
| <executions> | ||
| <execution> | ||
| <id>run-jlink-main</id> |
Contributor
There was a problem hiding this comment.
Rename (or remove) this since there isn't any jlink here.
| <version>3.6.2</version> | ||
| <executions> | ||
| <execution> | ||
| <id>run-jlink-main</id> |
Contributor
There was a problem hiding this comment.
Rename (or remove) this since there isn't any jlink here.
|
|
||
| exports org.openapitools.jackson.nullable; | ||
|
|
||
| provides com.fasterxml.jackson.databind.Module with org.openapitools.jackson.nullable.JsonNullableModule; |
Contributor
There was a problem hiding this comment.
Does this one need to be removed? It's not related to javax/jakarta, so I don't think that it should be a problem here (unless I'm misunderstanding the root problem).
Contributor
Author
There was a problem hiding this comment.
I was testing some other things and forgot to add it back :)
|
|
||
| provides com.fasterxml.jackson.databind.Module with org.openapitools.jackson.nullable.JsonNullableModule; | ||
| provides javax.validation.valueextraction.ValueExtractor with org.openapitools.jackson.nullable.JsonNullableValueExtractor; | ||
| provides jakarta.validation.valueextraction.ValueExtractor with org.openapitools.jackson.nullable.JsonNullableJakartaValueExtractor; |
Contributor
There was a problem hiding this comment.
Maybe leave this in, but commented out that it can be re-added when either of the below are true.
- Baseline JDK is 25 (to avoid telling users that they can build with 25+, and still use something lower).
- Javax is dropped, so that there isn't a need for anything optional.
Just a suggestion, but not a problem either way.
nrayburn-tech
approved these changes
Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the SPI entries for
ValueExtractors, since they are optional dependencies and there is a bug that was fixed in JDK 25 (https://bugs.openjdk.org/browse/JDK-8347915).Changes:
mvn wrapper:wrappersince I had some problems with it. I do not know what the problem was, but it was fixed by updating.integration-testMaven profileJsonNullableJakartaValueExtractorJsonNullableJakartaValueExtractor--module-pathJsonNullableJakartaValueExtractor--class-pathJsonNullableJakartaValueExtractorvia theServiceLoadercloses #100