Skip to content

Commit 14c705b

Browse files
committed
GHA: Make sure we only download the required artifact for tests
Make sure the name is unique. This is just generally less wasteful. And it caused issues with download-artifact v5 where the behavior differs between downloading one or more artifacts. Signed-off-by: Frank Lichtenheld <[email protected]>
1 parent f0ea7b2 commit 14c705b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.github/workflows/build.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ jobs:
127127
- name: Archive artifacts
128128
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
129129
with:
130-
name: openvpn-master-${{ env.DATETIME }}-${{ env.OPENVPN_COMMIT }}-${{ matrix.arch }}
130+
name: openvpn-msi-${{ env.DATETIME }}-${{ env.OPENVPN_COMMIT }}-${{ matrix.arch }}
131131
path: ${{ github.workspace }}\windows-msi\image\*-${{ matrix.arch }}.msi
132132

133133
- name: Save vcpkg cache
@@ -172,7 +172,7 @@ jobs:
172172
- name: Get artifacts
173173
uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # v5.0.0
174174
with:
175-
pattern: "*-amd64"
175+
pattern: "openvpn-msi-*-amd64"
176176
path: msi
177177

178178
- name: Run AWS test
@@ -181,7 +181,7 @@ jobs:
181181
run: |
182182
Install-Module -Name AWS.Tools.Installer -Force
183183
Install-AWSToolsModule AWS.Tools.EC2 -Force
184-
.\Start-AWSTest.ps1 -SSH_KEY ~/.ssh/id_rsa -MSI_PATH $(Get-ChildItem ../msi/*-amd64/*.msi | select -ExpandProperty FullName)
184+
.\Start-AWSTest.ps1 -SSH_KEY ~/.ssh/id_rsa -MSI_PATH $(Get-ChildItem ../msi/*.msi | select -ExpandProperty FullName)
185185
186186
- name: Archive openvpn logs
187187
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2

0 commit comments

Comments
 (0)