From 83e4c9019d12079c7897f0037e286d764d130f45 Mon Sep 17 00:00:00 2001 From: Frank Lichtenheld Date: Mon, 11 Aug 2025 13:59:06 +0200 Subject: [PATCH] GHA: Make sure we only download the required artifact for tests Make sure the name is unique. This is just generally less wasteful. And it caused issues with download-artifact v5 where the behavior differs between downloading one or more artifacts. Signed-off-by: Frank Lichtenheld --- .github/workflows/build.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index c2c2ada9..094e61f5 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -127,7 +127,7 @@ jobs: - name: Archive artifacts uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 with: - name: openvpn-master-${{ env.DATETIME }}-${{ env.OPENVPN_COMMIT }}-${{ matrix.arch }} + name: openvpn-msi-${{ env.DATETIME }}-${{ env.OPENVPN_COMMIT }}-${{ matrix.arch }} path: ${{ github.workspace }}\windows-msi\image\*-${{ matrix.arch }}.msi - name: Save vcpkg cache @@ -172,7 +172,7 @@ jobs: - name: Get artifacts uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # v5.0.0 with: - pattern: "*-amd64" + pattern: "openvpn-msi-*-amd64" path: msi - name: Run AWS test @@ -181,7 +181,7 @@ jobs: run: | Install-Module -Name AWS.Tools.Installer -Force Install-AWSToolsModule AWS.Tools.EC2 -Force - .\Start-AWSTest.ps1 -SSH_KEY ~/.ssh/id_rsa -MSI_PATH $(Get-ChildItem ../msi/*-amd64/*.msi | select -ExpandProperty FullName) + .\Start-AWSTest.ps1 -SSH_KEY ~/.ssh/id_rsa -MSI_PATH $(Get-ChildItem ../msi/*.msi | select -ExpandProperty FullName) - name: Archive openvpn logs uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2