remove print statements when needed and allow default parameter for non-tests

Author: wimo7083

app/controllers/api/v1/resources_controller.rb

@@ -2,7 +2,7 @@ module Api
   module V1
     class ResourcesController < ApiController
       before_action :authenticate_user!, except: [:index, :show]
-      before_filter :set_resource, only: [:show, :update, :destroy]
+      before_action :set_resource, only: [:show, :update, :destroy]
 
       def index
         resources = Resource.with_tags params[:tags]

app/lib/git_hub/issues.rb

@@ -9,13 +9,15 @@ def initialize
       @date = GitHubStatistic.last_issue_completed_on
     end
 
-    def fetch_and_save!
+    def fetch_and_save!(print_results: true)
       get_issues.each do |issue|
         git_hub_user = GitHub::Committer.find_or_create_user! issue[:git_hub_user]
+        git_hub_issue_stat = GitHub::Committer.find_or_create_statistic! issue, issue[:source_type], git_hub_user.id
+
+        next unless print_results
         p 'git_hub_user:'
         p git_hub_user
 
-        git_hub_issue_stat = GitHub::Committer.find_or_create_statistic! issue, issue[:source_type], git_hub_user.id
         p 'git_hub_issue_stat:'
         p git_hub_issue_stat
       end

app/lib/git_hub/pull_requests.rb

@@ -9,13 +9,15 @@ def initialize
       @date = GitHubStatistic.last_pr_completed_on
     end
 
-    def fetch_and_save!
+    def fetch_and_save!(print_results: true)
       get_pull_requests.each do |pr|
         git_hub_user = GitHub::Committer.find_or_create_user! pr[:git_hub_user]
+        git_hub_pr_stat = GitHub::Committer.find_or_create_statistic! pr, pr[:source_type], git_hub_user.id
+
+        next unless print_results
         p 'git_hub_user:'
         p git_hub_user
 
-        git_hub_pr_stat = GitHub::Committer.find_or_create_statistic! pr, pr[:source_type], git_hub_user.id
         p 'git_hub_pr_stat:'
         p git_hub_pr_stat
       end

lib/tasks/schools_from_yml.rake

@@ -31,8 +31,8 @@ namespace :schools do
         Rails.logger.error message
       end
 
-      p "Created #{CodeSchool.count} code schools"
-      p "Created #{Location.count} locations"
+      # p "Created #{CodeSchool.count} code schools"
+      # p "Created #{Location.count} locations"
     end
   end
 end

test/models/request_test.rb

@@ -2,8 +2,8 @@
 
 class RequestTest < ActiveSupport::TestCase
   test 'the truth' do
-    request = create(:request)
-    p request.requested_mentor
+    create(:request)
+    # p request.requested_mentor
   end
 
 end

test/requests/git_hub/issues_test.rb

@@ -35,7 +35,7 @@ def test_get_issues
   end
 
   def test_fetch_and_save
-    @issue_instance.fetch_and_save!
+    @issue_instance.fetch_and_save!(print_results: false)
 
     assert GitHubStatistic.for_repository(@backend).count == 28
     assert GitHubStatistic.for_repository(@backend).issues.count == 28

test/requests/git_hub/pull_requests_test.rb

@@ -51,7 +51,7 @@ def test_get_pull_requests
   end
 
   def test_fetch_and_save
-    @pr_instance.fetch_and_save!
+    @pr_instance.fetch_and_save!(print_results: false)
 
     assert GitHubStatistic.for_repository(@slash).count == 4
     assert GitHubStatistic.for_repository(@slash).pull_requests.count == 2