Merge pull request #421 from OperationCode/test_chatters

Test chatters

Author: apex-omontgomery

.gitignore

@@ -24,6 +24,9 @@
 .idea/**/dynamic.xml
 .idea/**/uiDesigner.xml
 
+# VSCode
+.vscode/*
+
 # Gradle:
 .idea/**/gradle.xml
 .idea/**/libraries

app/controllers/api/v1/resources_controller.rb

@@ -2,7 +2,7 @@ module Api
   module V1
     class ResourcesController < ApiController
       before_action :authenticate_user!, except: [:index, :show]
-      before_filter :set_resource, only: [:show, :update, :destroy]
+      before_action :set_resource, only: [:show, :update, :destroy]
 
       def index
         resources = Resource.with_tags params[:tags]

app/lib/git_hub/issues.rb

@@ -9,13 +9,15 @@ def initialize
       @date = GitHubStatistic.last_issue_completed_on
     end
 
-    def fetch_and_save!
+    def fetch_and_save!(print_results: true)
       get_issues.each do |issue|
         git_hub_user = GitHub::Committer.find_or_create_user! issue[:git_hub_user]
+        git_hub_issue_stat = GitHub::Committer.find_or_create_statistic! issue, issue[:source_type], git_hub_user.id
+
+        next unless print_results
         p 'git_hub_user:'
         p git_hub_user
 
-        git_hub_issue_stat = GitHub::Committer.find_or_create_statistic! issue, issue[:source_type], git_hub_user.id
         p 'git_hub_issue_stat:'
         p git_hub_issue_stat
       end

app/lib/git_hub/presenter.rb

@@ -10,7 +10,7 @@ def oc_totals
       {
         total_repositories: base_query.repository_count,
         total_closed_pull_requests: base_query.pull_requests.count,
-        total_closed_issues: base_query.issues.closed.count,
+        total_closed_issues: base_query.issues.is_closed.count,
         total_commits: base_query.commits.count,
         total_users: base_query.users_made_a_commit,
         total_additions: base_query.sum(:additions),
@@ -22,7 +22,7 @@ def totals_by_repository
       GitHubStatistic.repositories.each_with_object({}) do |repo, totals|
         totals[repo.to_sym] = {
           total_closed_pull_requests: base_query.for_repository(repo).pull_requests.count,
-          total_closed_issues: base_query.for_repository(repo).issues.closed.count,
+          total_closed_issues: base_query.for_repository(repo).issues.is_closed.count,
           total_commits: base_query.for_repository(repo).commits.count,
           total_users: base_query.for_repository(repo).users_made_a_commit,
           total_additions: base_query.for_repository(repo).sum(:additions),
@@ -38,7 +38,7 @@ def totals_for_user
 
       {
         total_closed_pull_requests: base_query.for_git_hub_user(user).pull_requests.count,
-        total_closed_issues: base_query.for_git_hub_user(user).issues.closed.count,
+        total_closed_issues: base_query.for_git_hub_user(user).issues.is_closed.count,
         total_commits: base_query.for_git_hub_user(user).commits.count,
         total_additions: base_query.for_git_hub_user(user).sum(:additions),
         total_deletions: base_query.for_git_hub_user(user).sum(:deletions),
@@ -61,7 +61,7 @@ def totals_for_user_in_repository
 
       {
         total_closed_pull_requests: user_in_repository(user, repo).pull_requests.count,
-        total_closed_issues: user_in_repository(user, repo).issues.closed.count,
+        total_closed_issues: user_in_repository(user, repo).issues.is_closed.count,
         total_commits: user_in_repository(user, repo).commits.count,
         total_additions: user_in_repository(user, repo).sum(:additions),
         total_deletions: user_in_repository(user, repo).sum(:deletions),

app/lib/git_hub/pull_requests.rb

@@ -9,13 +9,15 @@ def initialize
       @date = GitHubStatistic.last_pr_completed_on
     end
 
-    def fetch_and_save!
+    def fetch_and_save!(print_results: true)
       get_pull_requests.each do |pr|
         git_hub_user = GitHub::Committer.find_or_create_user! pr[:git_hub_user]
+        git_hub_pr_stat = GitHub::Committer.find_or_create_statistic! pr, pr[:source_type], git_hub_user.id
+
+        next unless print_results
         p 'git_hub_user:'
         p git_hub_user
 
-        git_hub_pr_stat = GitHub::Committer.find_or_create_statistic! pr, pr[:source_type], git_hub_user.id
         p 'git_hub_pr_stat:'
         p git_hub_pr_stat
       end

app/models/git_hub_statistic.rb

@@ -13,8 +13,8 @@ class GitHubStatistic < ApplicationRecord
   scope :pull_requests, -> { where(source_type: GitHubStatistic::PR) }
   scope :issues, -> { where(source_type: GitHubStatistic::ISSUE) }
   scope :commits, -> { where(source_type: GitHubStatistic::COMMIT) }
-  scope :closed, -> { where(state: 'closed') }
-  scope :open, -> { where(state: 'open') }
+  scope :is_closed, -> { where(state: 'closed') }
+  scope :is_open, -> { where(state: 'open') }
   scope :for_git_hub_user, -> git_hub_user { where(git_hub_user_id: git_hub_user.id) }
   scope :for_repository, -> repository { where(repository: repository) }
 
@@ -62,7 +62,7 @@ def self.users_made_a_commit
   #
   def self.users_closed_a_pr
     self
-      .closed
+      .is_closed
       .pull_requests
       .pluck(:git_hub_user_id)
       .uniq
@@ -91,7 +91,7 @@ def self.repository_count
   end
 
   def self.average_closed_prs_per_user
-    grouped_records = pull_requests.closed.group_by(&:git_hub_user_id)
+    grouped_records = pull_requests.is_closed.group_by(&:git_hub_user_id)
 
     return 0 unless grouped_records.present?
 
@@ -122,7 +122,7 @@ def self.per_user_average_in(grouped_records)
 
   def self.last_closed_date
     self
-      .closed
+      .is_closed
       .order(completed_on: :desc)
       .first
       .try(:completed_on)

lib/tasks/schools_from_yml.rake

@@ -30,9 +30,6 @@ namespace :schools do
         puts message
         Rails.logger.error message
       end
-
-      p "Created #{CodeSchool.count} code schools"
-      p "Created #{Location.count} locations"
     end
   end
 end

test/models/request_test.rb

@@ -2,8 +2,7 @@
 
 class RequestTest < ActiveSupport::TestCase
   test 'the truth' do
-    request = create(:request)
-    p request.requested_mentor
+    create(:request)
   end
 
 end

test/requests/git_hub/issues_test.rb

@@ -35,7 +35,7 @@ def test_get_issues
   end
 
   def test_fetch_and_save
-    @issue_instance.fetch_and_save!
+    @issue_instance.fetch_and_save!(print_results: false)
 
     assert GitHubStatistic.for_repository(@backend).count == 28
     assert GitHubStatistic.for_repository(@backend).issues.count == 28

test/requests/git_hub/pull_requests_test.rb

@@ -51,7 +51,7 @@ def test_get_pull_requests
   end
 
   def test_fetch_and_save
-    @pr_instance.fetch_and_save!
+    @pr_instance.fetch_and_save!(print_results: false)
 
     assert GitHubStatistic.for_repository(@slash).count == 4
     assert GitHubStatistic.for_repository(@slash).pull_requests.count == 2