set default to 5 seconds

Author: farjaad-opslevel

lib/closure_tree/support.rb

@@ -23,13 +23,10 @@ def initialize(model_class, options)
         :dependent => :nullify, # or :destroy or :delete_all -- see the README
         :name_column => 'name',
         :with_advisory_lock => true,
-        :advisory_lock_timeout_seconds => nil,
+        :advisory_lock_timeout_seconds => 5,
         :numeric_order => false
       }.merge(options)
       raise ArgumentError, "name_column can't be 'path'" if options[:name_column] == 'path'
-      if !options[:with_advisory_lock] && options[:advisory_lock_timeout_seconds].present?
-        raise ArgumentError, "advisory_lock_timeout_seconds cannot be provided when advisory lock is disabled"
-      end
       if order_is_numeric?
         extend NumericOrderSupport.adapter_for_connection(connection)
       end

spec/closure_tree/parallel_spec.rb

@@ -123,6 +123,7 @@ def work
   it 'fails to deadlock while simultaneously deleting items from the same hierarchy' do
     target = User.find_or_create_by_path((1..200).to_a.map { |ea| ea.to_s })
     emails = target.self_and_ancestors.to_a.map(&:email).shuffle
+    allow(User).to receive(:with_advisory_lock!).with(anything, timeout_seconds: nil) { |_lock_name, &block| block.call }
     Parallel.map(emails, :in_threads => max_threads) do |email|
       ActiveRecord::Base.connection_pool.with_connection do
         User.transaction do