Skip to content

Conversation

@aelligp
Copy link
Collaborator

@aelligp aelligp commented Sep 17, 2025

TODO:

  • add function to interpolate xy to center arrays xy_c. also in 3D -> especially strain
  • consistency with all solvers
  • add functionality to convert stokes, thermal struct to GPU arrays for easy restarting from checkpointing files (CPU arrays)
  • Add restart script and docs
  • Phase ratios based on arrays which are then advected with WENO5 (?) [merged branch pa-phaseratio into this branch (15fe6f1)]

EDIT: 29.10.2025 all issues addressed and working; ready to proceed

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 27.90698% with 310 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/phases/PhaseRatios.jl 0.00% 185 Missing ⚠️
src/Plotting/Plotting.jl 0.00% 32 Missing ⚠️
src/ext/AMDGPU/3D.jl 0.00% 20 Missing ⚠️
src/ext/AMDGPU/2D.jl 0.00% 16 Missing ⚠️
src/ext/CUDA/3D.jl 25.00% 15 Missing ⚠️
src/ext/CUDA/2D.jl 31.25% 11 Missing ⚠️
src/IO/JLD2.jl 66.66% 7 Missing ⚠️
src/rheology/StressUpdate.jl 81.25% 6 Missing ⚠️
src/stokes/StressKernels.jl 81.48% 5 Missing ⚠️
src/variational_stokes/Stokes3D.jl 0.00% 5 Missing ⚠️
... and 2 more

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aelligp
Copy link
Collaborator Author

aelligp commented Sep 18, 2025

@albert-de-montserrat in general the extension functions are in line with other things we do for interpolation e.g., temperature2center!

@aelligp
Copy link
Collaborator Author

aelligp commented Sep 18, 2025

@codecov-ai-reviewer review

1 similar comment
@luraess
Copy link
Member

luraess commented Sep 19, 2025

@codecov-ai-reviewer review

@aelligp aelligp changed the title Fix various things e.g,ε_pl Towards JustRelax v0.5.0 Sep 23, 2025
@aelligp
Copy link
Collaborator Author

aelligp commented Oct 28, 2025

@codecov-ai-reviewer review

@codecov-ai
Copy link

codecov-ai bot commented Oct 28, 2025

On it! We are reviewing the PR and will provide feedback shortly.

@aelligp aelligp mentioned this pull request Oct 29, 2025
@aelligp aelligp merged commit 5435955 into main Oct 29, 2025
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants