ESLint: do not use var, prefer const (#1180)

plata · web-flow · commit 4d87a1765105 · 2020-01-05T13:46:09.000+01:00
diff --git a/.eslintrc.yml b/.eslintrc.yml
@@ -32,6 +32,10 @@ rules:
     - 2
     - unix
   prefer-arrow-callback: 2
+  no-var:
+    - 2
+  prefer-const:
+    - 2
 
 globals:
   include: false
diff --git a/Applications/Games/Age of Empires II HD/Steam/script.js b/Applications/Games/Age of Empires II HD/Steam/script.js
@@ -8,10 +8,10 @@ new SteamScript()
     .appId(221380)
     .postInstall((wine /*, wizard*/) => {
         // skip broken launcher by replacing it with "AoK HD.exe"
-        var installPath = wine.prefixDirectory() + "drive_c/" + wine.programFiles() + "/Steam/steamapps/common/Age2HD/";
-        var launcher = installPath + "Launcher.exe";
+        const installPath = wine.prefixDirectory() + "drive_c/" + wine.programFiles() + "/Steam/steamapps/common/Age2HD/";
+        const launcher = installPath + "Launcher.exe";
         cp(launcher, launcher + ".bak");
         remove(launcher);
-        var aoe = installPath + "AoK HD.exe";
+        const aoe = installPath + "AoK HD.exe";
         lns(aoe, launcher);
     });
diff --git a/Applications/Games/Anno 2070/Local/script.js b/Applications/Games/Anno 2070/Local/script.js
@@ -28,7 +28,7 @@ new LocalInstallerScript()
         new OverrideDLL(wine).withMode("native, builtin", ["winhttp", "msvcrt40", "msvcr100", "crypt32"]).go();
     })
     .postInstall((wine) => {
-        var versionFile = wine.prefixDirectory() + "/drive_c/Ubisoft/Related Designs/ANNO 2070/update/version.txt";
+        const versionFile = wine.prefixDirectory() + "/drive_c/Ubisoft/Related Designs/ANNO 2070/update/version.txt";
         touch(versionFile);
         writeToFile(
             versionFile,
diff --git a/Applications/Games/Enderal/Steam/script.js b/Applications/Games/Enderal/Steam/script.js
@@ -9,7 +9,7 @@ new SteamScript()
     .applicationHomepage("http://sureai.net/games/enderal/")
     .postInstall((wine, wizard) => {
         // the SteamScript has installed Skyrim, now install Enderal
-        var launcher =
+        const launcher =
 			wine.prefixDirectory() + "drive_c/" + wine.programFiles() + "/Steam/steamapps/common/Skyrim/Enderal Launcher.exe";
         new Downloader()
             .wizard(wizard)
diff --git a/Applications/Games/League of Legends/Online/script.js b/Applications/Games/League of Legends/Online/script.js
@@ -19,7 +19,7 @@ new CustomInstallerScript()
     .installationCommand((wizard) => {
         // Select the region and download the setup file
         ////////////////////////////////////////////////
-        var regions = [
+        const regions = [
             "EU West",
             "Latin America North",
             "Latin America South",
@@ -31,9 +31,9 @@ new CustomInstallerScript()
             "North America",
             "Russia"
         ];
-        var selectedRegion = wizard.menu(tr("Select your region:"), regions);
-        var url, sha1;
-        var baseUrl = "https://riotgamespatcher-a.akamaihd.net/ShellInstaller/";
+        const selectedRegion = wizard.menu(tr("Select your region:"), regions);
+        let url, sha1;
+        const baseUrl = "https://riotgamespatcher-a.akamaihd.net/ShellInstaller/";
         switch (selectedRegion.text) {
             case "EU West":
                 url = baseUrl + "EUW/LeagueofLegends_EUW_Installer_2016_11_10.exe";
@@ -76,7 +76,7 @@ new CustomInstallerScript()
                 sha1 = "2d462decf629cab880386407598f9c5ea6db2ef5";
                 break;
         }
-        var setupFile = new Resource()
+        const setupFile = new Resource()
             .wizard(wizard)
             .url(url)
             .checksum(sha1)
@@ -103,8 +103,8 @@ new CustomInstallerScript()
 
         // Create run script to start the right exe
         /////////////////////////////////////////
-        var client = wine.prefixDirectory() + "drive_c/LoL/run.bat";
-        var batContent = "start C:\\LoL\\LeagueClient.exe";
+        const client = wine.prefixDirectory() + "drive_c/LoL/run.bat";
+        const batContent = "start C:\\LoL\\LeagueClient.exe";
         writeToFile(client, batContent);
     })
     .executable("run.bat");
diff --git a/Applications/Games/Lego Rock Raiders/Local/script.js b/Applications/Games/Lego Rock Raiders/Local/script.js
@@ -29,7 +29,7 @@ new LocalInstallerScript()
                 "This game needs a copy protection patch to work. It may be illegal in your country to patch copy protection. You must patch the game yourself."
             )
         );
-        var zipLocation = wine.prefixDirectory() + "drive_c/RockRaidersCodec_490085.zip";
+        const zipLocation = wine.prefixDirectory() + "drive_c/RockRaidersCodec_490085.zip";
         new Downloader()
             .wizard(wizard)
             .url("http://rrubucket.s3.amazonaws.com/RockRaidersCodec_490085.zip")
diff --git a/Applications/Games/Origin/Local (Legacy)/script.js b/Applications/Games/Origin/Local (Legacy)/script.js
@@ -19,7 +19,7 @@ new LocalInstallerScript()
         );
     })
     .postInstall((wine, wizard) => {
-        var originDir = wine.prefixDirectory() + "drive_c/" + wine.programFiles() + "/Origin/";
+        const originDir = wine.prefixDirectory() + "drive_c/" + wine.programFiles() + "/Origin/";
 
         new Downloader()
             .wizard(wizard)
diff --git a/Applications/Games/Origin/Online (Legacy)/script.js b/Applications/Games/Origin/Online (Legacy)/script.js
@@ -20,7 +20,7 @@ new OnlineInstallerScript()
         );
     })
     .postInstall((wine, wizard) => {
-        var originDir = wine.prefixDirectory() + "drive_c/" + wine.programFiles() + "/Origin/";
+        const originDir = wine.prefixDirectory() + "drive_c/" + wine.programFiles() + "/Origin/";
 
         new Downloader()
             .wizard(wizard)
diff --git a/Applications/Games/Rocksmith 2014/Steam/script.js b/Applications/Games/Rocksmith 2014/Steam/script.js
@@ -5,8 +5,8 @@ const SoundDriver = include("engines.wine.plugins.sound_driver");
 const WindowsVersion = include("engines.wine.plugins.windows_version");
 
 function fixIni(ini) {
-    var screenSize = java.awt.Toolkit.getDefaultToolkit().getScreenSize();
-    var content =
+    const screenSize = java.awt.Toolkit.getDefaultToolkit().getScreenSize();
+    const content =
         "[Audio]\n" +
         "EnableMicrophone=1\n" +
         "ExclusiveMode=0\n" +
diff --git a/Applications/Games/Rocksmith/Steam/script.js b/Applications/Games/Rocksmith/Steam/script.js
@@ -5,8 +5,8 @@ const SoundDriver = include("engines.wine.plugins.sound_driver");
 const WindowsVersion = include("engines.wine.plugins.windows_version");
 
 function fixIni(ini) {
-    var screenSize = java.awt.Toolkit.getDefaultToolkit().getScreenSize();
-    var content =
+    const screenSize = java.awt.Toolkit.getDefaultToolkit().getScreenSize();
+    const content =
         "[Audio]\n" +
         "EnableMicrophone=0\n" +
         "LatencyBuffer=4\n" +
diff --git a/Applications/Games/STAR WARS: The Old Republic/Online/script.js b/Applications/Games/STAR WARS: The Old Republic/Online/script.js
@@ -21,12 +21,12 @@ new OnlineInstallerScript()
     })
     .postInstall((wine /*, wizard*/) => {
         //without that the launcher is unable to download the game
-        var path =
+        const path =
 			wine.prefixDirectory() +
 			"drive_c/" +
 			wine.programFiles() +
 			"/Electronic Arts/BioWare/Star Wars - The Old Republic/launcher.settings";
-        var content =
+        const content =
 			'{ "Login": ""\n' +
 			', "LastProduct": ""\n' +
 			', "downloadRate": "0"\n' +
diff --git a/Applications/Games/Space Colony/Local/script.js b/Applications/Games/Space Colony/Local/script.js
@@ -13,7 +13,7 @@ new LocalInstallerScript()
     .wineVersion(getLatestDevelopmentVersion)
     .executable("Space Colony.exe")
     .postInstall(function (wine /*wizard*/) {
-        var patch = new Resource()
+        const patch = new Resource()
             .wizard(this._wizard)
             .url("https://d1ztm8591kdhlc.cloudfront.net/hdpatches/Space_Colony_HD_Update.exe")
             .checksum("c821e5c7035b9b517823466f4cedadd3")
diff --git a/Applications/Games/Tom Clancy's Rainbow Six 3 : Raven Shield/Local (1.0->1.6)/script.js b/Applications/Games/Tom Clancy's Rainbow Six 3 : Raven Shield/Local (1.0->1.6)/script.js
@@ -12,10 +12,10 @@ new LocalInstallerScript()
     .postInstall((wine) => {
         const wizard = wine.wizard();
 
-        var regions = ["France", "England"];
-        var selectedRegion = wizard.menu(tr("Select your region for the patch (1.0 to 1.60)."), regions);
-        var exeName, url, sha1;
-        var originDirectory = wine.prefixDirectory() + "drive_c/users/Public/Documents/";
+        const regions = ["France", "England"];
+        const selectedRegion = wizard.menu(tr("Select your region for the patch (1.0 to 1.60)."), regions);
+        let exeName, url, sha1;
+        const originDirectory = wine.prefixDirectory() + "drive_c/users/Public/Documents/";
 
         switch (selectedRegion.text) {
             case "France":
diff --git a/Applications/Internet/Internet Explorer 6.0/Online/script.js b/Applications/Internet/Internet Explorer 6.0/Online/script.js
@@ -16,20 +16,20 @@ const Regsvr32 = include("engines.wine.plugins.regsvr32");
 const WindowsVersion = include("engines.wine.plugins.windows_version");
 
 new PlainInstaller().withScript(() => {
-    var appsManager = Bean("repositoryManager");
-    var application = appsManager.getApplication([TYPE_ID, CATEGORY_ID, APPLICATION_ID]);
-    var setupWizard = SetupWizard(InstallationType.APPS, "Internet Explorer 6.0", application.getMainMiniature());
+    const appsManager = Bean("repositoryManager");
+    const application = appsManager.getApplication([TYPE_ID, CATEGORY_ID, APPLICATION_ID]);
+    const setupWizard = SetupWizard(InstallationType.APPS, "Internet Explorer 6.0", application.getMainMiniature());
 
     setupWizard.presentation("Internet Explorer 6.0", "Microsoft", "http://www.microsoft.com", "Quentin PÂRIS");
 
-    var setupFile = new Resource()
+    const setupFile = new Resource()
         .wizard(setupWizard)
         .url("http://files.playonlinux.com/ie/6.0/ie60.exe")
         .checksum("8e483db28ff01a7cabd39147ab6c59753ea1f533")
         .name("ie60.exe")
         .get();
 
-    var wine = new Wine()
+    const wine = new Wine()
         .wizard(setupWizard)
         .prefix("InternetExplorer6", "upstream", "x86", getLatestStableVersion(setupWizard, "x86"))
         .create();
@@ -89,7 +89,7 @@ new PlainInstaller().withScript(() => {
         ])
         .go();
 
-    var librariesToRegister = [
+    const librariesToRegister = [
         "actxprxy.dll",
         "browseui.dll",
         "browsewm.dll",
@@ -144,8 +144,8 @@ new PlainInstaller().withScript(() => {
         "wshom.ocx"
     ];
 
-    var progressBar = setupWizard.progressBar(tr("Please wait..."));
-    var i = 1;
+    const progressBar = setupWizard.progressBar(tr("Please wait..."));
+    let i = 1;
     librariesToRegister.forEach(dll => {
         progressBar.setProgressPercentage((i * 100) / librariesToRegister.length);
         progressBar.setText(tr("Installing {0}...", dll));
diff --git a/Applications/Internet/Internet Explorer 7.0/Online/script.js b/Applications/Internet/Internet Explorer 7.0/Online/script.js
@@ -13,13 +13,13 @@ const Regsvr32 = include("engines.wine.plugins.regsvr32");
 const WindowsVersion = include("engines.wine.plugins.windows_version");
 
 new PlainInstaller().withScript(() => {
-    var appsManager = Bean("repositoryManager");
-    var application = appsManager.getApplication([TYPE_ID, CATEGORY_ID, APPLICATION_ID]);
-    var setupWizard = SetupWizard(InstallationType.APPS, "Internet Explorer 7.0", application.getMainMiniature());
+    const appsManager = Bean("repositoryManager");
+    const application = appsManager.getApplication([TYPE_ID, CATEGORY_ID, APPLICATION_ID]);
+    const setupWizard = SetupWizard(InstallationType.APPS, "Internet Explorer 7.0", application.getMainMiniature());
 
     setupWizard.presentation("Internet Explorer 7.0", "Microsoft", "http://www.microsoft.com", "Quentin PÂRIS");
 
-    var wine = new Wine()
+    const wine = new Wine()
         .wizard(setupWizard)
         .prefix("InternetExplorer7", "upstream", "x86", getLatestStableVersion(setupWizard, "x86"))
         .create();
@@ -53,7 +53,7 @@ new PlainInstaller().withScript(() => {
         }
     );
 
-    var languages = [
+    const languages = [
         "Arabic",
         "Chinese (Simplified)",
         "Chinese (Traditional, Taiwan)",
@@ -79,10 +79,10 @@ new PlainInstaller().withScript(() => {
         "Swedish",
         "Turkish"
     ];
-    var selectedLanguage = setupWizard.menu(tr("Which language version would you like to install?"), languages);
-    var setupLanguage = languages[selectedLanguage.index];
+    const selectedLanguage = setupWizard.menu(tr("Which language version would you like to install?"), languages);
+    const setupLanguage = languages[selectedLanguage.index];
 
-    var ie7link, ie7installer, ie7md5;
+    let ie7link, ie7installer, ie7md5;
 
     switch (setupLanguage) {
         case "English":
@@ -231,7 +231,7 @@ new PlainInstaller().withScript(() => {
             break;
     }
 
-    var setupFile = new Resource()
+    const setupFile = new Resource()
         .wizard(setupWizard)
         .url(ie7link)
         .checksum(ie7md5)
@@ -247,7 +247,7 @@ new PlainInstaller().withScript(() => {
 
     wine.wait();
 
-    var librairiesToRegister = [
+    const librairiesToRegister = [
         "actxprxy.dll",
         "browseui.dll",
         "browsewm.dll",
@@ -302,8 +302,8 @@ new PlainInstaller().withScript(() => {
         "wshom.ocx"
     ];
 
-    var progressBar = setupWizard.progressBar("Please wait...");
-    var i = 1;
+    const progressBar = setupWizard.progressBar("Please wait...");
+    let i = 1;
     librairiesToRegister.forEach(dll => {
         progressBar.setProgressPercentage((i * 100) / librairiesToRegister.length);
         progressBar.setText(tr("Installing {0}...", dll));
diff --git a/Engines/Wine/Engine/Implementation/script.js b/Engines/Wine/Engine/Implementation/script.js
@@ -423,7 +423,7 @@ module.default = class WineEngine {
             processBuilder.directory(new FileClass(driveC));
         }
 
-        var environment = processBuilder.environment();
+        const environment = processBuilder.environment();
         // disable winemenubuilder (we manage our own shortcuts)
         environment.put("WINEDLLOVERRIDES", "winemenubuilder.exe=d");
         environment.put("WINEPREFIX", workingContainerDirectory);
diff --git a/Engines/Wine/QuickScript/Online Installer Script/script.js b/Engines/Wine/QuickScript/Online Installer Script/script.js
@@ -35,8 +35,8 @@ module.default = class OnlineInstallerScript extends InstallerScript {
         }
 
         // get correct extension depending on URL
-        var extension = this._url.split('.').pop();
-        var installationFile = createTempFile(extension);
+        const extension = this._url.split('.').pop();
+        const installationFile = createTempFile(extension);
 
         new Downloader()
             .wizard(wizard)
diff --git a/Engines/Wine/Settings/GLSL/script.js b/Engines/Wine/Settings/GLSL/script.js
@@ -24,7 +24,7 @@ module.default = class GLSLSetting {
     getCurrentOption(container) {
         const wine = new Wine().prefix(container);
 
-        var currentValue = new Regedit(wine).fetchValue([
+        const currentValue = new Regedit(wine).fetchValue([
             "HKEY_CURRENT_USER",
             "Software",
             "Wine",
diff --git a/Engines/Wine/Settings/mouse warp override/script.js b/Engines/Wine/Settings/mouse warp override/script.js
@@ -24,7 +24,7 @@ module.default = class MouseWarpOverrideSetting {
     getCurrentOption(container) {
         const wine = new Wine().prefix(container);
 
-        var currentValue = new Regedit(wine).fetchValue([
+        const currentValue = new Regedit(wine).fetchValue([
             "HKEY_CURRENT_USER",
             "Software",
             "Wine",
diff --git a/Engines/Wine/Settings/multisampling/script.js b/Engines/Wine/Settings/multisampling/script.js
@@ -24,7 +24,7 @@ module.default = class MultisamplingSetting {
     getCurrentOption(container) {
         const wine = new Wine().prefix(container);
 
-        var currentValue = new Regedit(wine).fetchValue([
+        const currentValue = new Regedit(wine).fetchValue([
             "HKEY_CURRENT_USER",
             "Software",
             "Wine",
diff --git a/Engines/Wine/Settings/offscreen rendering mode/script.js b/Engines/Wine/Settings/offscreen rendering mode/script.js
@@ -24,7 +24,7 @@ module.default = class OffscreenRenderingModeSetting {
     getCurrentOption(container) {
         const wine = new Wine().prefix(container);
 
-        var currentValue = new Regedit(wine).fetchValue([
+        const currentValue = new Regedit(wine).fetchValue([
             "HKEY_CURRENT_USER",
             "Software",
             "Wine",
diff --git a/Engines/Wine/Settings/render target lock mode/script.js b/Engines/Wine/Settings/render target lock mode/script.js
@@ -24,7 +24,7 @@ module.default = class RenderTargetModeLockSetting {
     getCurrentOption(container) {
         const wine = new Wine().prefix(container);
 
-        var currentValue = new Regedit(wine).fetchValue([
+        const currentValue = new Regedit(wine).fetchValue([
             "HKEY_CURRENT_USER",
             "Software",
             "Wine",
diff --git a/Engines/Wine/Settings/strict draw ordering/script.js b/Engines/Wine/Settings/strict draw ordering/script.js
@@ -24,7 +24,7 @@ module.default = class StrictDrawOrderingSetting {
     getCurrentOption(container) {
         const wine = new Wine().prefix(container);
 
-        var currentValue = new Regedit(wine).fetchValue([
+        const currentValue = new Regedit(wine).fetchValue([
             "HKEY_CURRENT_USER",
             "Software",
             "Wine",
diff --git a/Engines/Wine/Shortcuts/Wine/script.js b/Engines/Wine/Shortcuts/Wine/script.js
@@ -182,7 +182,7 @@ module.default = class WineShortcut {
 
         const myEnv = { WINEDEBUG: "-all" };
         if (typeof this._environment !== "undefined") {
-            var envJSON = JSON.parse(this._environment);
+            const envJSON = JSON.parse(this._environment);
             Object.keys(envJSON).forEach((key) => {
                 myEnv[key] = envJSON[key];
             });
diff --git a/Engines/Wine/Tools/Wine Terminal Opener/script.js b/Engines/Wine/Tools/Wine Terminal Opener/script.js
@@ -10,18 +10,18 @@ module.default = class WineTerminalOpenerTool {
     }
 
     run(container) {
-        var wine = new Wine()
+        const wine = new Wine()
             .prefix(container);
 
-        var environment = [];
+        const environment = [];
 
         environment["WINEPREFIX"] = wine.prefixDirectory();
         environment["PATH"] = wine.binPath() + ":$PATH";
         environment["LD_LIBRARY_PATH"] = Bean("propertyReader").getProperty("application.environment.ld");
         environment["TERM"] = "xterm";
 
-        var wineEnginesDirectory = Bean("propertyReader").getProperty("application.user.engines") + "/wine";
-        var winePath = wine.binPath().substring(0, wine.binPath().length - 5); //trim /bin/
+        const wineEnginesDirectory = Bean("propertyReader").getProperty("application.user.engines") + "/wine";
+        const winePath = wine.binPath().substring(0, wine.binPath().length - 5); //trim /bin/
 
         if (wine.architecture() == "amd64") {
             environment["LD_LIBRARY_PATH"] =
diff --git a/Engines/Wine/Verbs/luna/script.js b/Engines/Wine/Verbs/luna/script.js
diff --git a/Engines/Wine/Verbs/quartz/script.js b/Engines/Wine/Verbs/quartz/script.js

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ new LocalInstallerScript()`
`29`	`29`	`"This game needs a copy protection patch to work. It may be illegal in your country to patch copy protection. You must patch the game yourself."`
`30`	`30`	`)`
`31`	`31`	`);`
`32`		`- var zipLocation = wine.prefixDirectory() + "drive_c/RockRaidersCodec_490085.zip";`
	`32`	`+ const zipLocation = wine.prefixDirectory() + "drive_c/RockRaidersCodec_490085.zip";`
`33`	`33`	`new Downloader()`
`34`	`34`	`.wizard(wizard)`
`35`	`35`	`.url("http://rrubucket.s3.amazonaws.com/RockRaidersCodec_490085.zip")`