Fix uninitialized build warning (#6321)

MaximSmolskiy · web-flow · commit 79008f4a8794 · 2025-08-30T14:39:08.000+02:00
* Fix uninitialized build warning

* Fix review issue

* Fix
diff --git a/recognition/include/pcl/recognition/impl/implicit_shape_model.hpp b/recognition/include/pcl/recognition/impl/implicit_shape_model.hpp
@@ -171,7 +171,7 @@ pcl::features::ISMVoteList<PointT>::findStrongestPeaks (
   {
     // find best peak with taking into consideration peak flags
     double best_density = -1.0;
-    Eigen::Vector3f strongest_peak;
+    Eigen::Vector3f strongest_peak = Eigen::Vector3f::Constant (-1);
     int best_peak_ind (-1);
     int peak_counter (0);
     for (int i = 0; i < NUM_INIT_PTS; i++)
@@ -188,7 +188,8 @@ pcl::features::ISMVoteList<PointT>::findStrongestPeaks (
       }
     }
 
-    if( peak_counter == 0 )
+    if( best_density == -1.0 || strongest_peak == Eigen::Vector3f::Constant (-1) ||
+        best_peak_ind == -1 || peak_counter == 0 )
       break;// no peaks
 
     pcl::ISMPeak peak;

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ pcl::features::ISMVoteList<PointT>::findStrongestPeaks (`
`171`	`171`	`{`
`172`	`172`	`// find best peak with taking into consideration peak flags`
`173`	`173`	`double best_density = -1.0;`
`174`		`- Eigen::Vector3f strongest_peak;`
	`174`	`+ Eigen::Vector3f strongest_peak = Eigen::Vector3f::Constant (-1);`
`175`	`175`	`int best_peak_ind (-1);`
`176`	`176`	`int peak_counter (0);`
`177`	`177`	`for (int i = 0; i < NUM_INIT_PTS; i++)`
`@@ -188,7 +188,8 @@ pcl::features::ISMVoteList<PointT>::findStrongestPeaks (`
`188`	`188`	`}`
`189`	`189`	`}`
`190`	`190`
`191`		`- if( peak_counter == 0 )`
	`191`	`+ if( best_density == -1.0 \|\| strongest_peak == Eigen::Vector3f::Constant (-1) \|\|`
	`192`	`+ best_peak_ind == -1 \|\| peak_counter == 0 )`
`192`	`193`	`break;// no peaks`
`193`	`194`
`194`	`195`	`pcl::ISMPeak peak;`