-
Notifications
You must be signed in to change notification settings - Fork 32
chore: proguard support #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,071
−12
Merged
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
00d4e33
chore: initial proguard support
marandaneto fb0d3a4
fix
marandaneto 162a3a3
add comment
marandaneto 2f0e554
Merge branch 'main' into chore/progaurd-support
marandaneto 782cde2
Merge branch 'main' into chore/progaurd-support
marandaneto 67109f1
remove
marandaneto 4ddff47
draft
marandaneto 75245fb
fix
marandaneto 9255985
fix
marandaneto bd1373f
fix
marandaneto c95c3d1
fixes
marandaneto fe3589b
fixes
marandaneto f2f4f3a
fix
marandaneto 2cdc37b
Merge branch 'main' into chore/progaurd-support
marandaneto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -203,6 +203,27 @@ public open class PostHogConfig( | |
| * Configuration for PostHog Error Tracking feature. | ||
| */ | ||
| public val errorTrackingConfig: PostHogErrorTrackingConfig = PostHogErrorTrackingConfig(), | ||
|
|
||
| /** | ||
| * The release identifier used to identify the correct proguard mappings (mapping.txt) | ||
| * in order to make minified stack traces into human readable stack traces | ||
| * | ||
| * If not set, this will be automatically set to a composed version of your app eg: | ||
| * [email protected]+1 | ||
| * Where: | ||
| * 'com.posthog.mobile' is the applicationId | ||
| * '1.0.0' is the versionName | ||
| * '1' is the versionCode | ||
| * | ||
| * It can also be a git sha, the hash of the mapping file, etc | ||
| * it should be the very same identifier (map-id) used to upload the mapping to the PostHog servers | ||
| * | ||
| * Soon a Gradle plugin will be provided to do the injection of this identifier automatically | ||
| * | ||
| * CLI command example: | ||
| * posthog-cli exp proguard upload --path "app/build/outputs/mapping/release/mapping.txt" --map-id "[email protected]+1" | ||
| */ | ||
| public var releaseIdentifier: String? = null, | ||
| ) { | ||
| @PostHogInternal | ||
| public var logger: PostHogLogger = PostHogNoOpLogger() | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by default this is stripped out from the apk