Skip to content

Commit ca0e035

Browse files
committed
cmd/link: remove support for windows/arm relocations
The windows/arm port is no longer supported. We can remove the related code from cmd/link/internal/arm. For golang#71671 Change-Id: I00de1231482cc2f28ec5fc9dc62e81f0ba3fe481 Reviewed-on: https://go-review.googlesource.com/c/go/+/703778 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: Than McIntosh <[email protected]> Reviewed-by: Michael Knyszek <[email protected]>
1 parent 17a0fab commit ca0e035

File tree

1 file changed

+1
-30
lines changed
  • src/cmd/link/internal/arm

1 file changed

+1
-30
lines changed

src/cmd/link/internal/arm/asm.go

Lines changed: 1 addition & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -334,36 +334,7 @@ func machoreloc1(*sys.Arch, *ld.OutBuf, *loader.Loader, loader.Sym, loader.ExtRe
334334
}
335335

336336
func pereloc1(arch *sys.Arch, out *ld.OutBuf, ldr *loader.Loader, s loader.Sym, r loader.ExtReloc, sectoff int64) bool {
337-
rs := r.Xsym
338-
rt := r.Type
339-
340-
if ldr.SymDynid(rs) < 0 {
341-
ldr.Errorf(s, "reloc %d (%s) to non-coff symbol %s type=%d (%s)", rt, sym.RelocName(arch, rt), ldr.SymName(rs), ldr.SymType(rs), ldr.SymType(rs))
342-
return false
343-
}
344-
345-
out.Write32(uint32(sectoff))
346-
out.Write32(uint32(ldr.SymDynid(rs)))
347-
348-
var v uint32
349-
switch rt {
350-
default:
351-
// unsupported relocation type
352-
return false
353-
354-
case objabi.R_DWARFSECREF:
355-
v = ld.IMAGE_REL_ARM_SECREL
356-
357-
case objabi.R_ADDR:
358-
v = ld.IMAGE_REL_ARM_ADDR32
359-
360-
case objabi.R_PEIMAGEOFF:
361-
v = ld.IMAGE_REL_ARM_ADDR32NB
362-
}
363-
364-
out.Write16(uint16(v))
365-
366-
return true
337+
return false
367338
}
368339

369340
// sign extend a 24-bit integer.

0 commit comments

Comments
 (0)