Skip to content

Commit a6476f6

Browse files
committed
Fixes tests to work with changes and name_exceptions.csv
1 parent 3591b07 commit a6476f6

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

meetup_ballot/ballot.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ def read_name_exceptions(name_exceptions_csv):
9393
""" Read member names from csv files"""
9494
member_ids = []
9595
with open(name_exceptions_csv, newline='') as name_exceptions:
96-
reader = csv.reader(name_exceptions, delimiter=' ')
96+
reader = csv.reader(name_exceptions, delimiter=',')
9797
for row in reader:
9898
member_ids.append(row[0])
9999
return member_ids

tests/test_ballot.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ def test_member_name():
88
None,
99
'Word',
1010
'A BC',
11-
'Uncle Bob'
11+
'Uncle Bob',
12+
'ExceptionMemberName'
1213
]
1314

1415
actual = [ballot.does_member_name_looks_like_spam(name)
@@ -18,7 +19,8 @@ def test_member_name():
1819
True,
1920
True,
2021
True,
21-
False
22+
False,
23+
True
2224
]
2325
eq_(expected, actual)
2426

@@ -29,16 +31,17 @@ def test_filter_spam_members(_):
2931
None,
3032
'Word',
3133
'A BC',
32-
'Uncle Bob'
34+
'Uncle Bob',
35+
'ExceptionMemberName'
3336
]
3437
mocked_client = MagicMock(
3538
get_member_name=MagicMock(
3639
side_effect=names
3740
)
3841
)
39-
actual = ballot.filter_spam_members([1, 2, 3, 4], mocked_client)
42+
actual = ballot.filter_spam_members([1, 2, 3, 4, 5], mocked_client, 'name_exceptions.csv')
4043

41-
eq_([4], actual)
44+
eq_([4, 5], actual)
4245

4346

4447
@patch('meetup_ballot.ballot.filter_spam_members')
@@ -57,7 +60,7 @@ def test_run_ballet(mocked_client_cls, mocked_env, mocked_spam):
5760
mocked_env.return_value = 101
5861
mocked_spam.return_value = ['a', 'b', 'c']
5962

60-
actual_attending_number = ballot.run_ballot('key', 'url')
63+
actual_attending_number = ballot.run_ballot('key', 'url', 'name_exceptions.csv')
6164

6265
eq_(2, actual_attending_number)
6366

0 commit comments

Comments
 (0)