Skip to content

Commit 973a3d2

Browse files
authored
Merge branch 'master' into on_scheduled_event_delete
2 parents 5a2581e + b22eb58 commit 973a3d2

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ These changes are available on the `master` branch, but have not yet been releas
2727
([#2993](https://github.com/Pycord-Development/pycord/pull/2993))
2828
- Fixed breaking change in `ui.Select` Generic typing by adding default values to
2929
TypeVars. ([#3002](https://github.com/Pycord-Development/pycord/pull/3002))
30+
- Fixed `View`'s `disable_on_timeout` not working in private (DM) channels.
31+
([#3016](https://github.com/Pycord-Development/pycord/pull/3016))
3032

3133
### Deprecated
3234

discord/ui/view.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@
5555
from ..components import TextDisplay as TextDisplayComponent
5656
from ..components import Thumbnail as ThumbnailComponent
5757
from ..components import _component_factory
58+
from ..enums import ChannelType
5859
from ..utils import find
5960
from .core import ItemInterface
6061
from .item import ItemCallbackType, ViewItem
@@ -303,7 +304,11 @@ async def on_timeout(self) -> None:
303304
if self.disable_on_timeout:
304305
self.disable_all_items()
305306

306-
if not self._message or self._message.flags.ephemeral:
307+
if (
308+
not self._message
309+
or self._message.flags.ephemeral
310+
or (self._message.channel.type == ChannelType.private)
311+
):
307312
message = self.parent
308313
else:
309314
message = self.message

0 commit comments

Comments
 (0)