add --max-count

Author: SandrineP

src/subcommand/log_subcommand.cpp

@@ -13,7 +13,7 @@ log_subcommand::log_subcommand(const libgit2_object&, CLI::App& app)
     auto *sub = app.add_subcommand("log", "Shows commit logs");
 
     sub->add_flag("--format", m_format_flag, "Pretty-print the contents of the commit logs in a given format, where <format> can be one of full and fuller");
-    // sub->add_flag("-n,--max-count", m_max_count_flag, "Limit the output to <number> commits.");
+    sub->add_option("-n,--max-count", m_max_count_flag, "Limit the output to <number> commits.");
     // sub->add_flag("--oneline", m_oneline_flag, "This is a shorthand for --pretty=oneline --abbrev-commit used together.");
 
     sub->callback([this]() { this->run(); });
@@ -88,11 +88,13 @@ void log_subcommand::run()
     git_revwalk_new(&walker, repo);
     git_revwalk_push_head(walker);
 
+    std::size_t i=0;
     git_oid commit_oid;
-    while (!git_revwalk_next(&commit_oid, walker))
+    while (!git_revwalk_next(&commit_oid, walker) && i<m_max_count_flag)
     {
         commit_wrapper commit = repo.find_commit(commit_oid);
         print_commit(commit, m_format_flag);
+        i+=1;
     }
 
     git_revwalk_free(walker);

src/subcommand/log_subcommand.hpp

@@ -1,6 +1,8 @@
 #pragma once
 
 #include <CLI/CLI.hpp>
+#include <cstddef>
+#include <limits>
 
 #include "../utils/common.hpp"
 
@@ -14,6 +16,6 @@ class log_subcommand
 
 private:
     std::string m_format_flag;
-    // int m_max_count_flag;
+    int m_max_count_flag=std::numeric_limits<int>::max();
     // bool m_oneline_flag = false;
 };

test/test_log.py

@@ -34,3 +34,21 @@ def test_log(xtl_clone, git_config, git2cpp_path, tmp_path, monkeypatch, format_
             assert "Date" not in p_log.stdout
         else:
             assert "CommitDate" in p_log.stdout
+
+
+@pytest.mark.parametrize("max_count_flag", ["", "-n", "--max-count"])
+def test_max_count(xtl_clone, git_config, git2cpp_path, tmp_path, monkeypatch, max_count_flag):
+    assert (tmp_path / "xtl").exists()
+    xtl_path = tmp_path / "xtl"
+
+    cmd_log = [git2cpp_path, 'log']
+    if max_count_flag != "":
+        cmd_log.append(max_count_flag)
+        cmd_log.append("2")
+    p_log = subprocess.run(cmd_log, capture_output=True, cwd=xtl_path, text=True)
+    assert p_log.returncode == 0
+
+    if max_count_flag == "":
+        assert p_log.stdout.count("Author") > 2
+    else:
+        assert p_log.stdout.count("Author") == 2