Editable preferences for subreddit combination actions

Author: mrboisvert

src/main/java/org/quantumbadger/redreader/common/PrefsUtility.java

@@ -37,6 +37,7 @@
 import org.quantumbadger.redreader.reddit.PostSort;
 import org.quantumbadger.redreader.reddit.UserCommentSort;
 import org.quantumbadger.redreader.reddit.api.RedditAPICommentAction;
+import org.quantumbadger.redreader.reddit.api.RedditAPISubredditCombinationAction;
 import org.quantumbadger.redreader.reddit.api.RedditPostActions;
 import org.quantumbadger.redreader.reddit.things.InvalidSubredditNameException;
 import org.quantumbadger.redreader.reddit.things.SubredditCanonicalId;
@@ -1789,6 +1790,24 @@ public static String pref_reddit_client_id_override() {
 		return valueTrimmed;
 	}
 
+	public static EnumSet<RedditAPISubredditCombinationAction.SubredditCombinationAction>
+			pref_menus_subreddit_combination_context_items() {
+		final Set<String> strings = getStringSet(
+				R.string.pref_menus_subreddit_combinations_context_items_key,
+				R.array.pref_menus_subreddit_combinations_context_items_return);
+
+		final EnumSet<RedditAPISubredditCombinationAction.SubredditCombinationAction> result
+				= EnumSet.noneOf(
+						RedditAPISubredditCombinationAction.SubredditCombinationAction.class);
+
+		for(final String s : strings) {
+			result.add(RedditAPISubredditCombinationAction.SubredditCombinationAction.valueOf(
+					StringUtils.asciiUppercase(s)));
+		}
+
+		return result;
+	}
+
 	private static final String REDDIT_USER_AGREEMENT_PREF = "accepted_reddit_user_agreement";
 	private static final int REDDIT_USER_AGREEMENT_DECLINED = -1;
 	private static final int REDDIT_USER_AGREEMENT_APRIL_2023 = 1;

src/main/java/org/quantumbadger/redreader/reddit/api/RedditAPISubredditCombinationAction.java

@@ -52,6 +52,13 @@ public static void showActionMenu(
 			final AppCompatActivity activity,
 			List<String> subredditNames) {
 
+		final EnumSet<SubredditCombinationAction> itemPref
+				= PrefsUtility.pref_menus_subreddit_combination_context_items();
+
+		if(itemPref.isEmpty()) {
+			return;
+		}
+
 		final RedditAccount user =
 				RedditAccountManager.getInstance(activity).getDefaultAccount();
 

src/main/res/values/arrays.xml

@@ -1328,4 +1328,11 @@
 		<item>@string/pref_behaviour_post_tap_action_title_comments</item>
 	</string-array>
 
+	<!-- 2024-11-28 -->
+	<string-array name="pref_menus_subreddit_combinations_context_items">
+	</string-array>
+
+	<string-array name="pref_menus_subreddit_combinations_context_items_return">
+	</string-array>
+
 </resources>

src/main/res/values/strings.xml

@@ -1908,4 +1908,8 @@
 	<string name="error_401_message">Reddit says that you are not logged in or have provided invalid credentials.</string>
 	<string name="error_400_title">Bad Request</string>
 	<string name="error_400_message">Reddit says that you have submitted something invalid.</string>
+
+	<string name="pref_menus_subreddit_combinations_header">Subreddit Combinations</string>
+	<string name="pref_menus_subreddit_combinations_context_items_key" translatable="false">pref_menus_subreddit_combination_context_items</string>
+	<string name="pref_menus_subreddit_combinations_context_items_title">Action menu items</string>
 </resources>

src/main/res/xml/prefs_menus.xml

@@ -132,4 +132,16 @@
 
 	</PreferenceCategory>
 
+	<PreferenceCategory android:title="@string/pref_menus_subreddit_combinations_header">
+
+		<MultiSelectListPreference
+				android:dialogTitle="@string/pref_menus_subreddit_combinations_context_items_title"
+				android:key="@string/pref_menus_subreddit_combinations_context_items_key"
+				android:title="@string/pref_menus_subreddit_combinations_context_items_title"
+				android:entries="@array/pref_menus_subreddit_combinations_context_items"
+				android:entryValues="@array/pref_menus_subreddit_combinations_context_items_return"
+				android:defaultValue="@array/pref_menus_subreddit_combinations_context_items_return" />
+
+	</PreferenceCategory>
+
 </PreferenceScreen>