Skip to content

Conversation

@AviralGoelAMD
Copy link
Collaborator

Proposed changes

For FP8/BF8 custom data types, we need to use type_convert instead of static_cast to properly convert the data before printing.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

tenpercent
tenpercent previously approved these changes Oct 29, 2025
@tenpercent
Copy link
Contributor

would you like to add some tests?

@AviralGoelAMD
Copy link
Collaborator Author

would you like to add some tests?

added

@tenpercent tenpercent self-requested a review October 30, 2025 20:18
tenpercent
tenpercent previously approved these changes Oct 30, 2025
Copy link
Contributor

@tenpercent tenpercent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AviralGoelAMD AviralGoelAMD merged commit 45be741 into develop Nov 1, 2025
49 checks passed
@AviralGoelAMD AviralGoelAMD deleted the aviralgoel/tile_window branch November 1, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants