Qt: stop all game list threads before updating

Author: Megamouse

rpcs3/rpcs3qt/game_list_frame.cpp

@@ -229,6 +229,11 @@ void game_list_frame::LoadSettings()
 }
 
 game_list_frame::~game_list_frame()
+{
+	StopAllThreads();
+}
+
+void game_list_frame::StopAllThreads()
 {
 	WaitAndAbortSizeCalcThreads();
 	WaitAndAbortRepaintThreads();

rpcs3/rpcs3qt/game_list_frame.h

@@ -35,6 +35,8 @@ class game_list_frame : public custom_dock_widget
 	explicit game_list_frame(std::shared_ptr<gui_settings> gui_settings, std::shared_ptr<emu_settings> emu_settings, std::shared_ptr<persistent_settings> persistent_settings, QWidget* parent = nullptr);
 	~game_list_frame();
 
+	void StopAllThreads();
+
 	/** Refresh the gamelist with/without loading game data from files. Public so that main frame can refresh after vfs or install */
 	void Refresh(const bool from_drive = false, const std::vector<std::string>& serials_to_remove_from_yml = {}, const bool scroll_after = true);
 

rpcs3/rpcs3qt/main_window.cpp

@@ -307,6 +307,13 @@ bool main_window::Init([[maybe_unused]] bool with_cli_boot)
 			ui->menuBar->cornerWidget()->setVisible(update_available);
 		}
 	});
+	connect(&m_updater, &update_manager::signal_about_to_terminate, this, [this]()
+	{
+		if (m_game_list_frame)
+		{
+			m_game_list_frame->StopAllThreads();
+		}
+	});
 
 #ifdef RPCS3_UPDATE_SUPPORTED
 	if (const auto update_value = m_gui_settings->GetValue(gui::m_check_upd_start).toString(); update_value != gui::update_off)

rpcs3/rpcs3qt/update_manager.cpp

@@ -755,6 +755,8 @@ bool update_manager::handle_rpcs3(const QByteArray& data, bool auto_accept)
 		m_gui_settings->sync(); // Make sure to sync before terminating RPCS3
 	}
 
+	Q_EMIT signal_about_to_terminate();
+
 	Emu.GracefulShutdown(false);
 	Emu.CleanUp();
 

rpcs3/rpcs3qt/update_manager.h

@@ -45,4 +45,5 @@ class update_manager final :  public QObject
 
 Q_SIGNALS:
 	void signal_update_available(bool update_available);
+	void signal_about_to_terminate();
 };