Remove hardcoded user_ids and org_ids from users.json (#353)

Now that we're using stubbing in the tests instead of this `users.json`
fixture file, the only remaining uses of it were for the "bypass OAuth"
mode. Also, since we're now managing user roles within editor-api
(instead of in the user info API), it's a lot less obvious the users in
the fixture file are actually useful even for the "bypass OAuth" mode. I
think it makes the code clearer to remove the fixture file and hard-code
some user data for the "bypass OAuth" mode.

Closes #308

Author: floehopper

lib/hydra_public_api_client.rb

@@ -12,11 +12,7 @@ def fetch_oauth_user(...)
   end
 
   def fetch_oauth_user(token:)
-    if bypass_oauth?
-      users = stubbed_data['users']
-      user = users.detect { |attr| attr['id'] == '00000000-0000-0000-0000-000000000000' }
-      return user
-    end
+    return stubbed_user if bypass_oauth?
 
     response = get('userinfo', {}, { Authorization: "Bearer #{token}" })
     response.body.to_h
@@ -31,11 +27,25 @@ def bypass_oauth?
     ENV.fetch('BYPASS_OAUTH', nil) == 'true'
   end
 
-  def stubbed_data
-    path = Rails.root.join('spec/fixtures/users.json')
-    json = File.read(path)
-
-    JSON.parse(json)
+  def stubbed_user
+    {
+      id: '00000000-0000-0000-0000-000000000000',
+      email: '[email protected]',
+      username: nil,
+      parentalEmail: nil,
+      name: 'School Owner',
+      nickname: 'Owner',
+      country: 'United Kingdom',
+      country_code: 'GB',
+      postcode: nil,
+      dateOfBirth: nil,
+      verifiedAt: '2024-01-01T12:00:00.000Z',
+      createdAt: '2024-01-01T12:00:00.000Z',
+      updatedAt: '2024-01-01T12:00:00.000Z',
+      discardedAt: nil,
+      lastLoggedInAt: '2024-01-01T12:00:00.000Z',
+      roles: ''
+    }
   end
 
   def conn

lib/user_info_api_client.rb

@@ -5,20 +5,9 @@ class UserInfoApiClient
   API_KEY = ENV.fetch('USERINFO_API_KEY', '1234')
 
   class << self
-    def fetch_by_email(user_email)
-      return if user_email.blank?
-
-      return stubbed_by_email(user_email) if bypass_oauth?
-
-      response = conn.get { |r| r.url "/users/#{user_email}" }
-      return if response.body.blank?
-
-      transform_result(response.body.fetch('user', []))
-    end
-
     def fetch_by_ids(user_ids)
       return [] if user_ids.blank?
-      return stubbed_by_ids(user_ids) if bypass_oauth?
+      return stubbed_users(user_ids) if bypass_oauth?
 
       response = conn.get do |r|
         r.url '/users'
@@ -51,21 +40,27 @@ def conn
       end
     end
 
-    def stubbed_data
-      path = Rails.root.join('spec/fixtures/users.json')
-      json = File.read(path)
-
-      JSON.parse(json)
-    end
-
-    def stubbed_by_email(user_email)
-      data = stubbed_data.fetch('users', nil).find { |d| d['email'] == user_email }
-      transform_result(data)
-    end
-
-    def stubbed_by_ids(user_ids)
-      data = stubbed_data.fetch('users', nil).find_all { |d| user_ids.include?(d['id']) }
-      transform_result(data)
+    def stubbed_users(user_ids)
+      user_ids.map do |user_id|
+        {
+          id: user_id,
+          email: "user-#{user_id}@example.com",
+          username: nil,
+          parentalEmail: nil,
+          name: 'School Owner',
+          nickname: 'Owner',
+          country: 'United Kingdom',
+          country_code: 'GB',
+          postcode: nil,
+          dateOfBirth: nil,
+          verifiedAt: '2024-01-01T12:00:00.000Z',
+          createdAt: '2024-01-01T12:00:00.000Z',
+          updatedAt: '2024-01-01T12:00:00.000Z',
+          discardedAt: nil,
+          lastLoggedInAt: '2024-01-01T12:00:00.000Z',
+          roles: ''
+        }
+      end
     end
   end
 end