Merge pull request #20 from RedisGraph/internal.external.latency.diff

Added ratio/absoute difference between external and internal latency summaries

Author: filipecosta90

redisgraph-bechmark-go.go

@@ -178,8 +178,13 @@ func main() {
 	testResult.FillDurationInfo(startTime, endTime, duration)
 	testResult.BenchmarkFullyRun = totalCommands == *numberRequests
 	testResult.IssuedCommands = totalCommands
-	testResult.OverallGraphInternalLatencies = GetOverallLatencies(queries, serverSide_PerQuery_GraphInternalTime_OverallLatencies, serverSide_AllQueries_GraphInternalTime_OverallLatencies)
-	testResult.OverallClientLatencies = GetOverallLatencies(queries, clientSide_PerQuery_OverallLatencies, clientSide_AllQueries_OverallLatencies)
+	overallGraphInternalLatencies, internalLatencyMap := GetOverallLatencies(queries, serverSide_PerQuery_GraphInternalTime_OverallLatencies, serverSide_AllQueries_GraphInternalTime_OverallLatencies)
+	overallClientLatencies, clientLatencyMap := GetOverallLatencies(queries, clientSide_PerQuery_OverallLatencies, clientSide_AllQueries_OverallLatencies)
+	relativeLatencyDiff, absoluteLatencyDiff := GenerateInternalExternalRatioLatencies(internalLatencyMap, clientLatencyMap)
+	testResult.OverallClientLatencies = overallClientLatencies
+	testResult.OverallGraphInternalLatencies = overallGraphInternalLatencies
+	testResult.AbsoluteInternalExternalLatencyDiff = absoluteLatencyDiff
+	testResult.RelativeInternalExternalLatencyDiff = relativeLatencyDiff
 	testResult.OverallQueryRates = GetOverallRatesMap(duration, queries, clientSide_PerQuery_OverallLatencies, clientSide_AllQueries_OverallLatencies)
 	testResult.DBSpecificConfigs = GetDBConfigsMap(redisgraphVersion)
 	testResult.Totals = GetTotalsMap(queries, clientSide_PerQuery_OverallLatencies, clientSide_AllQueries_OverallLatencies, errorsPerQuery, totalNodesCreatedPerQuery, totalNodesDeletedPerQuery, totalLabelsAddedPerQuery, totalPropertiesSetPerQuery, totalRelationshipsCreatedPerQuery, totalRelationshipsDeletedPerQuery)

test_result.go

@@ -6,6 +6,7 @@ import (
 	"github.com/HdrHistogram/hdrhistogram-go"
 	"io/ioutil"
 	"log"
+	"math"
 	"os"
 	"sync"
 	"sync/atomic"
@@ -63,6 +64,12 @@ type TestResult struct {
 	// Overall Graph Internal Quantiles
 	OverallGraphInternalLatencies map[string]interface{} `json:"OverallGraphInternalLatencies"`
 
+	// Relative Internal External Latencies Differences
+	RelativeInternalExternalLatencyDiff map[string]float64 `json:"OverallRelativeInternalExternalLatencyDiff"`
+
+	// Relative Internal External Latencies Differences
+	AbsoluteInternalExternalLatencyDiff map[string]float64 `json:"OverallAbsoluteInternalExternalLatencyDiff"`
+
 	// Per second ( tick ) client stats
 	ClientRunTimeStats map[int64]interface{} `json:"ClientRunTimeStats"`
 
@@ -188,15 +195,33 @@ func generateLatenciesMap(hist *hdrhistogram.Histogram) (int64, map[string]float
 	return ops, mp
 }
 
-func GetOverallLatencies(cmds []string, perQueryHistograms []*hdrhistogram.Histogram, totalsHistogram *hdrhistogram.Histogram) map[string]interface{} {
+func GetOverallLatencies(cmds []string, perQueryHistograms []*hdrhistogram.Histogram, totalsHistogram *hdrhistogram.Histogram) (map[string]interface{}, map[string]float64) {
 	perQueryQuantileMap := map[string]interface{}{}
 	for i, query := range cmds {
 		_, quantileMap := generateLatenciesMap(perQueryHistograms[i])
 		perQueryQuantileMap[query] = quantileMap
 	}
 	_, totalMap := generateLatenciesMap(totalsHistogram)
 	perQueryQuantileMap["Total"] = totalMap
-	return perQueryQuantileMap
+	return perQueryQuantileMap, totalMap
+}
+
+func GenerateInternalExternalRatioLatencies(internal map[string]float64, external map[string]float64) (ratioMap map[string]float64, absoluteMap map[string]float64) {
+	ratioMap = map[string]float64{}
+	absoluteMap = map[string]float64{}
+	for quantile, internalQuantileValue := range internal {
+
+		externalQuantileValue := external[quantile]
+		absoluteDiff := externalQuantileValue - internalQuantileValue
+		relativeDiff := externalQuantileValue / internalQuantileValue
+		if !math.IsNaN(relativeDiff) {
+			ratioMap[quantile] = relativeDiff
+		}
+		if !math.IsNaN(absoluteDiff) {
+			absoluteMap[quantile] = absoluteDiff
+		}
+	}
+	return
 }
 
 func GetOverallRatesMap(took time.Duration, cmds []string, perQueryHistograms []*hdrhistogram.Histogram, totalsHistogram *hdrhistogram.Histogram) map[string]interface{} {