Datasource rediscloud_database causes panic in version 2.1.4

[atsui-bay1]

I attempted to upgrade from version 2.0.0 to 2.1.4 and encountered the following panic

Terraform:

data "rediscloud_database" "database" {
  subscription_id = "<My Subscription Id>"
  name            = "shared"
}

Error:

Planning failed. Terraform encountered an error while generating this plan.

╷
│ Error: Plugin did not respond
│ 
│   with data.rediscloud_database.database,
│   on redis.tf line 23, in data "rediscloud_database" "database":
│   23: data "rediscloud_database" "database" {
│ 
│ The plugin encountered an error, and failed to respond to the plugin.(*GRPCProvider).ReadDataSource call. The plugin logs may contain more details.
╵
╷
│ Error: Request cancelled
│ 
│   with data.rediscloud_database.database,
│   on redis.tf line 23, in data "rediscloud_database" "database":
│   23: data "rediscloud_database" "database" {
│ 
│ The plugin.(*GRPCProvider).ReadDataSource request was cancelled.
╵

Stack trace from the terraform-provider-rediscloud_v2.1.5 plugin:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x8 pc=0x100cdf288]

goroutine 58 [running]:
github.com/RedisLabs/terraform-provider-rediscloud/provider.dataSourceRedisCloudProDatabaseRead({0x1012789d8, 0x140003cea10}, 0x14000411900, {0x1010f5220?, 0x1400007e750})
        github.com/RedisLabs/terraform-provider-rediscloud/provider/datasource_rediscloud_pro_database.go:484 +0x1a18
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0x140001bd800, {0x101278930, 0x140001b6a20}, 0x14000411900, {0x1010f5220, 0x1400007e750})
        github.com/hashicorp/terraform-plugin-sdk/v2@v2.36.1/helper/schema/resource.go:855 +0xe4
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).ReadDataApply(0x140001bd800, {0x101278930, 0x140001b6a20}, 0x14000411800, {0x1010f5220, 0x1400007e750})
        github.com/hashicorp/terraform-plugin-sdk/v2@v2.36.1/helper/schema/resource.go:1075 +0x110
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ReadDataSource(0x14000354720, {0x101278930?, 0x140001b67e0?}, 0x140001b6780)
        github.com/hashicorp/terraform-plugin-sdk/v2@v2.36.1/helper/schema/grpc_provider.go:1474 +0x5a4
github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server.(*server).ReadDataSource(0x14000424640, {0x101278930?, 0x140000b3890?}, 0x140003a4fa0)
        github.com/hashicorp/terraform-plugin-go@v0.26.0/tfprotov5/tf5server/server.go:688 +0x1d8
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ReadDataSource_Handler({0x10124d340, 0x14000424640}, {0x101278930, 0x140000b3890}, 0x14000411300, 0x0)
        github.com/hashicorp/terraform-plugin-go@v0.26.0/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:665 +0x1c0
google.golang.org/grpc.(*Server).processUnaryRPC(0x14000276200, {0x101278930, 0x140000b3830}, 0x14000470f00, 0x14000405a70, 0x1018076a0, 0x0)
        google.golang.org/grpc@v1.69.4/server.go:1392 +0xc58
google.golang.org/grpc.(*Server).handleStream(0x14000276200, {0x101279148, 0x140004fc000}, 0x14000470f00)
        google.golang.org/grpc@v1.69.4/server.go:1802 +0x910
google.golang.org/grpc.(*Server).serveStreams.func2.1()
        google.golang.org/grpc@v1.69.4/server.go:1030 +0x8c
created by google.golang.org/grpc.(*Server).serveStreams.func2 in goroutine 23
        google.golang.org/grpc@v1.69.4/server.go:1041 +0x13c

Error: The terraform-provider-rediscloud_v2.1.5 plugin crashed!

[leonkatsevman]

Hi @atsui-bay1 , thank you for your input .
I have tried to reproduce on version redislabs/rediscloud v2.1.5 using the following script

`
resource "rediscloud_subscription_database" "tf-example-db" {
subscription_id = rediscloud_subscription.tf-example.id
protocol = "redis"
name = "database-name"
memory_limit_in_gb = 1
data_persistence = "none"
throughput_measurement_by = "operations-per-second"
throughput_measurement_value = 10000
support_oss_cluster_api = false
external_endpoint_for_oss_cluster_api = false
replication = true
modules = [
{
name = "RedisJSON"
},
{
name = "RedisBloom"
}
]
alert {
name = "dataset-size"
value = 40
}
}

data "rediscloud_database" "database" {
subscription_id = rediscloud_subscription.tf-example.id
name = "database-name"
}
`

terraform plan passed successfully

can you please share your script

[atsui-bay1]

Hello @leonkatsevman ,

Interestingly, I was able to reproduce it with your script exactly. I noticed in your plan that is is doing an essentials database, but your Terraform code is for a non-essentials database?

Either way, here is my script

resource "rediscloud_subscription_database" "example" {

  subscription_id = rediscloud_subscription.subscription.id
  name            = "example"
  port            = 10500

  memory_limit_in_gb           = 1
  data_persistence = "none"
  throughput_measurement_by    = "operations-per-second"
  throughput_measurement_value = 10000

  replication   = true
  resp_version  = "resp3"
  data_eviction = "volatile-lru"

  enable_default_user = false
}

data "rediscloud_database" "database" {
  subscription_id = rediscloud_subscription.subscription.id
  name            = "example"
}

Planning failed. Terraform encountered an error while generating this plan.

╷
│ Error: Plugin did not respond
│ 
│   with data.rediscloud_database.database,
│   on data.tf line 84, in data "rediscloud_database" "database":
│   84: data "rediscloud_database" "database" {
│ 
│ The plugin encountered an error, and failed to respond to the plugin.(*GRPCProvider).ReadDataSource call. The plugin logs may contain more details.
╵

Stack trace from the terraform-provider-rediscloud_v2.1.5 plugin:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x8 pc=0x101463288]

goroutine 59 [running]:
github.com/RedisLabs/terraform-provider-rediscloud/provider.dataSourceRedisCloudProDatabaseRead({0x1019fc9d8, 0x1400014e7e0}, 0x140001a2a80, {0x101879220?, 0x14000158120})
        github.com/RedisLabs/terraform-provider-rediscloud/provider/datasource_rediscloud_pro_database.go:484 +0x1a18
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0x140001bd800, {0x1019fc930, 0x14000190ff0}, 0x140001a2a80, {0x101879220, 0x14000158120})
        github.com/hashicorp/terraform-plugin-sdk/v2@v2.36.1/helper/schema/resource.go:855 +0xe4
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).ReadDataApply(0x140001bd800, {0x1019fc930, 0x14000190ff0}, 0x14000714500, {0x101879220, 0x14000158120})
        github.com/hashicorp/terraform-plugin-sdk/v2@v2.36.1/helper/schema/resource.go:1075 +0x110
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ReadDataSource(0x14000356708, {0x1019fc930?, 0x14000190f30?}, 0x14000190ed0)
        github.com/hashicorp/terraform-plugin-sdk/v2@v2.36.1/helper/schema/grpc_provider.go:1474 +0x5a4
github.com/hashicorp/terraform-plugin-go/tfprotov5/tf5server.(*server).ReadDataSource(0x14000426640, {0x1019fc930?, 0x140001900c0?}, 0x14000716000)
        github.com/hashicorp/terraform-plugin-go@v0.26.0/tfprotov5/tf5server/server.go:688 +0x1d8
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ReadDataSource_Handler({0x1019d1340, 0x14000426640}, {0x1019fc930, 0x140001900c0}, 0x14000714000, 0x0)
        github.com/hashicorp/terraform-plugin-go@v0.26.0/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:665 +0x1c0
google.golang.org/grpc.(*Server).processUnaryRPC(0x14000278200, {0x1019fc930, 0x14000190060}, 0x1400010e5a0, 0x14000407a40, 0x101f8b6a0, 0x0)
        google.golang.org/grpc@v1.69.4/server.go:1392 +0xc58
google.golang.org/grpc.(*Server).handleStream(0x14000278200, {0x1019fd148, 0x14000518000}, 0x1400010e5a0)
        google.golang.org/grpc@v1.69.4/server.go:1802 +0x910
google.golang.org/grpc.(*Server).serveStreams.func2.1()
        google.golang.org/grpc@v1.69.4/server.go:1030 +0x8c
created by google.golang.org/grpc.(*Server).serveStreams.func2 in goroutine 20
        google.golang.org/grpc@v1.69.4/server.go:1041 +0x13c

Error: The terraform-provider-rediscloud_v2.1.5 plugin crashed!

This is always indicative of a bug within the plugin. It would be immensely
helpful if you could report the crash with the plugin's maintainers so that it
can be fixed. The output above should help diagnose the issue.

[leonkatsevman]

➜ qa terraform apply
rediscloud_essentials_subscription.subscription-resource: Refreshing state... [id=201348]
rediscloud_essentials_database.database-resource: Refreshing state... [id=201348/51481151]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:

• create

• destroy
  <= read (data resources)

I was able to run both plan and apply , might be it is some local branch conflict ?
is it reproduced in new TF init folder ?
@atsui-bay1 Thank you for continuing to contribute to the Redis Terraform Provider. Your efforts are appreciated.

[atsui-bay1]

Hi @leonkatsevman

I have tried purging my init folder, and creating a new subscription/database a couple times now and I still hit the error.

From the error message, it looks related to QPF for Redis Query Engine (its failing at https://github.com/RedisLabs/terraform-provider-rediscloud/blob/main/provider/datasource_rediscloud_pro_database.go#L484). Is this enabled by default for all pro subscriptions/clusters? I wasn't able to find a way to confirm if this was enabled for my databases (I am on Redis 7.4.2). Also, I'm still not sure why your output shows an essentials database?

[leonkatsevman]

@atsui-bay1 we will add a fix in the upcoming release
thank you for your input