release: 0.10.4-beta.0

Author: Rel1cx

CHANGELOG.md

@@ -4,6 +4,10 @@
 
 - Improve rule `react/no-unstable-default-props` to support checking for ObjectPatterns within VariableDeclarators that occur on props.
 
+### 🐞 Fixes
+
+- Fix same kind of error inside a component should not only be reported once in rule `react/no-create-ref` and `react/no-constructed-context-value`.
+
 ## v0.10.3 (Fri Jan 5 2024)
 
 ### 🪄 Improvements

packages/plugins/eslint-plugin-react/src/rules/no-constructed-context-value.ts

@@ -35,7 +35,7 @@ export default createRule<[], MessageID>({
   create(context) {
     const { ctx, listeners } = useComponentCollector(context);
     const detectConstruction = constructionDetector(context);
-    const possibleValueConstructions = new Map<TSESTreeFunction, ERConstruction>();
+    const possibleValueConstructions = new Map<TSESTreeFunction, ERConstruction[]>();
 
     return {
       ...listeners,
@@ -55,30 +55,34 @@ export default createRule<[], MessageID>({
         const valueExpression = valueNode.expression;
         const constructionDetail = detectConstruction(valueExpression);
         if (constructionDetail._tag === "None") return;
-        O.map(ctx.getCurrentFunction(), ([currentFn]) => possibleValueConstructions.set(currentFn, constructionDetail));
+        O.map(
+          ctx.getCurrentFunction(),
+          ([currentFn]) =>
+            possibleValueConstructions.set(currentFn, [
+              ...possibleValueConstructions.get(currentFn) ?? [],
+              constructionDetail,
+            ]),
+        );
       },
       "Program:exit"(node) {
         const components = Array.from(ctx.getAllComponents(node).values());
-        for (const [fn, detail] of possibleValueConstructions.entries()) {
-          if (
-            !components.some((component) => component.node === fn)
-            || detail._tag === "None"
-          ) {
-            continue;
+        for (const { node: component } of components) {
+          const constructions = possibleValueConstructions.get(component);
+          if (!constructions) continue;
+          for (const construction of constructions) {
+            if (construction._tag === "None") continue;
+            const { _tag, node: constructionNode } = construction;
+            const messageId = _tag.startsWith("Function")
+              ? "NO_CONSTRUCTED_CONTEXT_VALUE_WITH_FUNCTION"
+              : "NO_CONSTRUCTED_CONTEXT_VALUE_WITH_IDENTIFIER";
+            context.report({
+              node: constructionNode,
+              messageId,
+              data: {
+                type: constructionNode.type,
+              },
+            });
           }
-
-          const messageId = detail._tag.startsWith("Function")
-            ? "NO_CONSTRUCTED_CONTEXT_VALUE_WITH_FUNCTION"
-            : "NO_CONSTRUCTED_CONTEXT_VALUE_WITH_IDENTIFIER";
-          const { _tag, node } = detail;
-
-          context.report({
-            data: {
-              type: _tag.replaceAll("_", "").toLowerCase(),
-            },
-            messageId,
-            node,
-          });
         }
       },
     };

packages/plugins/eslint-plugin-react/src/rules/no-create-ref.ts

@@ -28,22 +28,29 @@ export default createRule<[], MessageID>({
   defaultOptions: [],
   create(context) {
     const { ctx, listeners } = useComponentCollector(context);
-    const possibleCreateRefCalls = new Map<TSESTreeFunction, TSESTree.CallExpression>();
+    const possibleCreateRefCalls = new Map<TSESTreeFunction, TSESTree.CallExpression[]>();
 
     return {
       ...listeners,
       CallExpression(node) {
         if (!isCreateRefCall(node, context)) return;
-        O.map(ctx.getCurrentFunction(), ([currentFn]) => possibleCreateRefCalls.set(currentFn, node));
+        O.map(
+          ctx.getCurrentFunction(),
+          ([currentFn]) =>
+            possibleCreateRefCalls.set(currentFn, [...possibleCreateRefCalls.get(currentFn) ?? [], node]),
+        );
       },
       "Program:exit"(node) {
         const components = Array.from(ctx.getAllComponents(node).values());
-        for (const [fn, call] of possibleCreateRefCalls.entries()) {
-          if (!components.some((component) => component.node === fn)) continue;
-          context.report({
-            messageId: "NO_CREATE_REF",
-            node: call,
-          });
+        for (const { node: component } of components) {
+          const createRefCalls = possibleCreateRefCalls.get(component);
+          if (!createRefCalls) continue;
+          for (const createRefCall of createRefCalls) {
+            context.report({
+              node: createRefCall,
+              messageId: "NO_CREATE_REF",
+            });
+          }
         }
       },
     };