fix - infodialog does not show when no internet connection

Author: felixholfelder

helper/SystemHelper.py

@@ -71,6 +71,9 @@ def close_keyboard(self):
         os.system("pkill wvkbd-mobintl")
 
     def get_default_interface(self):
+        if netifaces.gateways()["default"] == {}:
+            return None
+
         return netifaces.gateways()["default"][netifaces.AF_INET][1]
 
     def get_current_ssid(self):
@@ -79,21 +82,22 @@ def get_current_ssid(self):
 
     def get_ip_address(self):
         ifname = self.get_default_interface()
-        return netifaces.ifaddresses(ifname)[netifaces.AF_INET][0]["addr"]
+        return "" if ifname is None else netifaces.ifaddresses(ifname)[netifaces.AF_INET][0]["addr"]
 
     def get_hostname(self):
         return socket.gethostname()
 
     def get_netmask(self):
         ifname = self.get_default_interface()
-        return netifaces.ifaddresses(ifname)[netifaces.AF_INET][0]["netmask"]
+        return "" if ifname is None else netifaces.ifaddresses(ifname)[netifaces.AF_INET][0]["netmask"]
 
     def get_mac_address(self):
         ifname = self.get_default_interface()
-        return netifaces.ifaddresses(ifname)[netifaces.AF_LINK][0]["addr"]
+        return "" if ifname is None else netifaces.ifaddresses(ifname)[netifaces.AF_LINK][0]["addr"]
 
     def get_gateway(self):
-        return netifaces.gateways()["default"][netifaces.AF_INET][0]
+        ifname = self.get_default_interface()
+        return "" if ifname is None else netifaces.gateways()["default"][netifaces.AF_INET][0]
 
     def get_dns_servers(self):
         dns_servers = []
@@ -104,18 +108,9 @@ def get_dns_servers(self):
         return dns_servers
 
     def get_network_config(self):
-        try:
-            return {
-                "ssid": self.get_current_ssid(),
-                "ip": self.get_ip_address(),
-                "hostname": self.get_hostname(),
-                "subnetmask": self.get_netmask(),
-                "mac_address": self.get_mac_address(),
-                "gateway": self.get_gateway(),
-                "dns": self.get_dns_servers(),
-            }
-        except Exception:
+        if self.get_default_interface() is None:
             return {
+                "ssid": "",
                 "ip": "",
                 "hostname": "",
                 "subnetmask": "",
@@ -124,6 +119,16 @@ def get_network_config(self):
                 "dns": ["", ""],
             }
 
+        return {
+            "ssid": self.get_current_ssid(),
+            "ip": self.get_ip_address(),
+            "hostname": self.get_hostname(),
+            "subnetmask": self.get_netmask(),
+            "mac_address": self.get_mac_address(),
+            "gateway": self.get_gateway(),
+            "dns": self.get_dns_servers(),
+        }
+
     def change_screen_brightness(self, value):
         brightness = int(value / 100 * 255)
         os.system(f"sudo echo {brightness} > /sys/class/backlight/10-0045/brightness")