Include cust_raw in cargo doc testing on CI.
#330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnethercote
force-pushed
the
cargo-doc-cust_raw
branch
from
7a6d22c to
1d10e6b
Compare
In `cust_raw`, we derive `PartialEq`/`Eq`/`PartialOrd`/`Ord` for all types by default. However, `cudaHostNodeParams` and `cudaHostNodeParamsV2` each contain a raw pointer, which causes this warning: ``` function pointer comparisons do not produce meaningful results since their addresses are not guaranteed to be unique ``` bindgen has a `no_partialeq` function that disables all of these derives for relevant types. Only `PartialOrd`/`Ord` cause a problem, but there is no easy way to disable those while keeping `PartialEq`/`Eq`, so this will have to do. We already use `no_partialeq` for `CUDA_HOST_NODE_PARAMS.*` and various other types.
Even with doxygen-binding, there are hundreds of warnings, due to (a) bad Doxygen formatting in the CUDA comments, and (b) shortcomings in doxygen-bindgen. Fixing these would be difficult, so disabling comments entirely seems easier. This also removes the dependency on doxygen-bindgen.
Now that all the warnings have been fixed.
nnethercote
force-pushed
the
cargo-doc-cust_raw
branch
from
1d10e6b to
fc0d5b8
Compare
LegNeato
approved these changes
Dec 3, 2025
nnethercote
added a commit
to nnethercote/Rust-CUDA
that referenced
this pull request
Dec 3, 2025
These should have been removed in Rust-GPU#330.
nnethercote
added a commit
to nnethercote/Rust-CUDA
that referenced
this pull request
Dec 4, 2025
These should have been removed in Rust-GPU#330.
LegNeato
pushed a commit
that referenced
this pull request
Dec 5, 2025
These should have been removed in #330.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo doccurrently generates hundreds of warnings oncust_raw. This PR fixes them.