Skip to content

Commit e447d7d

Browse files
committed
Fix lints.
1 parent f26befc commit e447d7d

File tree

7 files changed

+10
-11
lines changed

7 files changed

+10
-11
lines changed

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ license = "MIT"
88
name = "jack"
99
readme = "README.md"
1010
repository = "https://github.com/RustAudio/rust-jack"
11-
version = "0.13.1"
11+
version = "0.13.2"
1212

1313
[dependencies]
1414
bitflags = "2"

src/client/callbacks.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -496,9 +496,7 @@ where
496496
///
497497
/// # TODO
498498
///
499-
/// * Implement correctly. Freezes on my system.
500-
501-
//maybe this makes sense now? it doesn't disturb my program
499+
/// * Implement correctly. Freezes on my system. Maybe this makes sense now? it doesn't disturb my program
502500
pub unsafe fn clear_callbacks(client: *mut j::jack_client_t) -> Result<(), Error> {
503501
j::jack_set_thread_init_callback(client, None, std::ptr::null_mut());
504502
j::jack_set_process_callback(client, None, std::ptr::null_mut());

src/client/client_impl.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ use crate::{
2828
/// Err(e) => println!("Failed to open client because of error: {:?}", e),
2929
/// };
3030
/// ```
31-
3231
pub type InternalClientID = j::jack_intclient_t;
3332

3433
#[allow(dead_code)]

src/port/audio.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ use crate::{Port, PortFlags, PortSpec, ProcessScope};
77
/// endpoint for JACK. In this case, it is a readable 32 bit floating
88
/// point buffer for audio.
99
///
10-
/// [`AudioIn::buffer()`] is used to gain access the buffer.
10+
/// [`Port::as_slice()`] is used to gain access the buffer.
1111
///
1212
/// # Example
1313
/// ```
@@ -26,7 +26,7 @@ pub struct AudioIn {
2626
/// endpoint for JACK. In this case, it is a mutable 32 bit floating
2727
/// point buffer for audio.
2828
///
29-
/// [`AudioOut::buffer()`] is used to gain access the buffer.
29+
/// [`Port::as_mut_slice()`] is used to gain access the buffer.
3030
///
3131
/// # Example
3232
/// ```

src/port/midi.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ pub struct MidiIter<'a> {
6565
_phantom: PhantomData<&'a ()>,
6666
}
6767

68-
unsafe impl<'a> Sync for MidiIter<'a> {}
68+
unsafe impl Sync for MidiIter<'_> {}
6969

7070
impl<'a> MidiIter<'a> {
7171
/// Return the next element without advancing the iterator.
@@ -175,7 +175,7 @@ pub struct MidiWriter<'a> {
175175
_phantom: PhantomData<&'a ()>,
176176
}
177177

178-
impl<'a> MidiWriter<'a> {
178+
impl MidiWriter<'_> {
179179
/// Write an event into an event port buffer.
180180
///
181181
/// Clients must write normalised MIDI data to the port - no running status and no (1-byte)

src/tests/log.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ fn can_set_logger() {
1010
error: test_error_callback,
1111
});
1212
#[cfg(feature = "dynamic_loading")]
13-
#[allow(clippy::fn_address_comparisons)]
13+
#[allow(unpredictable_function_pointer_comparisons)]
1414
unsafe {
1515
let lib = jack_sys::library().unwrap();
1616
type LogFn = unsafe extern "C" fn(*const libc::c_char);

src/tests/mod.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
use std::sync::LazyLock;
22

3+
use ctor::ctor;
4+
35
use crate::{Client, ClientOptions};
46

57
mod client;
@@ -15,7 +17,7 @@ pub static DEFAULT_TEST_CLIENT: LazyLock<Client> = LazyLock::new(|| {
1517
.0
1618
});
1719

18-
#[ctor::ctor]
20+
#[ctor]
1921
fn log_to_stdio() {
2022
crate::set_logger(crate::LoggerType::Stdio);
2123
}

0 commit comments

Comments
 (0)