Skip to content

Commit cd8b660

Browse files
committed
fix(ui5-tokenizer): sync popover list items with token text changes
apply code review comments
1 parent 2e84b47 commit cd8b660

File tree

1 file changed

+13
-16
lines changed

1 file changed

+13
-16
lines changed

packages/main/cypress/specs/Tokenizer.cy.tsx

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -222,28 +222,25 @@ describe("Tokenizer - Popover List Item Text Updates", () => {
222222
</Tokenizer>
223223
);
224224

225-
cy.get("#test-token-text-update")
225+
cy.get<Tokenizer>("[ui5-tokenizer]")
226226
.shadow()
227227
.find(".ui5-tokenizer-more-text")
228228
.realClick();
229229

230-
cy.get("#test-token-text-update")
230+
cy.get<Tokenizer>("[ui5-tokenizer]")
231231
.shadow()
232232
.find("[ui5-responsive-popover]")
233233
.should("be.visible");
234234

235-
cy.get("#test-token-text-update")
235+
cy.get<Tokenizer>("[ui5-tokenizer]")
236236
.shadow()
237237
.find("[ui5-responsive-popover] [ui5-list] [ui5-li]")
238238
.eq(0)
239239
.should("have.attr", "text", "Original Text");
240240

241-
cy.get("#token-to-modify").then($token => {
242-
const token = $token.get(0) as Token;
243-
token.text = "Updated Text";
244-
});
241+
cy.get("#token-to-modify").invoke("prop", "text", "Updated Text");
245242

246-
cy.get("#test-token-text-update")
243+
cy.get<Tokenizer>("[ui5-tokenizer]")
247244
.shadow()
248245
.find("[ui5-responsive-popover] [ui5-list] [ui5-li]")
249246
.eq(0)
@@ -267,47 +264,47 @@ describe("Tokenizer - Popover List Item Text Updates", () => {
267264
</Tokenizer>
268265
);
269266

270-
cy.get("#test-multiple-token-updates")
267+
cy.get<Tokenizer>("[ui5-tokenizer]")
271268
.shadow()
272269
.find(".ui5-tokenizer-more-text")
273270
.realClick();
274271

275-
cy.get("#test-multiple-token-updates")
272+
cy.get<Tokenizer>("[ui5-tokenizer]")
276273
.shadow()
277274
.find("[ui5-responsive-popover] [ui5-list] [ui5-li]")
278275
.eq(0)
279276
.should("have.attr", "text", "Token 1");
280277

281-
cy.get("#test-multiple-token-updates")
278+
cy.get<Tokenizer>("[ui5-tokenizer]")
282279
.shadow()
283280
.find("[ui5-responsive-popover] [ui5-list] [ui5-li]")
284281
.eq(1)
285282
.should("have.attr", "text", "Token 2");
286283

287-
cy.get("#token-1").then($token => {
284+
cy.get<Token>("[ui5-token]").then($token => {
288285
const token = $token.get(0) as Token;
289286
token.text = "Modified Token 1";
290287
});
291288

292-
cy.get("#token-2").then($token => {
289+
cy.get<Token>("[ui5-token]").then($token => {
293290
const token = $token.get(0) as Token;
294291
token.text = "Modified Token 2";
295292
});
296293

297-
cy.get("#test-multiple-token-updates")
294+
cy.get<Tokenizer>("[ui5-tokenizer]")
298295
.shadow()
299296
.find("[ui5-responsive-popover] [ui5-list] [ui5-li]")
300297
.eq(0)
301298
.should("have.attr", "text", "Modified Token 1");
302299

303-
cy.get("#test-multiple-token-updates")
300+
cy.get<Tokenizer>("[ui5-tokenizer]")
304301
.shadow()
305302
.find("[ui5-responsive-popover] [ui5-list] [ui5-li]")
306303
.eq(1)
307304
.should("have.attr", "text", "Modified Token 2");
308305

309306
// Verify unchanged token remains the same
310-
cy.get("#test-multiple-token-updates")
307+
cy.get<Tokenizer>("[ui5-tokenizer]")
311308
.shadow()
312309
.find("[ui5-responsive-popover] [ui5-list] [ui5-li]")
313310
.eq(2)

0 commit comments

Comments
 (0)